Extension management page shows "ERROR" for console logs |
||
Issue descriptionChrome Version: 67.0.3396.10 (Official Build) dev (64-bit) OS: Mac OS What steps will reproduce the problem? (1)Place any console.log in extension script (2)Load extension (3)View extension on extension management page - displays bold red "ERROR" Showing an error for an intentional log can be alarm to extension developers. Maybe remove console.logs from causing extension management to display error.
,
Apr 27 2018
Logs can be useful, and a red "Error" button does seem more severe than it should be if you only have logs. Maybe making it black and re-labeling to "Error Console" or "Developer Console"?
,
Apr 27 2018
Logs can be useful, but then you'd probably just open up dev tools, I'd think. I think relabeling is a bit tricky because of length concerns, and also because some other errors (that are really errors) are shown there. Maybe leave warnings, but omit logs, and keep the UX treatment the same to avoid significant UX changes? And then if developers see they have an error and want to dive deeper and see the logs, they could inspect the page throwing the errors? WDYT?
,
Apr 30 2018
I would prefer to stop showing console.log() messages in the "error console", than renaming the error console to be something more generic. As a general direction, I think reducing (or at least not increasing) the overlap between error console and DevTools would be better, both in terms of maintenance, but also for the users (to not confuse them about the purpose of "error console" feature).
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bc471caffeecea5f1b4b2d4fa99c58520571949 commit 5bc471caffeecea5f1b4b2d4fa99c58520571949 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri May 04 22:58:27 2018 [Extensions] Don't store logs in the error console The error console shows errors that were reported across all the different contexts an extension runs in (e.g., content scripts, background pages, etc). It should ignore logs, though, so as to avoid being overly noisy. Keep reporting warnings for now. Add a unittest for the same. Bug: 837401 Change-Id: I4a0d89f85f2cfd31f2cb3a29051b8598bd78fafc Reviewed-on: https://chromium-review.googlesource.com/1043156 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556232} [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/chrome/browser/extensions/error_console/error_console.cc [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/chrome/browser/extensions/error_console/error_console_browsertest.cc [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/chrome/browser/extensions/error_console/error_console_unittest.cc [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/chrome/test/data/extensions/error_console/content_script_log_and_runtime_error/content_script.js [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/extensions/browser/extension_error_test_util.cc [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/extensions/common/constants.cc [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/extensions/common/constants.h [modify] https://crrev.com/5bc471caffeecea5f1b4b2d4fa99c58520571949/extensions/renderer/extensions_render_frame_observer.cc
,
May 7 2018
,
Jun 1 2018
,
Jun 1 2018
,
Jul 2
Issue 859334 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by rdevlin....@chromium.org
, Apr 27 2018Components: UI>Browser>ExtensionsManagement
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)