New issue
Advanced search Search tips

Issue 837394 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
cast-ux-chromeos


Sign in to add a comment

[Media Router] Update system tray strings for consistency with MR UX

Project Member Reported by mfo...@chromium.org, Apr 26 2018

Issue description

The system tray prepends "Casting" in front of media route descriptions.

However the route descriptions already say "Casting" so you end up with "Casting Casting tab"

To repro, start tab casting a site from the Cast dialog, then examine the system tray.

 

Comment 2 by mfo...@chromium.org, Jun 12 2018

Owner: mfo...@chromium.org
Status: Assigned (was: Available)

Comment 3 by mfo...@chromium.org, Jun 26 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c97d59ac93b0e4e67809ba4cefa5603b8f78616

commit 9c97d59ac93b0e4e67809ba4cefa5603b8f78616
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri Jul 13 18:06:25 2018

[Media Router] Update ChromeOS system tray UI.

Media route descriptions are not intended to be used as part of a larger string.
This change brings the ChromeOS system tray strings in line with the current set
of media route descriptions and avoids strings that start with "Casting Casting".

Before/after screenshots:

https://drive.google.com/drive/folders/1yPo-Gx_a2D6OGAQM715DU7vthKl2fH1o?usp=sharing

Bug:  837394 
Change-Id: Iac4a443a361ad3fd457059f6b4588ab2edc4ecda
Reviewed-on: https://chromium-review.googlesource.com/1128330
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574976}
[modify] https://crrev.com/9c97d59ac93b0e4e67809ba4cefa5603b8f78616/ash/ash_strings.grd
[modify] https://crrev.com/9c97d59ac93b0e4e67809ba4cefa5603b8f78616/ash/system/cast/cast_notification_controller.cc
[modify] https://crrev.com/9c97d59ac93b0e4e67809ba4cefa5603b8f78616/chrome/browser/ui/ash/cast_config_client_media_router.cc

Status: Fixed (was: Started)

Sign in to add a comment