New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837385 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 837384

Blocking:
issue 759794



Sign in to add a comment

Embed reports stored on GCS into iframes

Project Member Reported by mmoroz@chromium.org, Apr 26 2018

Issue description

That would allow us to use Google Analytics on every page + would hide weird URLs
 

Comment 1 by mmoroz@chromium.org, Apr 27 2018

Cc: metzman@chromium.org och...@chromium.org mbarbe...@chromium.org
Hm, but how can I update the address bar when users will be surfing through a report pages... Otherwise, it's going to be tricky for them how to copy and share the page they are looking at.

Comment 2 by och...@chromium.org, Apr 30 2018

Can we just embed the analytics into the reports themselves?

Otherwise you might be able to do something with URL fragments or HTML5 history API

Comment 3 by mmoroz@chromium.org, Apr 30 2018

We can, but there are so many pages... How bad it would be if the server could go to GCS, read a particular page, and serve it back to a user? That feels like an overhead, but on the other head that way we can do whatever we need with any page without having to update anything except of the server code. For example, issue 827220 can be implemented using that approach. I should at least give it a try, I guess.
Owner: mmoroz@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/code-coverage/+/3bc3352c5eb31ba62a99eac3cb91b0106d10271f

commit 3bc3352c5eb31ba62a99eac3cb91b0106d10271f
Author: Max Moroz <mmoroz@google.com>
Date: Tue May 08 19:50:25 2018

Status: Fixed (was: Started)

Sign in to add a comment