New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 837381 link

Starred by 4 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Nov 15
Cc:
█ kochi@chromium.org
█ scottchen@chromium.org
dpa...@chromium.org
rbpotter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 806159



Sign in to add a comment

action-link should be migrated away from document.registerElement

Project Member Reported by dpa...@chromium.org, Apr 26 2018 
action-link [1] is still using document.registerElement, which (I think) is part of the Shadow DOM V0 spec. action-link uses that method to extend a native <a> element.

In order to unblock the Blink team from eventually removing support for V0, it should be migrated to the equivalent API in V1.

@kochi: Does V1 support extending native elements. I know Polymer 2 does not, but action-link is not using Polymer, it directly uses the native API.

[1] https://cs.chromium.org/chromium/src/ui/webui/resources/js/action_link.js?l=34

Comment 1 by dpa...@chromium.org, Apr 26 2018

Blocking: 806159

Comment 2 by kochi@chromium.org, Apr 26 2018 

document.registerElement is a Custom Elements V0 API, and Custom Elements V1
API is like window.customElements.define(), and you can use ES6 class-based
definition.

Blink recently added a native support for type extension to Custom Elements V1
(M67+) https://www.chromestatus.com/feature/4670146924773376
but you cannot attach V1 shadow root on many elements.

You can check the list of elements that are allowed to attach V1 shadow root.
https://dom.spec.whatwg.org/#dom-element-attachshadow

Looking at action_link code, it is extending <a> element without attaching
shadow root, so this looks an easy case and converting to Custom Element V1
API should be straightforward.

Comment 3 by dpa...@chromium.org, May 18 2018

Components: UI>Browser>WebUI

Comment 4 by dpa...@chromium.org, Jun 14 2018

Status: Available (was: Untriaged)

Comment 5 by dpa...@chromium.org, Oct 10

Cc: rbpotter@chromium.org

Comment 6 by scottchen@chromium.org, Oct 15

Cc: dpa...@chromium.org scottchen@chromium.org
 Issue 895631  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d92e6ff2ee3294fcfa882916d934664bac17ca1e

commit d92e6ff2ee3294fcfa882916d934664bac17ca1e
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Oct 16 23:54:39 2018

NUX Onboarding: Style welcome page.

Tweaked text and spacing, and added svgs as background.

See screenshot in bug.

Bug:  874142 , 837381 
Change-Id: I9910bc747d8f4e42ee22eaa97e28cdf837c2e36f
Reviewed-on: https://chromium-review.googlesource.com/c/1260303
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600194}
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/browser_resources.grd
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/blue_circle.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/green_rectangle.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/grey_oval.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/grey_rounded_rectangle.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/red_triangle.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/yellow_dots.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/yellow_semicircle.svg
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/shared/action_link_style.js
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/shared/action_link_style_css.html
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/shared/onboarding_background.html
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/shared/onboarding_background.js
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/ui/webui/welcome/welcome_ui.cc

Comment 8 by dpa...@chromium.org, Nov 14

Owner: dpa...@chromium.org
Status: Started (was: Available)
FYI, candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1336548.

After updating action-link to not use Shadow DOM v0, the "document.registerElement is deprecated ..." warning disappears from WebUI pages (on Desktop). See screenshots.
warnings_before.png
31.6 KB View Download
warnings_after.png
19.5 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d7d1f5565ebe85c29da4c8109fe3189080f8e56

commit 4d7d1f5565ebe85c29da4c8109fe3189080f8e56
Author: dpapad <dpapad@chromium.org>
Date: Thu Nov 15 02:06:13 2018

WebUI: Update action-link element to use Shadow DOM v1.

Bug:  837381 
Change-Id: I5421657d43646c768def7a5ccf235b9eb483e2e2
Reviewed-on: https://chromium-review.googlesource.com/c/1336548
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608224}
[modify] https://crrev.com/4d7d1f5565ebe85c29da4c8109fe3189080f8e56/ui/webui/resources/js/action_link.js

Comment 10 by dpa...@chromium.org, Nov 15

Status: Fixed (was: Started)
►

Sign in to add a comment