New issue
Advanced search Search tips

Issue 837371 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allow for Chrome components to be not present while an update check occurs

Project Member Reported by sorin@chromium.org, Apr 26 2018

Issue description

The update_client component makes an assumption that the CRX components continue to be present while an update check is in progress. This may not be true is a CRX is uninstalled while it is being checked for updates.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d

commit 7c22795b024ea3a6ecdcde89fd6c0503c74eba4d
Author: Sorin Jianu <sorin@chromium.org>
Date: Thu Apr 26 22:16:52 2018

Replace CrxComponent with std::unique_ptr<CrxComponent>.

This is a mechanical refactoring. A future CL will change the behavior to
allow injecting nullptr as a CrxComponent when the CRX is uninstalled
during an update check.

Bug:  837371 ,722942

Change-Id: I5f70fdd032a37c08bf35a286c51b109a2ca07ce0
Reviewed-on: https://chromium-review.googlesource.com/1027116
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554166}
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/component_updater/component_updater_service_internal.h
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/action_runner.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/component.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/component.h
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/ping_manager.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/protocol_builder.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_checker.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_client.h
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_engine.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/extensions/browser/updater/update_data_provider.h
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/extensions/browser/updater/update_data_provider_unittest.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/extensions/browser/updater/update_service_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acaf3d1b2a7656e32b042d44c608b921e05be8cf

commit acaf3d1b2a7656e32b042d44c608b921e05be8cf
Author: Sorin Jianu <sorin@chromium.org>
Date: Wed May 02 20:56:48 2018

Fix bug in the UpdateDataProvider::GetData.

The returned vector must contain a nullptr for an extension id that
does not exist.

Bug:  837371 

Change-Id: I1e81a64c64c6a1d2b0cb9a76a278836c7412eb07
Reviewed-on: https://chromium-review.googlesource.com/1037906
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555505}
[modify] https://crrev.com/acaf3d1b2a7656e32b042d44c608b921e05be8cf/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/acaf3d1b2a7656e32b042d44c608b921e05be8cf/extensions/browser/updater/update_data_provider_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad500fba0e02a219c6b8d7714a2bb56856234a3d

commit ad500fba0e02a219c6b8d7714a2bb56856234a3d
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Thu May 03 17:31:02 2018

[Extensions] Browser test for missing extension in extension updater.

Add a browser test for extension updater when an extension is uninstalled
in the middle of an update session.

This is to verify changes in https://chromium-review.googlesource.com/1033468
and https://chromium-review.googlesource.com/1037906.

Bug:  837371 
Change-Id: I9754b21b0afb67b158c2b36b795898fb584d432e
Reviewed-on: https://chromium-review.googlesource.com/1041161
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555787}
[modify] https://crrev.com/ad500fba0e02a219c6b8d7714a2bb56856234a3d/chrome/browser/extensions/updater/update_service_browsertest.cc

Comment 5 by sorin@chromium.org, May 11 2018

Status: Fixed (was: Started)

Sign in to add a comment