New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 837362 link

Starred by 2 users
Status: Fixed
Owner:
samans@chromium.org
Closed: May 2018
Cc:
█ fsam...@chromium.org
kylec...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 730193



Sign in to add a comment

First video frame from FrameSinkVideoCapturer does not have the right metadata

Project Member Reported by samans@chromium.org, Apr 26 2018 
Since we obtain the metadata in OnFrameDamaged which is not always called for the first frame because there could be no damage from the perspective of viz. We need to make sure FrameSinkVideoCapturer always has access to the right metadata.
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f88ba7aae81b9dcba664ca79b265a9da7e87cb4

commit 6f88ba7aae81b9dcba664ca79b265a9da7e87cb4
Author: Saman Sami <samans@chromium.org>
Date: Wed May 02 02:10:37 2018

viz: Ensure first frame from FrameSinkVideoCapturer has metadata

Currently we send the default CompositorFrameMetadata with the first
VideoFrame. This makes inspecting a remote target in DevTools buggy
when viz is enabled.

Bug:  837362 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie57e4bb290c1fa683839f7e5f09be1d5c2472b3a
Reviewed-on: https://chromium-review.googlesource.com/1035365
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555286}
[modify] https://crrev.com/6f88ba7aae81b9dcba664ca79b265a9da7e87cb4/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/6f88ba7aae81b9dcba664ca79b265a9da7e87cb4/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/6f88ba7aae81b9dcba664ca79b265a9da7e87cb4/components/viz/service/frame_sinks/video_capture/capturable_frame_sink.h
[modify] https://crrev.com/6f88ba7aae81b9dcba664ca79b265a9da7e87cb4/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc
[modify] https://crrev.com/6f88ba7aae81b9dcba664ca79b265a9da7e87cb4/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.h
[modify] https://crrev.com/6f88ba7aae81b9dcba664ca79b265a9da7e87cb4/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl_unittest.cc

Comment 2 by samans@chromium.org, May 7 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment