New issue
Advanced search Search tips

Issue 837360 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make it possible to customize git cl granularity

Project Member Reported by dcheng@chromium.org, Apr 26 2018

Issue description

I have a CL that looks like this:
 292 files changed, 499 insertions(+), 512 deletions(-)

git cl split wants to split it into 122 CLs. This seems like a fair amount of overhead for reviewing a mere 5 lines per CL.

Ideally it'd be nice if it had a way to try to group CLs into slightly larger chunks when it makes sense. When I tried using git cl split for some other changes in Blink, I got some feedback that it was sharding CLs into too many pieces as well.

 

Comment 1 by dcheng@chromium.org, Apr 26 2018

Several ways:
- we could try to enforce a minimum CL size (50+ lines might be reasonable? It's still fairly small)
- limit directory depth when searching for OWNERS
- allow a grouping preference to be passed in via a file
Components: -Infra>Client>Chrome Infra>SDK
This would be nice from an infra perspective, too. 122 CLs is also liable to cause a nontrivial amount of load on our infrastructure given how it CQ+1s everything; that particular issue is being discussed over in https://bugs.chromium.org/p/chromium/issues/detail?id=835951.

Sign in to add a comment