New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 837358 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
█ zturner@chromium.org
h...@chromium.org
thakis@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Please ensure that lld still gives a reasonable output in this case

Project Member Reported by danakj@chromium.org, Apr 26 2018 
This CL gave me a linker error that was basically not actionable on linux and mac, and only windows gives some reasonable hint. I'm worry when switching to lld that this kind of feedback would disappear. Hopefully this is a good example of where lld can improve and maybe we can improve linux/mac as well.

CL: https://chromium-review.googlesource.com/c/chromium/src/+/1028623/8

Linux:
/b/swarming/w/ir/cache/builder/src/out/Debug/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: vtable for blink::WebLayer
>>> referenced by web_layer.h:67 (../../third_party/blink/public/platform/web_layer.h:67)
>>>               obj/cc/blink/blink/web_layer_impl.o:(blink::WebLayer::WebLayer())
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Mac:
Undefined symbols for architecture x86_64:
  "vtable for blink::WebLayer", referenced from:
      blink::WebLayer::WebLayer() in web_layer_impl.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.

Windows:
web_layer_impl.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall blink::WebLayer::SetTouchEventHandlerRegion(class cc::TouchActionRegion const &)" (?SetTouchEventHandlerRegion@WebLayer@blink@@UAEXABVTouchActionRegion@cc@@@Z)
./cc_blink.dll : fatal error LNK1120: 1 unresolved externals

Comment 1 by thakis@chromium.org, Apr 26 2018 

Can you send that as a tryjob that also switches use_lld to true and check the error? I'd expect that lld-link also prints the same type of error; the difference is due to differences in export models on win and posix.

Comment 2 by danakj@chromium.org, Apr 27 2018

Status: WontFix (was: Untriaged)
Done: https://chromium-review.googlesource.com/c/chromium/src/+/1028623/9

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948153587453711344%2F%2B%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout


FAILED: cc_blink.dll cc_blink.dll.lib cc_blink.dll.pdb 
C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./cc_blink.dll.lib /DLL /OUT:./cc_blink.dll /PDB:./cc_blink.dll.pdb @./cc_blink.dll.rsp
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ?SetTouchEventHandlerRegion@WebLayer@blink@@UAEXABVTouchActionRegion@cc@@@Z

Looks like you're right, it gives a similar error. Thanks!
►

Sign in to add a comment