NetworkService Investigate what is needed to support HttpAuthHandlerFactory |
|||||
Issue descriptionNeed to figure out whether we need to support HttpAuthHandlerFactory as a top level interface in network service, or we can pass in configuration options. gcm, headless and cast create HttpAuthHandlerFactory with custom options. We could expose ways for them to do that. Not sure if anything else is needed.
,
May 15 2018
,
May 18 2018
,
May 31 2018
Seems like there are two choices here, with two options each: Where to set the auth factory settings (On the global NetworkService, or on each NetworkContext). And how to pass them along (Separate pipe, like SSL and Proxy settings, or setter on the object itself, like user agent settings). Any of these approaches is viable, but mojo pipes aren't free, and this requires continuous updating based on browser-wide state, so I think making it a setter on the NetworkService is simplest. If we need to move it over to a per-NetworkContext setting later, shouldn't be a big deal (Though have to make sure we hook it up on the SafeBrowsing NetworkContext, too).
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dfb375cee68bfa1b588b98b16cfb14dacce31a2 commit 4dfb375cee68bfa1b588b98b16cfb14dacce31a2 Author: Matt Menke <mmenke@chromium.org> Date: Wed Jun 13 18:06:31 2018 Hook up HttpAuthHandlerFactory configuration to the network service. Bug: 837354 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic9727b6d9ef96c3f23c3fbbff4cd905e592010a6 Reviewed-on: https://chromium-review.googlesource.com/1089661 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#566913} [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/chrome/browser/io_thread.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/chrome/browser/io_thread.h [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/chrome/browser/io_thread_browsertest.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/chrome/browser/net/profile_network_context_service.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/chrome/browser/net/system_network_context_manager.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/chrome/browser/net/system_network_context_manager.h [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/chrome/browser/ui/login/login_handler_browsertest.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/network_context.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/network_context.h [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/network_context_unittest.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/network_service.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/network_service.h [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/network_service_unittest.cc [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/public/mojom/network_context.mojom [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/public/mojom/network_service.mojom [modify] https://crrev.com/4dfb375cee68bfa1b588b98b16cfb14dacce31a2/services/network/url_request_context_builder_mojo.cc
,
Jun 13 2018
,
Jun 18 2018
Issue 757973 has been merged into this issue.
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73a1d0687ed89d009058fab6b33e798138609de8 commit 73a1d0687ed89d009058fab6b33e798138609de8 Author: Matt Menke <mmenke@chromium.org> Date: Wed Jun 20 15:19:35 2018 Remove an unneeded line to configure auth. Accidentally left in a line of the old setup in https://chromium-review.googlesource.com/1089661. It's harmless, but not needed any more. Bug: 837354 Change-Id: Ic7a01e407d8666b2eede34d65a7186f212d1fddb Reviewed-on: https://chromium-review.googlesource.com/1106008 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568847} [modify] https://crrev.com/73a1d0687ed89d009058fab6b33e798138609de8/chrome/browser/profiles/profile_io_data.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xunji...@chromium.org
, May 9 2018