New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 837349 link

Starred by 1 user
Status: Fixed
Owner:
█ loonyb...@chromium.org
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 837344
Blocking:
issue 837346



Sign in to add a comment

Implementing optimized image policy "max-downsampling-image" behind a flag.

Project Member Reported by loonyb...@chromium.org, Apr 26 2018 
As part of an effort to implement feature policies to improve performance issues with images ( Issue 837346 ), we would like to experiment with "max-downsampling-image" policy.
 
This policy deals with problem of serving images that are much bigger than its container size.

When an image violates this policy, it will be rendered with inverted color, when "max-downsampling-image" is disabled by feature policy.

Comment 1 by loonyb...@chromium.org, Apr 26 2018

Blockedon: 837344
Blocking: 837346

Comment 2 by loonyb...@chromium.org, Apr 27 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea58ca981eb277acc555a68e78a68fdb6b8e274a

commit ea58ca981eb277acc555a68e78a68fdb6b8e274a
Author: Luna Lu <loonybear@chromium.org>
Date: Wed May 16 16:57:45 2018

Implementing "max-downscaling-image" policy behind a flag

As part of an effort to implement feature policies to improve performance
issues with images, "max-downscaling-image" policy restricts images
whose sizes are more than X times bigger than its containing block.

Images will be rendered with inverted color when violating this policy.

Bug:  837349 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I66d6e61b190d68750a458e2aa21a66683fd9d06a
Reviewed-on: https://chromium-review.googlesource.com/1033449
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559145}
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-resize-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-resize-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-resize.html
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-styles-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-styles-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-styles.html
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image.html
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/resources/frame-with-max-downscaling-image-test-images-resize.html
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/resources/frame-with-max-downscaling-image-test-images-styles.html
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/images/resources/frame-with-max-downscaling-image-test-images.html
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac-mac10.12/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-resize-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-styles-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-resize-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-resize-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-styles-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-styles-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-resize-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-resize-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles-expected.txt
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-resize-expected.png
[add] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles-expected.png
[modify] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/blink/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/blink/public/mojom/feature_policy/feature_policy.mojom
[modify] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/blink/renderer/core/layout/layout_image.h
[modify] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/ea58ca981eb277acc555a68e78a68fdb6b8e274a/third_party/blink/renderer/platform/feature_policy/feature_policy.cc

Comment 4 by loonyb...@chromium.org, May 16 2018

Labels: -Type-Bug Type-Feature
Status: Fixed (was: Started)
►

Sign in to add a comment