New issue
Advanced search Search tips

Issue 837341 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 735701



Sign in to add a comment

*TaskSchedulerWorkerPoolTest.PostDelayedTask* is flaky on OS_FUCHSIA

Project Member Reported by gab@chromium.org, Apr 26 2018

Issue description

*TaskSchedulerWorkerPoolImplTest.PostDelayedTask* had to be disabled on Fuchsia for flakes.

This is because Fuchsia+QEMU do not have a 250ms SLA on delayed tasks. While the TaskScheduler team tweaked most of its tests to no longer rely on timings, we will not be updating this specific test on other platforms as a 250ms SLA on delays is already beyond a reasonable SLA.
 

Comment 1 by gab@chromium.org, Apr 26 2018

Summary: *TaskSchedulerWorkerPoolTest.PostDelayedTask* is flaky on OS_FUCHSIA (was: *TaskSchedulerWorkerPoolImplTest.PostDelayedTask* is flaky on OS_FUCHSIA)

Comment 2 by gab@chromium.org, Apr 26 2018

Cc: -gab@chromium.org w...@chromium.org
Owner: gab@chromium.org
Status: Started (was: Assigned)
WIP https://chromium-review.googlesource.com/c/chromium/src/+/1030904
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b95f5af712447e145f90b2e40c06685a9eb6fdc0

commit b95f5af712447e145f90b2e40c06685a9eb6fdc0
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Apr 27 18:50:24 2018

[Fuchsia+TaskScheduler] Reenable TaskSchedulerWorkerPoolTest.PostDelayedTask on Fuchsia

Wait until the physical threads are up and ready to service the task runners
before starting the clock to avoid depending on the time it takes to bring
up a physical thread (can be slow in simulation environments like Fuchsia+QEMU).

R=fdoray@chromium.org, wez@chromium.org

Bug:  837341 
Change-Id: I7acbec7808c1aa4ad7fefdff6f80693fbfb8e74e
Reviewed-on: https://chromium-review.googlesource.com/1030904
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554431}
[modify] https://crrev.com/b95f5af712447e145f90b2e40c06685a9eb6fdc0/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
[modify] https://crrev.com/b95f5af712447e145f90b2e40c06685a9eb6fdc0/base/task_scheduler/scheduler_worker_pool_unittest.cc
[modify] https://crrev.com/b95f5af712447e145f90b2e40c06685a9eb6fdc0/testing/buildbot/filters/fuchsia.base_unittests.filter

Comment 4 by gab@chromium.org, Apr 27 2018

Status: Fixed (was: Started)

Sign in to add a comment