Issue metadata
Sign in to add a comment
|
Omnibox cursor should be movable to anywhere in the field (for overflowing strings) |
||||||||||||||||||||||||||
Issue descriptionAs of now, the omnibox text field supports cursor placement, but not selection. This means that if there's a long string typed into the field, there isn't a direct way to move the cursor to an off-screen location. This could be alleviated by (partially) supporting selection, in that a click and drag on text could scroll the field. I started prototyping this, and found that in the button-down case, our hit test code no longer reports reticle locations outside the element bounds. Therefore, we can't support dragging the reticle off the ends of the field to increase the selection. We'll have to return to older behavior where we'd report off-element coordinates, and rely on elements to filter properly in this case.
,
Jul 16
,
Jul 17
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e commit 8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e Author: Aldo Culquicondor <acondor@chromium.org> Date: Wed Jul 18 17:22:29 2018 VR: support text selection on omnibox Bug: 837334 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie5724d2c97e663afb5b2dc0ee9ad994a81db2052 Reviewed-on: https://chromium-review.googlesource.com/1138645 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#576107} [modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/elements/text.cc [modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/elements/text_input.cc [modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/elements/text_input.h [modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/elements/text_input_unittest.cc [modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/model/text_input_info.cc [modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/model/text_input_info.h
,
Jul 18
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by mthiesse@chromium.org
, May 30 2018