New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837334 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
Proj-XR
Proj-XR-VR



Sign in to add a comment

Omnibox cursor should be movable to anywhere in the field (for overflowing strings)

Project Member Reported by cjgrant@chromium.org, Apr 26 2018

Issue description

As of now, the omnibox text field supports cursor placement, but not selection.  This means that if there's a long string typed into the field, there isn't a direct way to move the cursor to an off-screen location.

This could be alleviated by (partially) supporting selection, in that a click and drag on text could scroll the field.

I started prototyping this, and found that in the button-down case, our hit test code no longer reports reticle locations outside the element bounds.  Therefore, we can't support dragging the reticle off the ends of the field to increase the selection.  We'll have to return to older behavior where we'd report off-element coordinates, and rely on elements to filter properly in this case.
 
Labels: -M-68 M-69
Owner: acondor@chromium.org
Status: Started (was: Available)
Cc: dougman@chromium.org dbbrooks@chromium.org
Labels: Test-Manual
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e

commit 8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Wed Jul 18 17:22:29 2018

VR: support text selection on omnibox

Bug:  837334 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie5724d2c97e663afb5b2dc0ee9ad994a81db2052
Reviewed-on: https://chromium-review.googlesource.com/1138645
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576107}
[modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/elements/text_input.h
[modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/elements/text_input_unittest.cc
[modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/model/text_input_info.cc
[modify] https://crrev.com/8ed544d23aeb1488e92434a6e9bfacbb2b49ef9e/chrome/browser/vr/model/text_input_info.h

Status: Fixed (was: Started)

Sign in to add a comment