Issue metadata
Sign in to add a comment
|
Do an audit of net::URLRequestContext consumers |
||||||||||||||||||||||||||||||||||||||||||
Issue descriptionFiling a bug to do an audit of net::URLRequestContext consumers, so we know what interfaces we need to add support for in Network Service. Some of the interfaces it exposes are: HostResolver* host_resolver_; CertVerifier* cert_verifier_; ChannelIDService* channel_id_service_; HttpAuthHandlerFactory* http_auth_handler_factory_; ProxyResolutionService* proxy_resolution_service_; scoped_refptr<SSLConfigService> ssl_config_service_; NetworkDelegate* network_delegate_; HttpServerProperties* http_server_properties_; const HttpUserAgentSettings* http_user_agent_settings_; TransportSecurityState* transport_security_state_; CTVerifier* cert_transparency_verifier_; CTPolicyEnforcer* ct_policy_enforcer_; HttpTransactionFactory* http_transaction_factory_; const URLRequestJobFactory* job_factory_; URLRequestThrottlerManager* throttler_manager_; NetworkQualityEstimator* network_quality_estimator_; ReportingService* reporting_service_; NetworkErrorLoggingService* network_error_logging_service_;
,
Apr 26 2018
I might as well take this to do the initial investigation and consolidate this with what's already being tracked.
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/286e71bea972c6cf4fb94b02f8fd3caec69be093 commit 286e71bea972c6cf4fb94b02f8fd3caec69be093 Author: Helen Li <xunjieli@chromium.org> Date: Fri Apr 27 01:23:44 2018 Use NET_EXPORT_PRIVATE for URLRequestThrottleManager The only consumer of this interface is cloud print, and they don't directly access this class. This CL hides this class, so we don't need to worry about it when adding interfaces for Network Service. Bug: 837333 Change-Id: I6566030b488f39b3595a582faf7f2d52c95c7359 Reviewed-on: https://chromium-review.googlesource.com/1030930 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#554253} [modify] https://crrev.com/286e71bea972c6cf4fb94b02f8fd3caec69be093/net/url_request/url_request_throttler_manager.h
,
Apr 27 2018
,
May 2 2018
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63ce1d9cfb6b6768a0cf4bfdd55341ee760089e5 commit 63ce1d9cfb6b6768a0cf4bfdd55341ee760089e5 Author: Helen Li <xunjieli@chromium.org> Date: Wed May 02 14:04:11 2018 Move loading_test_util.cc off the deprecated URLRequestContext::CreateRequest() CreateRequest() needs to take in a traffic annotation. Bug: 837333 Change-Id: Iaa4b8e0cbff89a4ffff4afef9c9cc6accdaba26f Reviewed-on: https://chromium-review.googlesource.com/1039124 Reviewed-by: Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555377} [modify] https://crrev.com/63ce1d9cfb6b6768a0cf4bfdd55341ee760089e5/chrome/browser/predictors/loading_test_util.cc
,
May 2 2018
,
May 2 2018
,
May 2 2018
,
May 2 2018
,
May 2 2018
,
May 2 2018
,
May 2 2018
,
May 2 2018
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac6c113cdd32774b90715a1232aca57895df04e5 commit ac6c113cdd32774b90715a1232aca57895df04e5 Author: Helen Li <xunjieli@chromium.org> Date: Thu May 03 13:27:40 2018 Remove unused member from CacheCounter Bug: 837333 Change-Id: Idf0f6723d4bc0c771bd6a415bff2269fdef40e06 Reviewed-on: https://chromium-review.googlesource.com/1040206 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555703} [modify] https://crrev.com/ac6c113cdd32774b90715a1232aca57895df04e5/chrome/browser/browsing_data/counters/cache_counter.h
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8897b025be9f2a27051b1bcf0dca3b7e3a240252 commit 8897b025be9f2a27051b1bcf0dca3b7e3a240252 Author: Helen Li <xunjieli@chromium.org> Date: Thu May 03 13:29:03 2018 Remove unused URLRequestContextGetter from NaclHostMessageFilter The field is unused. Bug: 837333 Change-Id: I1179efd6af649d52d43f041fc7409125a7df7b1d Reviewed-on: https://chromium-review.googlesource.com/1040207 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555704} [modify] https://crrev.com/8897b025be9f2a27051b1bcf0dca3b7e3a240252/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/8897b025be9f2a27051b1bcf0dca3b7e3a240252/components/nacl/browser/nacl_host_message_filter.cc [modify] https://crrev.com/8897b025be9f2a27051b1bcf0dca3b7e3a240252/components/nacl/browser/nacl_host_message_filter.h [modify] https://crrev.com/8897b025be9f2a27051b1bcf0dca3b7e3a240252/extensions/shell/browser/shell_content_browser_client.cc
,
May 3 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
,
May 7 2018
// This will be handled as part of the effort to servicify DNS-related interfaces. E.g. Issue 821021 HostResolver* host_resolver_; // sleevi@ is looking to this as a part of the effort to unify cert verifier and policy options related to the ssl stack. CertVerifier* cert_verifier_; TransportSecurityState* transport_security_state_; CTVerifier* cert_transparency_verifier_; CTPolicyEnforcer* ct_policy_enforcer_; // Tracked in Issue 840412 ChannelIDService* channel_id_service_; // Tracked in Issue 837354 HttpAuthHandlerFactory* http_auth_handler_factory_; // I think this is mostly done or being worked on. Need to confirm what else is needed for services/proxy_resolver/. ProxyResolutionService* proxy_resolution_service_; // mmenke@ is on this in Issue 755309 scoped_refptr<SSLConfigService> ssl_config_service_; // Partially tracked in Issue 840359 . morlovich@ did a first pass on ChromeNetworkDelegate. NetworkDelegate* network_delegate_; // Doesn't seem to be used outside of //net HttpServerProperties* http_server_properties_; // Configuration settings. There are a few consumers. Supporting these should be fairly straightforward. const HttpUserAgentSettings* http_user_agent_settings_; // Seems to be only used as an intermediate class for accessing other members and for configuration HttpTransactionFactory* http_transaction_factory_; // Replaced by URLLoader path. const URLRequestJobFactory* job_factory_; // Not exposed outside of //net URLRequestThrottlerManager* throttler_manager_; // Tracked in Issue 819244 NetworkQualityEstimator* network_quality_estimator_; // Outside usages are only for BrowserDataRemover and are being converted by ericorth@. ReportingService* reporting_service_; NetworkErrorLoggingService* network_error_logging_service_;
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17964a402c5428a73dd24492dbec32edffb0b16d commit 17964a402c5428a73dd24492dbec32edffb0b16d Author: Helen Li <xunjieli@chromium.org> Date: Tue May 08 18:56:44 2018 Remove a few unused http_server_properties.h includes Bug: 837333 Change-Id: I7d8899093a74d1d6c0d3656ca1ddef8fbe547ea4 Reviewed-on: https://chromium-review.googlesource.com/1050469 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556903} [modify] https://crrev.com/17964a402c5428a73dd24492dbec32edffb0b16d/chrome/browser/profiles/off_the_record_profile_impl.cc [modify] https://crrev.com/17964a402c5428a73dd24492dbec32edffb0b16d/chrome/browser/profiles/profile_impl_io_data.cc [modify] https://crrev.com/17964a402c5428a73dd24492dbec32edffb0b16d/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
,
May 9 2018
,
May 9 2018
,
May 9 2018
Good exercise, but largely uneventful. Matt's list is already pretty comprehensive. https://groups.google.com/a/chromium.org/d/msg/network-service-dev/Sj5bU_3u8FI/M1IaMsktBAAJ
,
May 9 2018
Thanks for taking the initiative to do this, Helen! That surprises me - had been expecting there'd be more. |
|||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||||
Comment 1 by xunji...@chromium.org
, Apr 26 2018