VR loading indicator should be on the content quad |
||||
Issue descriptionUX spec for the page loading indicator has a bar along the bottom edge of the content quad. Currently, the UI has a separate, smaller loading indicator placed between the URL bar and content. We're still using the old approach because we don't have a good way to size child elements according to their parent. Our layout logic currently works from children back to parents, with emphasis on "size yourself according to your children". The new loading indicator is the opposite. We can either augment the layout system, or, use a binding to copy the size of the content quad into the size of the loading indicator. The former adds complexity to layout; the latter is a violation of binding best-practice (element state should be bound to the model, not to other element state).
,
Apr 27 2018
,
Apr 27 2018
(also, we should fix the case where gradient quads with rounded corners don't draw properly if their width or height are less than twice the radius.
,
Apr 27 2018
Yep, that's captured in 768922
,
May 11 2018
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/628d7b3174d205db77c6efcdb0c63003932e9100 commit 628d7b3174d205db77c6efcdb0c63003932e9100 Author: Christopher Grant <cjgrant@chromium.org> Date: Fri May 18 14:54:18 2018 VR: Move the loading progress bar into content BUG= 837331 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I3fd41598ec541a9ccd2fd72d53cc99b6cebb5718 Reviewed-on: https://chromium-review.googlesource.com/1055906 Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#559891} [modify] https://crrev.com/628d7b3174d205db77c6efcdb0c63003932e9100/chrome/browser/vr/elements/content_element.cc [modify] https://crrev.com/628d7b3174d205db77c6efcdb0c63003932e9100/chrome/browser/vr/elements/content_element.h [modify] https://crrev.com/628d7b3174d205db77c6efcdb0c63003932e9100/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/628d7b3174d205db77c6efcdb0c63003932e9100/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/628d7b3174d205db77c6efcdb0c63003932e9100/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/628d7b3174d205db77c6efcdb0c63003932e9100/chrome/browser/vr/ui_unittest.cc
,
May 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cjgrant@chromium.org
, Apr 27 2018