New issue
Advanced search Search tips

Issue 837323 link

Starred by 6 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: 2018-10-01
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocked on:
issue 862411



Sign in to add a comment

DevTool integration in Web Audio API

Project Member Reported by hongchan@chromium.org, Apr 26 2018

Issue description

Tracking bug for the devtool integration in Web Audio API.
 
Labels: -Type-Bug OS-Chrome OS-Linux OS-Mac OS-Windows Type-Feature
NextAction: 2018-04-30
The NextAction date has arrived: 2018-04-30
NextAction: 2018-05-14
Also consider to use Agent and Probe for the proper DevTool integration.
The NextAction date has arrived: 2018-05-14
Status: Started (was: Assigned)
Summary: DevTool integration in Web Audio API (was: Adding traces in WebAudio for better profiling)
I am making this as a tracking bug for all the devtool integeration tasks.
Description: Show this description
Blockedon: 862411
Components: Platform>DevTools
NextAction: 2018-10-01
Adding DevTools to the relevant component. The WebAudio team started the exploration and the design process.
Sounds good, tell us if you need help with anything!
I'll send the draft of design doc to your way when it's ready! Thanks for your help on this!
In the pedalboard application (https://wasabi.i3s.unice.fr/dynamicPedalboard/) we can easily load tons of plugins, each composed of many nodes. Plugins are WebAudio Plugins (see: https://github.com/micbuffa/WebAudioPlugins). In the WebAudio Plugin SDK we group subgraph nodes using the CompositeNode pattern, this is a way to group nodes.

Having a way to group nodes in a webaudio graph could both improve the modularity of the code (for example by having a CompositeAudioNode that enable subgraphs to behave like a standard node, connect, disconnect, addParam etc), but that could be also reflected in the debugger (grouping with colours, folding/unfolding subgraphs, etc).
The NextAction date has arrived: 2018-10-01
Components: -Platform>DevTools
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d58b7cc171e5bdc997e88e3789ec17843fb16c6b

commit d58b7cc171e5bdc997e88e3789ec17843fb16c6b
Author: Hongchan Choi <hongchan@chromium.org>
Date: Thu Dec 13 01:16:21 2018

Introduce AudioIOCallbackMetric for monitoring rendering performance

This change introduces AudioIOCallbackMetric struct to trace the
rendering performance of Platform's AudioDesitnation. Eventually this
will be connected to the WebAudio DevTool drawer.

The new change is specifically for "Render Capacity" in the design doc:
https://docs.google.com/document/d/1TRgzZwp6M7sWL06UO3GYktqrv9TUv4G0QK6Io6VYVzc/edit?pli=1#bookmark=id.iodlb1gx6qpr

Bug: 837323
Change-Id: I92edca6f0afb755c6514b548d6c45d69e9831340
Reviewed-on: https://chromium-review.googlesource.com/c/1372538
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616140}
[modify] https://crrev.com/d58b7cc171e5bdc997e88e3789ec17843fb16c6b/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
[modify] https://crrev.com/d58b7cc171e5bdc997e88e3789ec17843fb16c6b/third_party/blink/renderer/modules/webaudio/base_audio_context.h
[modify] https://crrev.com/d58b7cc171e5bdc997e88e3789ec17843fb16c6b/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
[modify] https://crrev.com/d58b7cc171e5bdc997e88e3789ec17843fb16c6b/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
[modify] https://crrev.com/d58b7cc171e5bdc997e88e3789ec17843fb16c6b/third_party/blink/renderer/platform/audio/audio_destination.cc
[modify] https://crrev.com/d58b7cc171e5bdc997e88e3789ec17843fb16c6b/third_party/blink/renderer/platform/audio/audio_destination.h
[modify] https://crrev.com/d58b7cc171e5bdc997e88e3789ec17843fb16c6b/third_party/blink/renderer/platform/audio/audio_io_callback.h

Sign in to add a comment