New issue
Advanced search Search tips

Issue 837318 link

Starred by 1 user
Status: Fixed
Owner:
shapiroc@chromium.org
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Cannot access brand code

Project Member Reported by sjg@chromium.org, Apr 26 2018 
With cros_config with device tree:

cros_config / brand-code

works. On grunt it does not seem to.

Comment 1 by shapiroc@chromium.org, Apr 26 2018 

tested on reef and it works fine

can you point me to a grunt device to look at

Comment 2 by sjg@chromium.org, Apr 26 2018 

Yes 100.107.108.214

thanks

Comment 3 by shapiroc@chromium.org, Apr 26 2018

Status: Assigned (was: Untriaged)
thanks ... fix in flight
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4489ea607216d00746e77299eb5bca9e9e2a398d

commit 4489ea607216d00746e77299eb5bca9e9e2a398d
Author: C Shapiro <shapiroc@chromium.org>
Date: Fri Apr 27 16:29:55 2018

chromeos-config: Fix logic bug with empty sku-id

Fixed a logic bug where the sku-id can be empty in the json, which means
don't care.  In this case, the logic was optimized for the unit test
case of -1.  Added test also to exercise this case.

BUG= chromium:837318 
TEST=FEATURES=test emerge-reef chromeos-config-tools

Change-Id: I1a136d4a602651b247ce91bffded3f91daae7d85
Reviewed-on: https://chromium-review.googlesource.com/1030905
Commit-Ready: C Shapiro <shapiroc@google.com>
Tested-by: C Shapiro <shapiroc@google.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/4489ea607216d00746e77299eb5bca9e9e2a398d/chromeos-config/libcros_config/cros_config_unittest.cc
[modify] https://crrev.com/4489ea607216d00746e77299eb5bca9e9e2a398d/chromeos-config/libcros_config/cros_config_json.cc

Comment 5 by shapiroc@chromium.org, May 1 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment