New issue
Advanced search Search tips

Issue 837316 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

cbuildbot uses wasteful URLs?

Project Member Reported by dgarr...@chromium.org, Apr 26 2018

Issue description

From http://b/78599178


> git fetch -f https://chromium-review.googlesource.com/chromiumos/platform/tast-tests

I realize this isn't what the bug is about, but why do you use -review in the URL? If you use chromium.googlesource.com as the hostname then it should be cheaper for us to serve.

 
Labels: -Pri-3 Pri-2
I'm filing this as a request from the GoB team to investigate how we select -review vs non-review URLs and to prefer the cheaper value if we can.

The cost per-request is low, but we make a LOT of similar requests.

Comment 2 by jrn@google.com, Apr 26 2018

To clarify a little:

- the way this affects us in production is really minor (basically, it only affects load balancing and monitoring). It might be P3 even given your request volume. If we start making changes that care more, we'd probably make such git requests either produce a 302 redirect (which is very cheap) or print a warning at that point.

- all git and gitiles requests can use chromium.googlesource.com. For historical reasons, chromium-review.googlesource.com also supports git requests (the subject of this bug) but there shouldn't be any need to use it for that.

  In other words:

chromium.googlesource.com:
  supports git requests
  supports gitiles requests: gitiles browsing and the gitiles REST API

chromium-review.googlesource.com
  also supports git requests, but this is a historical / discouraged feature
  supports gerrit requests: gerrit browsing and the gerrit REST API
Labels: -Pri-2 Pri-3
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Components: -Infra>Client>ChromeOS>Build Infra>Client>ChromeOS>CI

Sign in to add a comment