New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 837308: Remove arraysize in favor of base::size(array)

Reported by jdoerrie@chromium.org, Apr 26 2018 Project Member

Issue description

https://crrev.com/c/992236 introduced base::size(), modeled after C++17's std::size() [1]. base::size() contains a constexpr and noexcept overload for plain C arrays, rendering the arraysize() macro obsolete. Since base::size() is more widely applicable, it is the preferred solution and existing usages of arraysize() should be replaced by base:size(array).

[1] http://en.cppreference.com/w/cpp/iterator/size
 
Showing comments 5 - 104 of 104 Older

Comment 5 by dcheng@chromium.org, Apr 28 2018

jbroman: I believe that only works if A is a literal type

Comment 6 by jbroman@chromium.org, Apr 30 2018

Yeah, not advocating that as a solution, just elaborating on why #3 doesn't compile.

Comment 7 by hirosh...@chromium.org, Apr 30 2018

It seems base::size() is forbidden in Blink (due to presubmit errors), for example:
third_party/blink/renderer/core/script/layered_api.cc:30 uses disallowed identifier base::size

Perhaps we should also update https://codesearch.chromium.org/chromium/src/third_party/blink/tools/audit_non_blink_usage.py or so.

Comment 9 by hirosh...@chromium.org, Apr 30 2018

The current situation in Blink:

arraysize (in base/macros.h):
- Presubmit warning (by the CL in Comment #2)
- #include "base/macros.h" is allowed by:
  https://codesearch.chromium.org/chromium/src/third_party/blink/renderer/DEPS?l=9

base::size (in base/stl_util.h):
- Presubmit error: #include "base/std_util.h" is not allowed by DEPS rules.
- Presubmit error: identifier "base::size" is not allowed by a PRESUBMIT script (Comment #7).

Therefore we can't use arraysize or base::size without warnings/errors.

Comment 10 by bugdroid1@chromium.org, May 1 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b6a440aa9e99afbdfa1267331a278901d79d292

commit 1b6a440aa9e99afbdfa1267331a278901d79d292
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue May 01 20:25:11 2018

Allow base::size in Blink PRESUBMIT

Issue 837308 is going to replace arrraysize() with base::size(), but
previously base::size() was forbidden in Blink PRESUBMIT rules.

Bug: 837308
Change-Id: I1531ea7ec7f25df42fbe5e17f9c01089ebd1b679
Reviewed-on: https://chromium-review.googlesource.com/1036118
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555167}
[modify] https://crrev.com/1b6a440aa9e99afbdfa1267331a278901d79d292/third_party/blink/tools/audit_non_blink_usage.py

Comment 11 by bugdroid1@chromium.org, May 1 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29b2191d64f527e3e43193b5a43ee0777894ddf9

commit 29b2191d64f527e3e43193b5a43ee0777894ddf9
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue May 01 20:25:16 2018

Allow including base/stl_util.h from Blink

Issue 837308 is going to replace arrraysize() with base::size(), but
base/stl_util.h (where base::size() is declared) is forbidden in
blink/renderer/DEPS,
while base/macros.h (where arraysize is declared) is allowed there.

This CL also allows including base/stl_util.h from blink/renderer.

Bug: 837308
Change-Id: Ifaf499dddbc99cec80c81c81f5588a2f6e3990a7
Reviewed-on: https://chromium-review.googlesource.com/1036597
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555168}
[modify] https://crrev.com/29b2191d64f527e3e43193b5a43ee0777894ddf9/third_party/blink/renderer/DEPS

Comment 12 by hirosh...@chromium.org, May 1 2018

Now I have no ongoing CLs on this issue, so feel free to go ahead.

Comment 13 by bugdroid1@chromium.org, May 7 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf

commit b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Mon May 07 20:01:01 2018

Switch //net SocketDataProviders to base::span<>

Currently, the SocketDataProvider interfaces in //net their parameters
in the generalized form of (T* stuff, size_t stuff_len) pairs of
arguments. Rather than use this error-prone pattern, switch it over
to base::span<> and propagate it through to callers and their respective
functions.

This has the side-effect of substantially reducing the use of arraysize()
in //net, thus reducing the risk of tripping the PRESUBMIT warning as part
of https://crbug.com/837308

BUG=837308
TBR=dimich@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic4f950f149b11061e819b546f3a6d45fc0216f58
Reviewed-on: https://chromium-review.googlesource.com/1045798
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556538}
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/chrome/browser/net/chrome_network_delegate_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/certificate_transparency/mock_log_dns_traffic.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/content/browser/content_resource_type_provider_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_usage/core/data_use_aggregator_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_use_measurement/core/data_use_measurement_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/components/data_use_measurement/core/data_use_network_delegate_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/google_apis/gcm/base/socket_stream_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/google_apis/gcm/engine/connection_handler_impl_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/jingle/glue/fake_ssl_client_socket_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/dns/dns_transaction_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/ftp/ftp_network_transaction_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/http_network_layer_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/http_network_transaction_ssl_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/http_stream_factory_job_controller_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/http_stream_parser_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/quic/chromium/mock_quic_data.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/quic/chromium/quic_chromium_client_session_test.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/quic/chromium/quic_connectivity_probing_manager_test.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/quic/chromium/quic_http_stream_test.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/quic/chromium/quic_stream_factory_test.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/sequenced_socket_data_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/socket_bio_adapter_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/socket_test_util.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/socket_test_util.h
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/socks5_client_socket_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/socks_client_socket_pool_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/socks_client_socket_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/socket/transport_client_socket_pool_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/spdy/chromium/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/spdy/chromium/spdy_http_stream_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/spdy/chromium/spdy_proxy_client_socket_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/spdy/chromium/spdy_session_pool_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/spdy/chromium/spdy_session_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/spdy/chromium/spdy_stream_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/url_request/url_request_http_job_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/websockets/websocket_basic_stream_adapters_test.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/websockets/websocket_basic_stream_test.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/websockets/websocket_handshake_stream_create_helper_test.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/websockets/websocket_stream_test.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/net/websockets/websocket_test_util.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/services/network/proxy_resolving_client_socket_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/services/network/socket_data_pump_unittest.cc
[modify] https://crrev.com/b8d7ea002b1eb73ac809d2d63f60b60c9cd0cccf/services/network/tcp_socket_unittest.cc

Comment 14 by gan...@chromium.org, May 10 2018

Any way to have base::size work for the following?

static_assert(arraysize(cookies_) == arraysize(class_ids),
                "Arrays cookies_ and class_ids must be the same size.");

Comment 15 by dcheng@chromium.org, May 10 2018

The best way we could come up with is:

static_assert(base::size(decltype(cookies_){}) == base::size(class_ids), "...");

https://godbolt.org/g/kLCUFX

Would that work for you?

Comment 16 by bugdroid1@chromium.org, May 10 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4625214fae133516f909e6305c858feb02944f4a

commit 4625214fae133516f909e6305c858feb02944f4a
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Thu May 10 16:42:45 2018

Cleanup arraysize usage in //net/base

When/where appropriate, the following conversions are made:
- Range based for-loops when iterating
- constexpr base::StringPiece for string constants
- [std::]begin() / [std::]end() when copying
- base::size() as last resort

Bug: 837308
Change-Id: I640ced508edb0b12f44534e0173a9d9402e627b6
Reviewed-on: https://chromium-review.googlesource.com/1043687
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557554}
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/address_list_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/chunked_upload_data_stream_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/data_url.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/data_url_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/directory_listing_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/elements_upload_data_stream_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/escape.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/escape_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/file_stream_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/filename_util.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/filename_util_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/host_port_pair_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/ip_address.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/ip_address_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/ip_endpoint_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/mime_sniffer.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/mime_sniffer_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/mime_util.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/mime_util_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/network_change_notifier.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/network_interfaces_linux_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/network_interfaces_win.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/port_util_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/priority_queue_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/upload_bytes_element_reader_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/upload_file_element_reader_unittest.cc
[modify] https://crrev.com/4625214fae133516f909e6305c858feb02944f4a/net/base/url_util_unittest.cc

Comment 17 by bugdroid1@chromium.org, May 12 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c79c3546c7996d284ddf16b45845ab51b213d00

commit 9c79c3546c7996d284ddf16b45845ab51b213d00
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Sat May 12 01:38:09 2018

Switch CustomHistogram::ArrayToCustomRanges to base::span<>

While at it, also rename the method to ArrayToCustomEnumRanges and
close out an old TODO.

TBR=hubbe@chromium.org, kbr@chromium.org
BUG=837308

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I56464a852707550dd625a1da30186aaaa9fdef38
Reviewed-on: https://chromium-review.googlesource.com/1055947
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558089}
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/base/metrics/histogram.cc
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/base/metrics/histogram.h
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/base/metrics/histogram_macros.h
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/base/metrics/histogram_unittest.cc
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/components/download/internal/common/base_file_win.cc
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/components/download/internal/common/download_stats.cc
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/gpu/command_buffer/service/gl_utils.cc
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/media/remoting/metrics.cc
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/net/cert/cert_verify_proc.cc
[modify] https://crrev.com/9c79c3546c7996d284ddf16b45845ab51b213d00/net/dns/host_resolver_impl.cc

Comment 18 by bugdroid1@chromium.org, May 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0

commit 34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Tue May 15 01:46:46 2018

Switch //net/ntlm to use base::span<const uint8_t>

//net/ntlm makes extensive use of uint8_t* pointers with various
fixed size requirements. Convert these into defined-extent
base::span<>'s so that the compiler can do more work for us to
ensure that all the buffers are appropriately sized.

This also switches uses of std::basic_string<uint8_t> and
base::StringPiece into std::vector<uint8_t> / base::span<uint8_t>,
as these are all working on 'data' buffers.

Bug: 837308
Change-Id: Iae3f1933b2c948d77c841e6f9bc8ce04bfddc67d
Reviewed-on: https://chromium-review.googlesource.com/1056013
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558579}
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/BUILD.gn
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/http/http_auth_handler_ntlm.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/http/http_auth_handler_ntlm.h
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/http/http_auth_handler_ntlm_portable.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/http/http_auth_handler_ntlm_portable_unittest.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm.h
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_buffer_reader.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_buffer_reader.h
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_buffer_reader_unittest.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_buffer_writer.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_buffer_writer.h
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_buffer_writer_unittest.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_client.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_client.h
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_client_fuzzer.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_client_unittest.cc
[add] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_constants.cc
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_constants.h
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_test_data.h
[modify] https://crrev.com/34ac4b2fc6f2df2ae7f35f69e0921f01dcd299c0/net/ntlm/ntlm_unittest.cc

Comment 19 by bugdroid1@chromium.org, May 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/435a3a234cf75db27ba33c136c8b245071c2ef20

commit 435a3a234cf75db27ba33c136c8b245071c2ef20
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Tue May 15 02:16:07 2018

Cleanup arraysize usage in //net

When/where appropriate, the following conversions are made:
- Range-based for loops when iterating
- constexpr base::StringPiece for string constants
- base::span<> for array types
- base::size() as last resort

Bug: 837308
Change-Id: I7cb5ef94220049cfad935e9719657402461ff53d
Reviewed-on: https://chromium-review.googlesource.com/1056111
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558588}
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/android/dummy_spnego_authenticator.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/base/hash_value.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/base/hash_value.h
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/cert_verifier_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/cert_verify_proc.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/cert_verify_proc_nss.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/cert_verify_proc_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/cert_verify_proc_win.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/ct_log_verifier_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/ev_root_ca_metadata.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/known_roots_mac.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/symantec_certs.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/x509_certificate.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/x509_certificate_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert/x509_util_nss_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert_net/cert_net_fetcher_impl_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cert_net/nss_ocsp.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cookies/cookie_constants_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cookies/cookie_monster.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cookies/cookie_monster_perftest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cookies/cookie_util.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cookies/cookie_util_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cookies/parsed_cookie.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/cookies/parsed_cookie_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/der/input_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/der/parse_values_unittest.cc
[modify] https://crrev.com/435a3a234cf75db27ba33c136c8b245071c2ef20/net/http/transport_security_state.cc

Comment 20 by jdoerrie@chromium.org, May 16 2018

Summary: Remove arraysize in favor of base::size(array) (was: Remove arraysize in favor of base::size(array) )

Comment 21 by gan...@chromium.org, May 18 2018

Re Comment 15, thank you, that works!

Comment 22 by bugdroid1@chromium.org, May 28 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/874fdf36216266581b37afc176e501c91d788dd8

commit 874fdf36216266581b37afc176e501c91d788dd8
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Mon May 28 04:07:09 2018

bindings: Use base::size() instead of arraysize

This CL replaces arraysize() with base::size() in bindings code.
This CL clears a presubmit warning with run_bindings_test.py.


Bug: 837308
Change-Id: I32b02cc2ddd6b32ccac7c6bbdb37573e467d5d6c
Reviewed-on: https://chromium-review.googlesource.com/1071307
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562180}
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/script_regexp.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_deserializer.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/v8_error_handler.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/v8_event_listener.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/v8_gc_controller.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/v8_lazy_event_listener.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/v8_v0_custom_element_lifecycle_callbacks.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/core/v8/v8_worker_or_worklet_event_listener.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/templates/callback_function.cpp.tmpl
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/templates/constants.cpp.tmpl
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/templates/dictionary_v8.cpp.tmpl
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/templates/union_container.cpp.tmpl
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_attributes.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_garbage_collected.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
[modify] https://crrev.com/874fdf36216266581b37afc176e501c91d788dd8/third_party/blink/renderer/platform/bindings/v8_dom_wrapper.h

Comment 23 by bugdroid1@chromium.org, May 31 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d038eaea94c4d94b65a6d9c8e60bc309dbd98b

commit 41d038eaea94c4d94b65a6d9c8e60bc309dbd98b
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Thu May 31 16:01:48 2018

viz: Use base::size instead of arraysize

arraysize is deprecated and base::size should be used instead.
This CL changes arraysize to base::size in SurfaceAggragator
unittests

Bug: 837308
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I747970ac6bbecfe4bb9634b6ed37d3cbcb09f6b4
Reviewed-on: https://chromium-review.googlesource.com/1080248
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563256}
[modify] https://crrev.com/41d038eaea94c4d94b65a6d9c8e60bc309dbd98b/components/viz/service/display/surface_aggregator_unittest.cc

Comment 24 by bugdroid1@chromium.org, Jun 1 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e5402a8830ed3e924a25f73bddd224ce6df716a

commit 1e5402a8830ed3e924a25f73bddd224ce6df716a
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Jun 01 02:27:44 2018

Replace arraysize with base::size in native_stack_sampler_win.cc

... as the former is deprecated.

Bug: 837308
Change-Id: Iace3a07b4ba4d6c0e0e441ab07add5a3d701ba26
Reviewed-on: https://chromium-review.googlesource.com/1081513
Commit-Queue: Xi Cheng <chengx@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563496}
[modify] https://crrev.com/1e5402a8830ed3e924a25f73bddd224ce6df716a/base/profiler/native_stack_sampler_win.cc
[modify] https://crrev.com/1e5402a8830ed3e924a25f73bddd224ce6df716a/base/profiler/stack_sampling_profiler_unittest.cc

Comment 25 by bugdroid1@chromium.org, Aug 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47cbea6beb4d39baa2651a7a151bc8a42dcdce36

commit 47cbea6beb4d39baa2651a7a151bc8a42dcdce36
Author: Miguel Casas <mcasas@chromium.org>
Date: Sat Aug 25 15:23:13 2018

vaapi_jpeg_decoder{_unittest}: address some presubmit warnings

- s/arraysize/base::size/ (see crbug.com/837308#c15 for decltype trick).
- s/base::bind/base::BindRepeating/ (and s/Closure/RepeatingClosure/).

Bug: 876810, 837308
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0068d55985c5c4fdcf1ed987e278f402fd0e6ac0
Reviewed-on: https://chromium-review.googlesource.com/1189103
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586137}
[modify] https://crrev.com/47cbea6beb4d39baa2651a7a151bc8a42dcdce36/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc
[modify] https://crrev.com/47cbea6beb4d39baa2651a7a151bc8a42dcdce36/media/gpu/vaapi/vaapi_jpeg_decode_accelerator_unittest.cc

Comment 26 by bugdroid1@chromium.org, Sep 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bb5022afcdaf1d289f47977debe92137dfd5cd7

commit 1bb5022afcdaf1d289f47977debe92137dfd5cd7
Author: Byoungkown <codeimpl@gmail.com>
Date: Tue Sep 11 01:14:41 2018

[variations] Use base::size() instead of arraysize

arraysize is deprecated, we should use base::size() instead.
This cl clears a presubmit warnings.

Bug: 837308
Change-Id: I5479c0f16e6df0b43b617c0e15c6c28527c41cbd
Reviewed-on: https://chromium-review.googlesource.com/1213622
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#590160}
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/caching_permuted_entropy_provider_unittest.cc
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/entropy_provider_unittest.cc
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/experiment_labels_unittest.cc
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/hashing_unittest.cc
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/net/variations_http_headers.cc
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/net/variations_http_headers_unittest.cc
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/service/variations_service_unittest.cc
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/study_filtering_unittest.cc
[modify] https://crrev.com/1bb5022afcdaf1d289f47977debe92137dfd5cd7/components/variations/variations_seed_processor_unittest.cc

Comment 27 by bugdroid1@chromium.org, Sep 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccd837dc5575df35765117fa673265305144df7a

commit ccd837dc5575df35765117fa673265305144df7a
Author: Joshua Bell <jsbell@chromium.org>
Date: Wed Sep 26 16:11:47 2018

storage/browser/quota: arraysize -> base::size

Bug: 837308
Change-Id: Ib5a7e51781c46f1e06336c12ab9f4fa0f443f390
Reviewed-on: https://chromium-review.googlesource.com/1244597
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594332}
[modify] https://crrev.com/ccd837dc5575df35765117fa673265305144df7a/storage/browser/quota/quota_database.cc
[modify] https://crrev.com/ccd837dc5575df35765117fa673265305144df7a/storage/browser/quota/quota_database_unittest.cc
[modify] https://crrev.com/ccd837dc5575df35765117fa673265305144df7a/storage/browser/quota/quota_manager_unittest.cc

Comment 28 by bugdroid1@chromium.org, Oct 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/189a402eba45945c7b1f521ea0cd7a4753ea19bf

commit 189a402eba45945c7b1f521ea0cd7a4753ea19bf
Author: kokihoon <rhrlgns777@gmail.com>
Date: Sat Oct 13 02:43:44 2018

[ios] Use base::size() instead of arraysize

arraysize is deprecated, we should use base::size() instead.
This CL changes arraysize to base::size in ios

Bug: 837308
Change-Id: Ic24c06e57f254976ee791f7094313cdbd0125ed7
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/c/1257469
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599474}
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/app_startup_parameters_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/autofill/autofill_controller_js_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/browser_about_rewriter.cc
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/chrome_url_constants.cc
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/chrome_url_util_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/crash_report/crash_restore_helper_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/metrics/first_user_action_recorder.cc
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/omaha/omaha_service_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/snapshots/snapshot_cache.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/snapshots/snapshots_util.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/sync/sync_setup_service.cc
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/tabs/tab_model.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/browser/ui/ui_util_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/chrome/common/x_callback_url_unittest.cc
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/net/url_scheme_util_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/third_party/blink/src/html_tokenizer_adapter.h
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/web/history_state_util_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/web/navigation/nscoder_util_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/web/net/web_http_protocol_handler_delegate_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/web/public/referrer_util_unittest.cc
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/web/public/user_agent.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/web/web_state/js/common_js_unittest.mm
[modify] https://crrev.com/189a402eba45945c7b1f521ea0cd7a4753ea19bf/ios/web/webui/url_data_manager_ios_backend.mm

Comment 29 by bugdroid1@chromium.org, Oct 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8bb8226019b079308a698393440f3674ab33ad2

commit e8bb8226019b079308a698393440f3674ab33ad2
Author: Nate Fischer <ntfschr@chromium.org>
Date: Fri Oct 19 21:32:01 2018

AW: use base::size() instead of arraysize

This swaps the deprecated 'arraysize' macro for base::size(), in the
//android_webview/ folder. No change to logic.

R=boliu@chromium.org

Bug: 837308
Test: N/A
Change-Id: Ia6960f242f78f117eeb831e451f27596583b0cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1292514
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601304}
[modify] https://crrev.com/e8bb8226019b079308a698393440f3674ab33ad2/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/e8bb8226019b079308a698393440f3674ab33ad2/android_webview/browser/browser_view_renderer_unittest.cc
[modify] https://crrev.com/e8bb8226019b079308a698393440f3674ab33ad2/android_webview/browser/command_line_helper_unittest.cc

Comment 30 by bugdroid1@chromium.org, Nov 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f

commit 76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f
Author: Eric Karl <ericrk@chromium.org>
Date: Fri Nov 02 18:25:36 2018

GPU Command Buffer Generator: Use base::size instead of arraysize

This swaps the deprecated 'arraysize' macro for base::size in the GPU
command buffer generator scripts and generated files. No change to
logic.

Bug: 837308
Change-Id: I229a7f9ad9a25f0a7e40690aae5ff167a75aa804
Reviewed-on: https://chromium-review.googlesource.com/c/1313835
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604989}
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/build_cmd_buffer_lib.py
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/client/raster_implementation_unittest_autogen.h
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/common/gles2_cmd_utils.cc
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/common/raster_cmd_format_test_autogen.h
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/service/raster_cmd_validation.cc
[modify] https://crrev.com/76201a8efa5ad6b9c6c0b7b4d1da96738a58a30f/gpu/command_buffer/service/raster_cmd_validation_implementation_autogen.h

Comment 31 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4422dd1930e3d7fd32d05768104197eb0d1fd32

commit a4422dd1930e3d7fd32d05768104197eb0d1fd32
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Thu Dec 13 08:30:34 2018

Use base::size() instead of arraysize

This swaps the deprecated 'arraysize' macro for base::size(), in the
//content/browser/dom_storage/ folder. No change to logic.

Bug: 837308
Change-Id: I97a5bc00da50a61dc0f41abe916fc97591b0869a
Reviewed-on: https://chromium-review.googlesource.com/c/1375176
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616245}
[modify] https://crrev.com/a4422dd1930e3d7fd32d05768104197eb0d1fd32/content/browser/dom_storage/dom_storage_area_unittest.cc
[modify] https://crrev.com/a4422dd1930e3d7fd32d05768104197eb0d1fd32/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/a4422dd1930e3d7fd32d05768104197eb0d1fd32/content/browser/dom_storage/session_storage_metadata.cc

Comment 32 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711d61d923e87eb504aa538ec0e677dc60fa257b

commit 711d61d923e87eb504aa538ec0e677dc60fa257b
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Fri Dec 14 16:40:57 2018

Cleanup arraysize usage in //storage

This CL cleanup arraysize usage in //storage with:
- Range based for-loops when iterating
- Replace with base::size()

Bug: 837308
Change-Id: Id4c9eedf4371b819e61d735b6cdbb68eeeb7594c
Reviewed-on: https://chromium-review.googlesource.com/c/1377474
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616708}
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/dragged_file_util_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/external_mount_points_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_system_context.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_system_context_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_system_file_stream_reader_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_system_operation_impl_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_system_quota_client_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_system_url_request_job.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_system_url_request_job_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_system_url_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/file_writer_delegate_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/isolated_context_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/local_file_stream_reader_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/obfuscated_file_util_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/sandbox_directory_database.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/sandbox_file_system_backend_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/fileapi/sandbox_origin_database_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/browser/test/fileapi_test_file_set.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/common/database/database_identifier.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/common/database/database_identifier_unittest.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/common/fileapi/file_system_util.cc
[modify] https://crrev.com/711d61d923e87eb504aa538ec0e677dc60fa257b/storage/common/fileapi/file_system_util_unittest.cc

Comment 33 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cac7031df4146e44b7a5b04d70148fd497b02b35

commit cac7031df4146e44b7a5b04d70148fd497b02b35
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Mon Dec 17 18:35:30 2018

Use base::size() instead of arraysize in content/browser/indexed_db/

This swaps the deprecated 'arraysize' macro for base::size(), in the
//content/browser/indexed_db/ folder. No change to logic.

Bug: 837308
Change-Id: Ib0683aa3e6990115254aa2c9c83c65baf6a2f07e
Reviewed-on: https://chromium-review.googlesource.com/c/1379087
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617168}
[modify] https://crrev.com/cac7031df4146e44b7a5b04d70148fd497b02b35/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/cac7031df4146e44b7a5b04d70148fd497b02b35/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc

Comment 34 by bugdroid1@chromium.org, Dec 24

Project Member

Comment 35 by bugdroid1@chromium.org, Dec 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cdf20f514093b5537d48050508674bb8213db6e

commit 0cdf20f514093b5537d48050508674bb8213db6e
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 24 21:42:20 2018

Use base::size rather than arraysize in testing/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=jbudorick@chromium.org

Change-Id: I65f8cb1557478dff4826ddab93764be0eeaf987d
Reviewed-on: https://chromium-review.googlesource.com/c/1390110
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618836}
[modify] https://crrev.com/0cdf20f514093b5537d48050508674bb8213db6e/testing/android/native_test/native_test_launcher.cc

Comment 36 by bugdroid1@chromium.org, Dec 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a63f06228bd5b317602139e6b50fe70a300bf86c

commit a63f06228bd5b317602139e6b50fe70a300bf86c
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 24 21:43:19 2018

Use base::size rather than arraysize in skia/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=fmalita@chromium.org

Change-Id: Idb79e622b4532baa1f1b81a07dccadac064357e0
Reviewed-on: https://chromium-review.googlesource.com/c/1390111
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618837}
[modify] https://crrev.com/a63f06228bd5b317602139e6b50fe70a300bf86c/skia/ext/convolver_unittest.cc
[modify] https://crrev.com/a63f06228bd5b317602139e6b50fe70a300bf86c/skia/ext/image_operations_bench.cc
[modify] https://crrev.com/a63f06228bd5b317602139e6b50fe70a300bf86c/skia/ext/image_operations_unittest.cc
[modify] https://crrev.com/a63f06228bd5b317602139e6b50fe70a300bf86c/skia/ext/skia_utils_ios.mm

Comment 38 by bugdroid1@chromium.org, Dec 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6

commit a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 24 22:33:50 2018

Use base::size rather than arraysize in rlz/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=rogerta@chromium.org

Change-Id: I9a1fe160e17c708c7fe14bdd1bf2a9fec2d51341
Reviewed-on: https://chromium-review.googlesource.com/c/1390114
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618840}
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/chromeos/lib/rlz_value_store_chromeos.cc
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/lib/financial_ping.cc
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/lib/financial_ping_test.cc
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/lib/rlz_lib.cc
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/lib/rlz_lib_test.cc
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/lib/string_utils_unittest.cc
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/win/lib/machine_deal.cc
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/win/lib/machine_id_win.cc
[modify] https://crrev.com/a42dff19e1097b9dc50b8f6eeefe8ef33515c8b6/rlz/win/lib/rlz_value_store_registry.cc

Comment 39 by bugdroid1@chromium.org, Dec 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef8bbedcad363d2ec5d9c681114a0ebadff5f4f7

commit ef8bbedcad363d2ec5d9c681114a0ebadff5f4f7
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 24 22:34:50 2018

Use base::size rather than arraysize in ppapi/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=raymes@chromium.org

Change-Id: I72d85808c431221bac3e8f392f4be78c1856c401
Reviewed-on: https://chromium-review.googlesource.com/c/1390418
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618841}
[modify] https://crrev.com/ef8bbedcad363d2ec5d9c681114a0ebadff5f4f7/ppapi/proxy/tcp_socket_resource_base.cc
[modify] https://crrev.com/ef8bbedcad363d2ec5d9c681114a0ebadff5f4f7/ppapi/shared_impl/flash_clipboard_format_registry.cc

Comment 40 by bugdroid1@chromium.org, Dec 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69

commit 88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 24 22:39:20 2018

Use base::size rather than arraysize in remoting/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=sergeyu@chromium.org

Change-Id: I26b8bcae9ec092131e8dfa41cb5225d28d8ebcf2
Reviewed-on: https://chromium-review.googlesource.com/c/1390416
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618843}
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/base/breakpad_win.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/base/capabilities_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/base/rate_counter_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/base/running_samples_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/base/weighted_samples_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/client/audio/audio_player_android.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/client/client_telemetry_logger.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/codec/codec_test.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/audio_silence_detector_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/audio_volume_filter_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/daemon_process_win.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/desktop_resizer_mac.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/desktop_session_win.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/disconnect_window_win.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/host_attributes.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/input_injector_win.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/linux/remoting_user_session.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/linux/unicode_to_keysym.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/linux/unicode_to_keysym_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/linux/x11_keyboard_impl.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/linux/x_server_clipboard.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/security_key/security_key_socket.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/setup/daemon_controller_delegate_win.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/setup/me2me_native_messaging_host.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/setup/me2me_native_messaging_host_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/host/win/rdp_client_window.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/protocol/audio_pump_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/protocol/capture_scheduler_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/protocol/jingle_messages_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/protocol/message_decoder_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/protocol/mouse_input_filter_unittest.cc
[modify] https://crrev.com/88f5d8c560d7dc8af69131f1df7e9a5a8d31ee69/remoting/protocol/pairing_registry.cc

Comment 41 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daf3af497a6265bc6db88539b528f92910fe03dd

commit daf3af497a6265bc6db88539b528f92910fe03dd
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 18:09:19 2018

Use base::size rather than arraysize in ui/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=thakis@chromium.org

Change-Id: I0905add39f418f48c0c70b76db8cbc1cc91eefb7
Reviewed-on: https://chromium-review.googlesource.com/c/1390107
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618865}
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/accessibility/ax_generated_tree_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/aura/mus/window_tree_client_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/accelerators/accelerator_manager_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/accelerators/menu_label_accelerator_util_linux_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/clipboard/clipboard_util_win.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/cocoa/constrained_window/constrained_window_animation.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/cursor/cursors_aura.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/cursor/image_cursors.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/dragdrop/os_exchange_data_provider_win.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/chromeos/character_composer_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/chromeos/component_extension_ime_manager.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/chromeos/ime_keyboard.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/chromeos/ime_keymap.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/chromeos/input_method_util.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/chromeos/input_method_util_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/chromeos/input_method_whitelist.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/composition_text_util_pango_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/win/tsf_bridge.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/ime/win/tsf_text_store_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/l10n/l10n_util.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/l10n/l10n_util_mac_unittest.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/l10n/l10n_util_posix.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/l10n/l10n_util_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/resource/resource_bundle_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/resource/scale_factor.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/template_expressions.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/test/ui_controls_mac.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/text/bytes_formatting.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/text/bytes_formatting_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/base/x/x11_util.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/chromeos/events/event_rewriter_chromeos.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/chromeos/ime/candidate_view_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/display/mac/screen_mac.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/display/manager/configure_displays_task_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/display/manager/display_change_observer.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/display/manager/display_configurator_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/display/util/display_util.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/display/util/edid_parser_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/blink/web_input_event_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/devices/x11/device_data_manager_x11.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/event_processor_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/event_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/keycodes/dom/keycode_converter.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/keycodes/dom/keycode_converter_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/keycodes/keyboard_code_conversion.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/keycodes/keyboard_code_conversion_mac.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/keycodes/keyboard_code_conversion_x.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/keycodes/keysym_to_unicode.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/keycodes/platform_key_map_win.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/device/udev/device_manager_udev.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/capture_device_capabilities.py
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/event_device_info.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/event_device_test_util.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/gamepad_event_converter_evdev_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/touch_filter/false_touch_finder_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/evdev/touch_filter/far_apart_taps_touch_noise_filter.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/gamepad/static_gamepad_mapping.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/platform/platform_event_source_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/test/events_test_utils_x11.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/x/events_x.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/events/x/events_x_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/break_list_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/buffer_format_util.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/codec/chromeos/jpeg_codec_robust_slow_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/codec/jpeg_codec_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/codec/png_codec_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/geometry/point3_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/geometry/point_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/geometry/quad_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/geometry/quaternion_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/geometry/scroll_offset_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/geometry/vector2d_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/geometry/vector3d_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/half_float_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/icon_util.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/image/image_ios_unittest.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/ios/uikit_util_unittest.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/paint_vector_icon_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/path_mac.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/path_mac_unittest.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/path_win_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/platform_font_mac_unittest.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/platform_font_win.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/render_text_mac.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/shadow_value_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/test/icc_profiles.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/text_elider_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/text_utils_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/transform_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gfx/x/x11_atom_cache.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gl/gl_api_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gl/gl_image_io_surface_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gl/gl_image_native_pixmap.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gl/gl_implementation.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/gl/gl_switches.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/keyboard/resources/keyboard_resource_util.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/latency/histograms.h
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/native_theme/native_theme_win.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/ozone/demo/skia/skia_surfaceless_gl_renderer.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/ozone/platform/drm/common/drm_util_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/ozone/platform/drm/gpu/drm_display.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/shell_dialogs/select_file_dialog_mac_unittest.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/shell_dialogs/select_file_dialog_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/animation/square_ink_drop_ripple_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/bubble/bubble_border_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/bubble/bubble_dialog_delegate_view_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/controls/textfield/textfield_model_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/controls/textfield/textfield_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/examples/bubble_example.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/examples/label_example.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/examples/radio_button_example.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/examples/text_example.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/focus/focus_traversal_unittest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/test/event_generator_delegate_mac.mm
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc
[modify] https://crrev.com/daf3af497a6265bc6db88539b528f92910fe03dd/ui/views/window/dialog_delegate_unittest.cc

Comment 42 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a08b35557882401187d5ffbe17afdb429aeca13e

commit a08b35557882401187d5ffbe17afdb429aeca13e
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 18:09:59 2018

Use base::size rather than arraysize in mash/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=msw@chromium.org

Change-Id: Ib0ee334f7083b3dce276eebfa1f5f95e202e2ad9
Reviewed-on: https://chromium-review.googlesource.com/c/1390723
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618866}
[modify] https://crrev.com/a08b35557882401187d5ffbe17afdb429aeca13e/mash/example/window_type_launcher/window_type_launcher.cc

Comment 43 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f757f8130664cbf25723c7bb87a82935ca41422c

commit f757f8130664cbf25723c7bb87a82935ca41422c
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 18:40:07 2018

Use base::size rather than arraysize in services/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=blundell@chromium.org

Change-Id: I4800f3c36f0588964f07768e223152d410acd3ee
Reviewed-on: https://chromium-review.googlesource.com/c/1390112
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618869}
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/data_decoder/image_decoder_impl_unittest.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/device/generic_sensor/platform_sensor_reader_linux.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/device/generic_sensor/platform_sensor_reader_win.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/device/geolocation/wifi_data_provider_linux_unittest.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/device/geolocation/wifi_data_provider_win.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/device/time_zone_monitor/time_zone_monitor_linux.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/network/cookie_manager_unittest.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/network/cross_origin_read_blocking.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/network/http_cache_data_remover_unittest.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/network/p2p/socket_tcp_unittest.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/network/public/cpp/server/http_server_unittest.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/network/throttling/throttling_controller_unittest.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/preferences/tracked/device_id_win.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/preferences/tracked/pref_hash_filter.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/preferences/tracked/pref_hash_filter_unittest.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/service_manager/embedder/main.cc
[modify] https://crrev.com/f757f8130664cbf25723c7bb87a82935ca41422c/services/service_manager/zygote/host/zygote_communication_linux.cc

Comment 44 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5069bb248dc36ed3df4e5ef2c55fdd31a54fa1e0

commit 5069bb248dc36ed3df4e5ef2c55fdd31a54fa1e0
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 19:31:07 2018

Use base::size rather than arraysize in gin/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=jbroman@chromium.org

Change-Id: I7e0e6f5f53c038848b9f340f012dd10628e46bb2
Reviewed-on: https://chromium-review.googlesource.com/c/1390728
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618870}
[modify] https://crrev.com/5069bb248dc36ed3df4e5ef2c55fdd31a54fa1e0/gin/converter_unittest.cc

Comment 45 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939bd1aa3cf6e2962cf4ea13bee2a9b3c736a491

commit 939bd1aa3cf6e2962cf4ea13bee2a9b3c736a491
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 19:47:42 2018

Use base::size rather than arraysize in dbus/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=stevenjb@chromium.org

Change-Id: I903ba192fd31c2ef64379e473c3285c230ad1d27
Reviewed-on: https://chromium-review.googlesource.com/c/1390731
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618872}
[modify] https://crrev.com/939bd1aa3cf6e2962cf4ea13bee2a9b3c736a491/dbus/end_to_end_async_unittest.cc
[modify] https://crrev.com/939bd1aa3cf6e2962cf4ea13bee2a9b3c736a491/dbus/property_unittest.cc
[modify] https://crrev.com/939bd1aa3cf6e2962cf4ea13bee2a9b3c736a491/dbus/values_util_unittest.cc

Comment 46 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc

commit fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 20:26:39 2018

Use base::size rather than arraysize in media/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=dalecurtis@chromium.org

Change-Id: I1651766839b1872ed0be25210e4196ce9cee8a0f
Reviewed-on: https://chromium-review.googlesource.com/c/1390721
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618874}
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/alsa/alsa_input.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/alsa/audio_manager_alsa.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/android/opensles_input.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/android/opensles_output.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/cras/audio_manager_cras.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/cras/cras_input.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/cras/cras_unified.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/sounds/audio_stream_handler_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/sounds/sounds_manager_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/sounds/test_data.h
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/sounds/wav_audio_handler_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/win/audio_low_latency_output_win.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/audio/win/avrt_wrapper_win.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/android/media_drm_bridge.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/audio_bus_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/audio_hash.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/audio_parameters_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/audio_renderer_mixer_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/audio_timestamp_helper_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/bit_reader_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/channel_layout.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/channel_mixer_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/channel_mixing_matrix_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/container_names.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/data_buffer_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/decoder_buffer_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/fake_demuxer_stream.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/key_systems.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/mime_util_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/seekable_buffer_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/test_data_util.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/unaligned_shared_memory_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/video_frame.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/base/video_frame_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/blink/cache_util.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/blink/cache_util_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/blink/multibuffer_data_source_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/content/capture_resolution_chooser_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/content/smooth_event_sampler_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/video/chromeos/camera_hal_dispatcher_impl.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/video/mac/video_capture_device_factory_mac.mm
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/video/video_capture_device.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/video/win/sink_input_pin_win.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/capture/video_capture_types.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cast/logging/serialize_deserialize_test.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cast/receiver/audio_decoder_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cast/sender/audio_encoder_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cast/sender/external_video_encoder.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cast/sender/h264_vt_encoder.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cdm/aes_decryptor_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cdm/cdm_adapter_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cdm/cenc_decryptor_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cdm/cenc_utils.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cdm/cenc_utils_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cdm/json_web_key_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/cdm/library_cdm/clear_key_cdm/cdm_file_io_test.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/device_monitors/system_message_window_win.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/ffmpeg/ffmpeg_common_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/audio_renderer_algorithm_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/audio_timestamp_validator_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/blocking_url_protocol.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/chunk_demuxer_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/decrypting_audio_decoder_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/decrypting_demuxer_stream_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/decrypting_video_decoder_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/ffmpeg_demuxer_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/jpeg_parser.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/stream_parser_factory.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/video_renderer_algorithm_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/vp9_bool_decoder.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/vp9_compressed_header_parser.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/filters/vp9_parser.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/ac3/ac3_util.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/mp2t/es_adapter_video_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/mp2t/timestamp_unroller_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/mp4/avc_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/mp4/sample_to_group_iterator_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/mp4/track_run_iterator.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/mp4/track_run_iterator_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/mpeg/adts_constants.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/webm/webm_cluster_parser.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/webm/webm_cluster_parser_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/webm/webm_parser.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/formats/webm/webm_parser_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/h264_decoder.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/ipc/service/vda_video_decoder_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/test/rendering_helper.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/v4l2/generic_v4l2_device.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/v4l2/v4l2_jpeg_decode_accelerator.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/v4l2/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/v4l2/v4l2_video_encode_accelerator.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/vaapi/vaapi_h264_accelerator.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/vaapi/vaapi_jpeg_encoder.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/vaapi/vaapi_vp9_accelerator.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/vaapi/vaapi_wrapper.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/windows/d3d11_cdm_proxy.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/gpu/windows/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/midi/message_util_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/midi/midi_manager_alsa.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/midi/midi_manager_usb_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/midi/midi_manager_win.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/midi/usb_midi_descriptor_parser_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/midi/usb_midi_input_stream_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/midi/usb_midi_output_stream.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/mojo/clients/mojo_cdm_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/mojo/common/mojo_decoder_buffer_converter_unittest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/mojo/test/mojo_video_decoder_integration_test.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/muxers/webm_muxer_fuzzertest.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/video/h264_parser.cc
[modify] https://crrev.com/fa9bed46c6a5d52e44c8e410b9d52d7ec34d3ddc/media/video/h264_poc.cc

Comment 47 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b11a13a8903dd857e4619b2bd85f27dc1b82b1

commit a9b11a13a8903dd857e4619b2bd85f27dc1b82b1
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 20:27:29 2018

Use base::size rather than arraysize in courgette/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=wfh@chromium.org

Change-Id: I67c0b8518d2464298e282891298e3e2eb8ca4796
Reviewed-on: https://chromium-review.googlesource.com/c/1390733
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618875}
[modify] https://crrev.com/a9b11a13a8903dd857e4619b2bd85f27dc1b82b1/courgette/encoded_program_unittest.cc
[modify] https://crrev.com/a9b11a13a8903dd857e4619b2bd85f27dc1b82b1/courgette/memory_allocator_unittest.cc
[modify] https://crrev.com/a9b11a13a8903dd857e4619b2bd85f27dc1b82b1/courgette/third_party/bsdiff/bsdiff_search_unittest.cc

Comment 48 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3569037788b1203d91f22f2961af80afb4d1b1e1

commit 3569037788b1203d91f22f2961af80afb4d1b1e1
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 20:27:48 2018

Use base::size rather than arraysize in google_apis/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=rogerta@chromium.org

Change-Id: Id677222ade7cf9743aabc8f9bee9838bcda5ddb4
Reviewed-on: https://chromium-review.googlesource.com/c/1390727
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618876}
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/drive/drive_api_parser.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/drive/drive_api_url_generator_unittest.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gaia/oauth2_token_service_unittest.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gcm/base/mcs_util.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gcm/base/mcs_util_unittest.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gcm/base/socket_stream_unittest.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gcm/engine/gcm_store_impl.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gcm/engine/gcm_unregistration_request_handler.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gcm/engine/gservices_settings.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gcm/engine/registration_request.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/gcm/engine/unregistration_request.cc
[modify] https://crrev.com/3569037788b1203d91f22f2961af80afb4d1b1e1/google_apis/google_api_keys_unittest.cc

Comment 49 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/197295aeb83b9ce0c4a8e3f7f372db464f3b472d

commit 197295aeb83b9ce0c4a8e3f7f372db464f3b472d
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 20:28:34 2018

Use base::size rather than arraysize in extensions/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=rdevlin.cronin@chromium.org

Change-Id: I1893e0d4c9fc96075be5803d4acb3e938a757367
Reviewed-on: https://chromium-review.googlesource.com/c/1390729
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618877}
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/alarms/alarms_api_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/app_window/app_window_api.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/declarative_net_request/indexed_rule_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/feedback_private/feedback_private_api.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/file_system/file_system_api.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/printer_provider/printer_provider_apitest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/system_storage/system_storage_apitest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/web_request/form_data_parser.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/web_request/form_data_parser_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/web_request/web_request_resource_type.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/webcam_private/v4l2_webcam.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/api/webcam_private/visca_webcam.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/event_router_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/extension_creator_filter.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/guest_view/extension_view/whitelist/extension_view_whitelist.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/browser/image_loader_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/constants.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/csp_validator.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/extension_api.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/features/feature_util.h
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/features/simple_feature_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/file_util_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/manifest_handlers/csp_info_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/manifest_handlers/externally_connectable_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/manifest_handlers/mime_types_handler.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/manifest_handlers/shared_module_manifest_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/message_bundle_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/url_pattern.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/common/url_pattern_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/binding_generating_native_handler.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/api_binding_bridge.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/api_binding_bridge_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/api_binding_js_util_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/api_binding_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/api_bindings_system_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/api_event_handler.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/api_event_handler_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/argument_spec_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/declarative_event_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/event_emitter_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/bindings/exception_handler.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/declarative_content_hooks_delegate.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/event_bindings.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/gin_port_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/i18n_hooks_delegate.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/js_renderer_messaging_service.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/messaging_util_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/module_system.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/native_extension_bindings_system_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/native_renderer_messaging_service_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/one_time_message_handler_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/render_frame_observer_natives.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/runtime_hooks_delegate.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/script_context.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/storage_area_unittest.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/wake_event_page.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/renderer/web_request_hooks.cc
[modify] https://crrev.com/197295aeb83b9ce0c4a8e3f7f372db464f3b472d/extensions/shell/browser/shell_content_browser_client.cc

Comment 50 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/141d025104c98b1fb690ec626aa43aad80552a3a

commit 141d025104c98b1fb690ec626aa43aad80552a3a
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 20:28:54 2018

Use base::size rather than arraysize in device/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=rockot@google.com

Change-Id: If4b83253ade42613e9683b69e187b79a2a940b98
Reviewed-on: https://chromium-review.googlesource.com/c/1390730
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618878}
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/bluetooth/bluetooth_gatt_descriptor.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/bluetooth/bluetooth_uuid_unittest.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/bluetooth/uribeacon/uri_encoder.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/fido/ctap_response_unittest.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/gamepad/gamepad_platform_data_fetcher_linux.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/gamepad/raw_input_data_fetcher_win.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/gamepad/xbox_data_fetcher_mac.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/test/usb_test_gadget_impl.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/vr/openvr/test/fake_openvr_impl_api.cc
[modify] https://crrev.com/141d025104c98b1fb690ec626aa43aad80552a3a/device/vr/windows/d3d11_texture_helper.cc

Comment 51 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34f6b421d6d255b27e01d82c3c19f49a455caa06

commit 34f6b421d6d255b27e01d82c3c19f49a455caa06
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 20:29:39 2018

Use base::size rather than arraysize in crypto/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=davidben@chromium.org

Change-Id: I2de7af87ac267bd3bbcf809196a88c650b1e5225
Reviewed-on: https://chromium-review.googlesource.com/c/1390732
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618879}
[modify] https://crrev.com/34f6b421d6d255b27e01d82c3c19f49a455caa06/crypto/ec_private_key_unittest.cc
[modify] https://crrev.com/34f6b421d6d255b27e01d82c3c19f49a455caa06/crypto/encryptor_unittest.cc
[modify] https://crrev.com/34f6b421d6d255b27e01d82c3c19f49a455caa06/crypto/hmac_unittest.cc
[modify] https://crrev.com/34f6b421d6d255b27e01d82c3c19f49a455caa06/crypto/mock_apple_keychain.cc
[modify] https://crrev.com/34f6b421d6d255b27e01d82c3c19f49a455caa06/crypto/p224_unittest.cc

Comment 53 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d3ded9fe11219ad62458f953a70e37166a05f08

commit 9d3ded9fe11219ad62458f953a70e37166a05f08
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 20:50:21 2018

Use base::size rather than arraysize in content/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=piman@chromium.org

Change-Id: I5ce196bbb75462a0967a95d1b5fd2e72df2c86f4
Reviewed-on: https://chromium-review.googlesource.com/c/1390894
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618881}
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/accessibility/accessibility_tree_formatter_android.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/accessibility/accessibility_tree_formatter_utils_win.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/accessibility/browser_accessibility_state_impl_win.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/android/content_feature_list.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/android/java/java_type_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/appcache/appcache_database.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/appcache/appcache_manifest_parser_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/appcache/appcache_response_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/appcache/appcache_service_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/appcache/appcache_url_request_job_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/browser_main_loop.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/browser_url_handler_impl.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/browsing_data/clear_site_data_throttle_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/devtools/devtools_io_context.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/devtools/protocol/schema_handler.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/download/save_package_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/frame_host/navigator_impl_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/host_zoom_map_impl_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/loader/intercepting_resource_handler_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/loader/resource_loader_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/loader/upload_data_stream_builder_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/media/media_internals.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/notifications/notification_database_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/input/motion_event_web_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/pepper/pepper_renderer_connection.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/pepper/pepper_truetype_font_list_mac.mm
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/sandbox_ipc_linux.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/service_worker/service_worker_cache_writer_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/service_worker/service_worker_database_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/utility_process_host.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/browser/webui/web_ui_data_source_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/child/blink_platform_impl.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/common/font_list_fontconfig.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/common/unique_name_helper.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/common/webplugininfo_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/public/test/test_host_resolver.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/java/gin_java_bridge_value_converter_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/media/stream/media_stream_audio_processor_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/media/stream/media_stream_constraints_util_video_content_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/media/webrtc/rtc_video_encoder.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/media/webrtc/stun_field_trial.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/media_recorder/media_recorder_handler.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/media_recorder/video_track_recorder.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/notifications/notification_data_conversions_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/p2p/filtering_network_manager_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/pepper/pepper_audio_encoder_host.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/pepper/pepper_graphics_2d_host_unittest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/app/blink_test_platform_support_win.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/browser/shell_download_manager_delegate.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/browser/shell_views.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/browser/web_test/web_test_push_messaging_service.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/common/shell_origin_trial_policy.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/test_runner/accessibility_controller.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/test_runner/mock_grammar_check.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/test_runner/mock_spell_check.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/9d3ded9fe11219ad62458f953a70e37166a05f08/content/test/mock_keyboard_driver_win.cc

Comment 54 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fc2408cef6ae5e187380e98516db699776b19a8

commit 6fc2408cef6ae5e187380e98516db699776b19a8
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 21:29:08 2018

Use base::size rather than arraysize in gpu/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=piman@chromium.org

Change-Id: Ifd09d0a17296aa9a678ea353c7cd2de0c391b815
Reviewed-on: https://chromium-review.googlesource.com/c/1390726
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618882}
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/client/gles2_implementation_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/client/program_info_manager_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/client/query_tracker_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/client/raster_implementation_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/client/vertex_array_object_manager_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/common/gles2_cmd_format.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/common/gles2_cmd_utils.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/common/mailbox.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/common/raster_cmd_format.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/buffer_manager_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/common_decoder.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/framebuffer_manager_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder_unittest_extensions.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/gpu_tracer.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/program_manager.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/program_manager_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/sync_point_manager.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/test_helper.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/tests/gl_apply_screen_space_antialiasing_CHROMIUM_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/tests/gl_chromium_path_rendering_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/command_buffer/tests/gl_depth_texture_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/config/gpu_control_list_entry_unittest.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/config/gpu_driver_bug_list.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/config/gpu_dx_diagnostics_win.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/config/gpu_info_collector.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/gles2_conform_support/egl/display.cc
[modify] https://crrev.com/6fc2408cef6ae5e187380e98516db699776b19a8/gpu/ipc/service/gpu_watchdog_thread.cc

Comment 55 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f737e97dbd6e886d99d18515e6fe490093a0ed7

commit 4f737e97dbd6e886d99d18515e6fe490093a0ed7
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 21:29:38 2018

Use base::size rather than arraysize in chromecast/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=servolk@chromium.org

Change-Id: I4d3709dfd6de58a44a806dbc52ada71623438532
Reviewed-on: https://chromium-review.googlesource.com/c/1390900
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618883}
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/base/metrics/grouped_histogram.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/browser/cast_extension_message_filter.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/audio/cast_audio_manager_alsa.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/audio/cast_audio_output_stream_unittest.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/cdm/playready_drm_delegate_android.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/cma/backend/alsa/mixer_output_stream_alsa.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/cma/base/balanced_media_task_runner_unittest.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/cma/base/buffering_frame_provider_unittest.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/cma/base/decoder_buffer_adapter_unittest.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/media/cma/test/frame_generator_for_test.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/tracing/ftrace.cc
[modify] https://crrev.com/4f737e97dbd6e886d99d18515e6fe490093a0ed7/chromecast/tracing/system_tracing_common.cc

Comment 56 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec658401792e10176390ac47e0e864377d9aab08

commit ec658401792e10176390ac47e0e864377d9aab08
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 21:30:14 2018

Use base::size rather than arraysize in components/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=caitkp@chromium.org

Change-Id: Icba7642ba9452eb71f6c9148cc4e5cea7dac3b4b
Reviewed-on: https://chromium-review.googlesource.com/c/1390896
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618884}
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/history/core/browser/sync/typed_url_sync_bridge_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/history/core/browser/top_sites_cache_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/history/core/browser/url_database.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/history/core/browser/url_utils_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/history/core/browser/visit_tracker_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/image_fetcher/ios/webp_decoder_unittest.mm
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/invalidation/impl/ticl_invalidation_service.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/language/content/browser/regional_language_code_locator.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/language/core/browser/heuristic_language_model_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/metrics/field_trials_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/metrics/file_metrics_provider.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/metrics/file_metrics_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/metrics/system_session_analyzer_win.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/nacl/common/nacl_cmd_line.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/nacl/renderer/json_manifest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/navigation_metrics/navigation_metrics.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/network_session_configurator/common/network_switches.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/network_time/network_time_tracker_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/ntp_snippets/features.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/ntp_snippets/user_classifier.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/autocomplete_input.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/autocomplete_input_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/autocomplete_match_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/autocomplete_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/autocomplete_result_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/bookmark_provider.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/bookmark_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/builtin_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/history_quick_provider_performance_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/history_quick_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/history_url_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/in_memory_url_index_types_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/in_memory_url_index_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/keyword_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/omnibox_edit_model_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/omnibox_view_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/shortcuts_backend_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/shortcuts_database_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/shortcuts_provider_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/omnibox/browser/test_scheme_classifier.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/open_from_clipboard/clipboard_recent_content_ios.mm
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/os_crypt/keyring_util_linux.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/os_crypt/os_crypt_linux.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/password_manager/core/browser/android_affiliation/facet_manager_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/password_manager/core/browser/login_database_ios_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/password_manager/core/browser/password_reuse_detection_manager_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/password_manager/core/browser/password_store_default_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/payments/core/strings_util.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/payments/core/strings_util_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/browser/browser_policy_connector.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/browser/browser_policy_connector_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/browser/proxy_policy_handler.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/browser/url_blacklist_manager.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/cloud/cloud_policy_util.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/cloud/cloud_policy_validator.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/cloud/device_management_service_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/cloud/policy_builder.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/config_dir_policy_loader.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/policy_loader_mac_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/policy_loader_win.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/policy_service_impl.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/preg_parser.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/policy/core/common/schema_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/prefs/json_pref_store_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/prefs/pref_service_unittest.cc
[modify] https://crrev.com/ec658401792e10176390ac47e0e864377d9aab08/components/proxy_config/proxy_prefs.cc

Comment 57 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fbef51ae18cb2520148002150a548c43f67d20e

commit 5fbef51ae18cb2520148002150a548c43f67d20e
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 21:30:43 2018

Use base::size rather than arraysize in chromeos/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=stevenjb@chromium.org

Change-Id: Ieb7a1f942d2903a499e558ad783071197f84c5e4
Reviewed-on: https://chromium-review.googlesource.com/c/1390899
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618885}
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/accelerometer/accelerometer_reader.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/components/proximity_auth/metrics.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/dbus/shill_third_party_vpn_driver_client.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/dbus/update_engine_client.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/disks/disk_mount_manager_unittest.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/geolocation/geoposition.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/network/network_device_handler_impl.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/network/network_type_pattern.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/process_proxy/process_output_watcher.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/process_proxy/process_proxy_unittest.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/settings/timezone_settings.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/system/name_value_pairs_parser_unittest.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/system/statistics_provider.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/timezone/timezone_request.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/tools/onc_validator/onc_validator.cc
[modify] https://crrev.com/5fbef51ae18cb2520148002150a548c43f67d20e/chromeos/tpm/tpm_token_info_getter_unittest.cc

Comment 58 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80

commit 2244c2d53cc2ebb8d402b8d1042aaedffecc2f80
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 23:08:02 2018

Use base::size rather than arraysize in components/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=caitkp@chromium.org

Change-Id: Ic548dc0e6bc08a177987c7b6c1f2eed1db8023fd
Reviewed-on: https://chromium-review.googlesource.com/c/1390897
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618888}
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/content/browser/content_history_backend_db_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/core/browser/android/android_history_types.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/core/browser/android/android_urls_sql_handler.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/core/browser/android/favicon_sql_handler.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/core/browser/android/urls_sql_handler.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/core/browser/android/visit_sql_handler.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/core/browser/expire_history_backend_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/core/browser/history_backend_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/history/core/browser/history_querying_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/query_parser/query_parser_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/query_parser/snippet_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/rlz/rlz_tracker_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/safe_browsing/db/util.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/safe_browsing/db/v4_protocol_manager_util_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/safe_browsing/db/v4_store.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/search_engines/default_search_policy_handler.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/search_engines/template_url.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/search_engines/template_url_prepopulate_data.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/search_engines/template_url_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/services/filesystem/directory_impl_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sessions/core/session_backend_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/signin/core/browser/signin_error_controller_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/spellcheck/browser/android/component_jni_registrar.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/spellcheck/browser/spellcheck_host_metrics_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/spellcheck/browser/spellcheck_platform_mac_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/spellcheck/common/spellcheck_common.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/spellcheck/renderer/spellcheck_multilingual_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/spellcheck/renderer/spellcheck_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/spellcheck/renderer/spellcheck_worditerator.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/spellcheck/renderer/spellcheck_worditerator_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/ssl_errors/error_info.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/storage_monitor/mtab_watcher_linux.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/storage_monitor/storage_monitor_linux_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/base/get_session_name_win.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/base/immutable_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/base/node_ordinal_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/base/unique_position_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/driver/model_association_manager.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/engine/engine_util.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/engine_impl/directory_update_handler_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/engine_impl/syncer_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/syncable/directory_backing_store.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/syncable/directory_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/sync/syncable/model_type.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/test/components_test_suite.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/tracing/common/graphics_memory_dump_provider_android.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/translate/core/browser/translate_browser_metrics.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/translate/core/browser/translate_language_list.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/translate/core/common/translate_util.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/translate/core/language_detection/language_detection_util.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/url_formatter/elide_url_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/url_formatter/url_fixer_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/url_formatter/url_formatter.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/url_formatter/url_formatter_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/url_matcher/url_matcher_factory_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/url_matcher/url_matcher_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/vector_icons/cc_macros.h
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/visitedlink/browser/visitedlink_master.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/common/gl_helper_benchmark.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/common/gl_helper_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/common/resources/resource_format_utils.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/common/yuv_readback_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/service/display/bsp_tree_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/service/display/color_lut_cache.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/service/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/algorithms/aes_cbc_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/algorithms/aes_ctr_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/algorithms/aes_gcm_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/algorithms/aes_kw_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/algorithms/ec.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/algorithms/rsa_oaep_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/algorithms/rsa_ssa_unittest.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/algorithms/test_helpers.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/webcrypto/jwk.cc
[modify] https://crrev.com/2244c2d53cc2ebb8d402b8d1042aaedffecc2f80/components/zoom/page_zoom_constants.cc

Comment 59 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8171db7d9f54a54530858524dc4feb64556719b9

commit 8171db7d9f54a54530858524dc4feb64556719b9
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 23:08:31 2018

Use base::size rather than arraysize in components/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=caitkp@chromium.org

Change-Id: I619a6261ee88f38ca591dbee11e1e92fba3d550c
Reviewed-on: https://chromium-review.googlesource.com/c/1390895
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618889}
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/arc/arc_session_impl.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/arc/bluetooth/bluetooth_struct_traits_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/arc/intent_helper/arc_intent_helper_bridge.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/content/renderer/form_autofill_util_browsertest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/content/renderer/html_based_username_detector_vocabulary.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/autofill_data_util.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/autofill_profile_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/country_data.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/field_filler_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/phone_field.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/bookmarks/browser/bookmark_index_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/bookmarks/browser/bookmark_model_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/bookmarks/browser/bookmark_utils_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/captive_portal/captive_portal_types.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/cbor/reader_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/cbor/writer_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/cdm/common/widevine_drm_delegate_android.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/certificate_transparency/log_dns_client.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/certificate_transparency/log_dns_client_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/client_update_protocol/ecdsa.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/cloud_devices/common/printer_description.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/content_settings/core/browser/content_settings_policy_provider.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/content_settings/core/browser/content_settings_utils.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/content_settings/core/browser/content_settings_utils_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/content_settings/core/common/content_settings_pattern.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/crash/content/app/breakpad_win.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/crash/content/app/crashpad_win.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/crash/core/browser/crashes_ui_util.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/crash/core/common/crash_key_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/crx_file/crx_creator.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/crx_file/crx_verifier.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/crx_file/id_util_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/browser/data_reduction_proxy_util.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/discardable_memory/common/discardable_shared_memory_heap.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/dom_distiller/content/renderer/distillability_agent.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/domain_reliability/google_configs.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/domain_reliability/quic_error_mapping.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/domain_reliability/util.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/download/internal/common/base_file_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/download/internal/common/download_stats.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/download/quarantine/quarantine_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/drive/change_list_processor_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/drive/drive_api_util.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/drive/file_write_watcher_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/drive/resource_metadata_storage.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/drive/resource_metadata_storage_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/drive/search_metadata_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/error_page/common/localized_error.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/exo/buffer.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/exo/wayland/clients/blur.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/exo/wayland/clients/rects.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/exo/wayland/clients/simple.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/exo/wayland/clients/subsurface.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/exo/wayland/clients/vulkan.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/exo/wayland/server.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/favicon/core/fallback_url_util_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/favicon_base/select_favicon_frames_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/feature_engagement/public/feature_list.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/feature_engagement/public/feature_list.h
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/feedback/anonymizer_tool.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/feedback/anonymizer_tool_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/filename_generation/filename_generation_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/flags_ui/feature_entry_macros.h
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/flags_ui/flags_state.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/flags_ui/flags_state_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/gcm_driver/crypto/encryption_header_parsers_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/gcm_driver/crypto/gcm_message_cryptographer_unittest.cc
[modify] https://crrev.com/8171db7d9f54a54530858524dc4feb64556719b9/components/gcm_driver/crypto/message_payload_parser_unittest.cc

Comment 60 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22f82879e132691066277a74100bc8a7f9a4ecf6

commit 22f82879e132691066277a74100bc8a7f9a4ecf6
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 23:09:07 2018

Use base::size rather than arraysize in chrome/ part 3.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=thakis@chromium.org

Change-Id: I4a6d2e74a185e7b787fd91942927646da99c8dae
Reviewed-on: https://chromium-review.googlesource.com/c/1390903
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618890}
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/renderer_host/chrome_extension_message_filter.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/renderer_host/chrome_render_message_filter.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/renderer_host/pepper/device_id_fetcher.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/resources_util_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/safe_browsing/incident_reporting/module_integrity_unittest_util_win.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/search/search_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/search_engines/template_url_fetcher_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/search_engines/template_url_parser_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/search_engines/template_url_service_sync_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/search_engines/template_url_service_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/sessions/session_restore_delegate.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/shell_integration_linux_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/signin/signin_global_error_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/spellchecker/spelling_service_client_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/themes/browser_theme_pack.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/app_list/search/tests/mixer_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/app_list/search/tests/tokenized_string_match_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/autofill/popup_view_common_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/browser_command_controller_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/browser_focus_uitest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/browser_instant_controller_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/libgtkui/gtk_key_bindings_handler.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/accelerator_table.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/color_chooser_dialog.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/device_chooser_content_view.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/frame/browser_view_layout.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/hover_button_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/keyboard_access_browsertest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/layout_provider_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/settings_reset_prompt_dialog_browsertest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/tabs/stacked_tab_strip_layout_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/tabs/tab_strip_layout_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/views/try_chrome_dialog_win/try_chrome_dialog.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/webui/chromeos/image_source.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/webui/fileicon_source_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/vr/elements/controller.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/vr/elements/draw_phase.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/vr/elements/environment/stars.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/vr/elements/ui_element_type.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/vr/renderers/base_quad_renderer.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/vr/renderers/textured_quad_renderer.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/browser/win/jumplist.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/crash_keys.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/api/common_extension_api_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/command_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/extension_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_handlers/app_theme_color_manifest_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_handlers/exclude_matches_manifest_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_about_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
[modify] https://crrev.com/22f82879e132691066277a74100bc8a7f9a4ecf6/chrome/common/extensions/permissions/permission_set_unittest.cc

Comment 61 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8583823ab9ad8966de41037bbd4b50aa7dbad2b

commit a8583823ab9ad8966de41037bbd4b50aa7dbad2b
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 23:09:38 2018

Use base::size rather than arraysize in chrome/ part 1.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=thakis@chromium.org

Change-Id: Id81bc140e6da636a860e9135239d2f4d1a239abf
Reviewed-on: https://chromium-review.googlesource.com/c/1390901
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618891}
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/app/android/chrome_jni_onload.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/app/chrome_exe_main_win.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/app/chrome_watcher_client_unittest_win.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/app/chrome_watcher_client_win.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/app/chrome_watcher_command_line_win.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/about_flags.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/android/chrome_backup_agent.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/android/preferences/prefs_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/android/signin/signin_manager_android_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/app_mode/app_mode_utils.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/apps/platform_apps/api/music_manager_private/device_id.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/apps/platform_apps/api/music_manager_private/device_id_linux.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browser_encoding_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browser_keyevents_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browsing_data/browsing_data_file_system_helper.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/browsing_data/site_data_size_collector_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chrome_plugin_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/arc/file_system_watcher/arc_file_system_watcher_service.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/attestation/fake_certificate.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/customization/customization_document_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/extensions/default_app_order.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/extensions/gfx_utils.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/file_manager/open_with_browser.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/fileapi/file_system_backend.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/input_method/textinput_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/locale_change_guard.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/login_ui_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/network_change_manager_client_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/note_taking_helper.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/policy/app_install_event_log_manager_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/policy/device_local_account.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/power/power_metrics_reporter.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/preferences_chromeos_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/chromeos/resource_reporter/resource_reporter_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/component_updater/file_type_policies_component_installer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/component_updater/mei_preload_component_installer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/component_updater/origin_trials_component_installer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/component_updater/recovery_component_installer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/conflicts/module_blacklist_cache_util_win.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/conflicts/module_info_util_win_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/devtools/device/android_device_info_query.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/diagnostics/diagnostics_controller_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/diagnostics/diagnostics_metrics.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/diagnostics/diagnostics_writer.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/download/download_prefs.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/download/notification/download_notification_interactive_uitest.cc
[modify] https://crrev.com/a8583823ab9ad8966de41037bbd4b50aa7dbad2b/chrome/browser/engagement/site_engagement_metrics.cc

Comment 62 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf47385ab0d1b6b237c2fafbe2c2a73c09abdd97

commit cf47385ab0d1b6b237c2fafbe2c2a73c09abdd97
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 23:10:14 2018

Use base::size rather than arraysize in apps/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=mgiuca@chromium.org

Change-Id: I24d6673fdc32c84d3bff01dd43bc62a80467eb7d
Reviewed-on: https://chromium-review.googlesource.com/c/1390908
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618892}
[modify] https://crrev.com/cf47385ab0d1b6b237c2fafbe2c2a73c09abdd97/apps/load_and_launch_browsertest.cc

Comment 63 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48c9b176af94f7ec65e20f21594524526d2a830

commit c48c9b176af94f7ec65e20f21594524526d2a830
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 23:16:46 2018

Use base::size rather than arraysize in ash/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=jamescook@chromium.org

Change-Id: I5f42334a368d102094d6215389d1ffba4a764d6e
Reviewed-on: https://chromium-review.googlesource.com/c/1390907
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618893}
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/accelerators/accelerator_table.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/accessibility/touch_exploration_controller_unittest.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/app_list/views/pulsing_block_view.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/components/tap_visualizer/tap_renderer.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/events/keyboard_driven_event_rewriter_unittest.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/first_run/desktop_cleaner.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/login/ui/login_pin_view.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/public/cpp/accelerators.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/public/cpp/shell_window_ids.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/root_window_controller.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/shelf/shelf_button.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/shell/app_list.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/shell_unittest.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/system/audio/unified_volume_view.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/wallpaper/wallpaper_utils/wallpaper_resizer_unittest.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/wm/switchable_windows.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/wm/tablet_mode/accelerometer_test_data_literals.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/wm/test_session_state_animator.cc
[modify] https://crrev.com/c48c9b176af94f7ec65e20f21594524526d2a830/ash/wm/window_modality_controller_unittest.cc

Comment 64 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7

commit 0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 23:20:46 2018

Use base::size rather than arraysize in cc/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=danakj@chromium.org

Change-Id: Ib0a981182e0a6489cc4ec8cc3b186a40aec20240
Reviewed-on: https://chromium-review.googlesource.com/c/1390905
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618894}
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/animation/keyframe_model.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/animation/transform_operations_unittest.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/base/index_rect_unittest.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/paint/filter_operation.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/paint/solid_color_analyzer_unittest.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/test/task_graph_runner_test_template.h
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/tiles/picture_layer_tiling.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/tiles/tile_manager_perftest.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/trees/layer_tree_host_pixeltest_blending.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/0dd4e0e6fc069d43dd224973bcd1c3cbb1dc5cf7/cc/trees/occlusion_unittest.cc

Comment 65 by bugdroid1@chromium.org, Dec 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a

commit 5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a
Author: Avi Drissman <avi@chromium.org>
Date: Tue Dec 25 23:20:49 2018

Use base::size rather than arraysize in chrome/ part 2.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=thakis@chromium.org

Change-Id: I3667abeefbc6c189bb96ca4ba0f1fb275db28185
Reviewed-on: https://chromium-review.googlesource.com/c/1390902
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618895}
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/activity_log/activity_database_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/activity_log/activity_log.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/activity_log/activity_log_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/activity_log/counting_policy.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/activity_log/fullstream_ui_policy.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/content_settings/content_settings_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/cookies/cookies_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/gcm/gcm_api.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/management/management_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/metrics_private/metrics_apitest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/proxy/proxy_api_constants.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/system_private/system_private_api.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/terminal/terminal_extension_helper.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/api/web_request/web_request_event_details_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/chrome_app_sorting.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/chrome_component_extension_resource_manager.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/convert_web_app_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/default_apps.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/extension_management_constants.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/extension_protocols_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/extension_tab_util.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/global_shortcut_listener_x11.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/permission_messages_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/process_manager_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/extensions/window_open_apitest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/external_protocol/external_protocol_handler.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/file_select_helper_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/first_run/upgrade_util_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/google/google_brand.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/history/android/bookmark_model_sql_handler.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/history/top_sites_factory.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/icon_loader_chromeos.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/importer/edge_importer_browsertest_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/importer/firefox_importer_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/lifetime/switch_utils_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/locale_tests_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/mac/exception_processor.mm
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/mac/install_from_dmg.mm
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media/router/discovery/dial/dial_service_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media/router/discovery/discovery_network_list_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media/router/test/media_router_mojo_test.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media/webrtc/webrtc_event_log_manager_local.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media/webrtc/webrtc_rtp_dump_handler_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media/webrtc/webrtc_rtp_dump_writer.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media/webrtc/webrtc_rtp_dump_writer_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media_galleries/chromeos/mtp_device_object_enumerator_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media_galleries/fileapi/media_path_filter.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media_galleries/media_galleries_permissions_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/media_galleries/win/mtp_device_object_enumerator_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/memory/memory_kills_monitor_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/metrics/perf/cpu_identity.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/metrics/thread_watcher_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/net/service_providers_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/password_manager/password_manager_util_mac.mm
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/password_manager/password_manager_util_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/platform_util_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/platform_util_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/plugins/plugin_policy_handler.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/policy/site_isolation_policy_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/predictors/autocomplete_action_predictor.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/prefs/chrome_command_line_pref_store.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/prefs/chrome_command_line_pref_store_proxy_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/prefs/profile_pref_store_manager_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/prerender/prerender_final_status.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/prerender/prerender_origin.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/printing/cloud_print/privet_traffic_detector.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/printing/printing_layout_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/process_singleton_posix.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/process_singleton_win_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/profile_resetter/brandcode_config_fetcher.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/profile_resetter/profile_resetter.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/profile_resetter/profile_resetter_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/profiles/profile_attributes_storage.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/profiles/profile_info_cache_unittest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/profiles/profile_shortcut_manager_win.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/5f0fb8c9021d25d1fadc1ae3706b4790dbcded5a/chrome/browser/push_messaging/push_messaging_service_unittest.cc

Comment 66 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1503cd697e3c53646e7c5e14d6ba33e854054f52

commit 1503cd697e3c53646e7c5e14d6ba33e854054f52
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Dec 26 03:00:09 2018

Revert "Use base::size rather than arraysize in chrome/ part 1."

This reverts commit a8583823ab9ad8966de41037bbd4b50aa7dbad2b.

Reason for revert: Build break on "Google Chrome Win"
https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_Win/42271/+/recipes/steps/compile/0/stdout
> ../../chrome/browser/conflicts/module_blacklist_cache_util_win.cc(235,59):  error: invalid use of non-static data member 'a'
>                                 base::size(base::MD5Digest::a));

Original change's description:
> Use base::size rather than arraysize in chrome/ part 1.
> 
> This is purely a mechanical change; there is no intended behavior change.
> 
> BUG=837308
> TBR=thakis@chromium.org
> 
> Change-Id: Id81bc140e6da636a860e9135239d2f4d1a239abf
> Reviewed-on: https://chromium-review.googlesource.com/c/1390901
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618891}

TBR=avi@chromium.org,thakis@chromium.org

Change-Id: Ic3a14aa3f6e81dd067fe41a948932b85d38daed9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 837308
Reviewed-on: https://chromium-review.googlesource.com/c/1390881
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618896}
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/app/android/chrome_jni_onload.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/app/chrome_exe_main_win.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/app/chrome_watcher_client_unittest_win.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/app/chrome_watcher_client_win.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/app/chrome_watcher_command_line_win.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/about_flags.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/android/chrome_backup_agent.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/android/preferences/prefs_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/android/signin/signin_manager_android_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/app_mode/app_mode_utils.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/apps/platform_apps/api/music_manager_private/device_id.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/apps/platform_apps/api/music_manager_private/device_id_linux.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browser_encoding_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browser_keyevents_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browsing_data/browsing_data_file_system_helper.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/browsing_data/site_data_size_collector_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chrome_plugin_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/arc/file_system_watcher/arc_file_system_watcher_service.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/attestation/fake_certificate.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/customization/customization_document_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/extensions/default_app_order.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/extensions/gfx_utils.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/file_manager/open_with_browser.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/fileapi/file_system_backend.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/input_method/textinput_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/locale_change_guard.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/login_ui_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/network_change_manager_client_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/note_taking_helper.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/policy/app_install_event_log_manager_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/policy/device_local_account.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/power/power_metrics_reporter.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/preferences_chromeos_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/proxy_cros_settings_parser.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/chromeos/resource_reporter/resource_reporter_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/component_updater/file_type_policies_component_installer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/component_updater/mei_preload_component_installer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/component_updater/origin_trials_component_installer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/component_updater/recovery_component_installer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/conflicts/module_blacklist_cache_util_win.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/conflicts/module_info_util_win_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/devtools/device/android_device_info_query.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/diagnostics/diagnostics_controller_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/diagnostics/diagnostics_metrics.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/diagnostics/diagnostics_writer.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/download/download_prefs.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/download/notification/download_notification_interactive_uitest.cc
[modify] https://crrev.com/1503cd697e3c53646e7c5e14d6ba33e854054f52/chrome/browser/engagement/site_engagement_metrics.cc

Comment 67 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a93c1ca219f698ace9358df126429291a445a0

commit 35a93c1ca219f698ace9358df126429291a445a0
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 26 03:25:23 2018

Use base::size rather than arraysize in chrome/ part 4.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=thakis@chromium.org

Change-Id: I03f14ea92029f1a2a0350d2c81a2897548d0e8fc
Reviewed-on: https://chromium-review.googlesource.com/c/1390904
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618901}
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/importer/firefox_importer_utils_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/mac/cfbundle_blocker.mm
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/mac/cfbundle_blocker_unittest.mm
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/media/cdm_host_file_path.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/origin_trials/chrome_origin_trial_policy.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/origin_trials/chrome_origin_trial_policy_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/pref_names.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/service_process_util.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/gpu/widevine_cdm_proxy_factory.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/install_static/install_util_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/gcapi/gcapi.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/setup/install_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/setup/setup_util.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/setup/user_experiment.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/test/alternate_version_generator.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/test/alternate_version_generator_main.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/advanced_firewall_manager_win.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/app_command.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/auto_launch_util.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/channel_info.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/delete_after_reboot_helper_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/delete_reg_key_work_item_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/google_update_settings_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/install_util.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/install_util_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/l10n_string_util.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/master_preferences.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/master_preferences_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/move_tree_work_item_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/self_cleaning_temp_dir_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/shell_util.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/installer/util/shell_util_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/notification_helper/trace_util.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/app_categorizer.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/app_categorizer_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/extensions/app_bindings.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/extensions/custom_types_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/net/net_error_helper_core.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/net/net_error_helper_core_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/pepper/pepper_flash_renderer_host.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/pepper/pepper_uma_host.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/plugins/plugin_uma.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/searchbox/searchbox_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/renderer/web_apps_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/service/cloud_print/connector_settings_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/base/always_on_top_window_killer_win.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/base/in_process_browser_test_browsertest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/base/interactive_test_utils_win.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/capabilities.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/chrome/chrome_finder.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/key_converter.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/key_converter_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/keycode_text_conversion_x.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/logging.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/logging_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/server/chromedriver_server.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/logging/win/file_logger.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/logging/win/log_file_printer.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/logging/win/mof_data_parser_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/test/remoting/key_code_conv.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/third_party/mozilla_security_manager/nsUsageArrayHelper.cpp
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/tools/convert_dict/convert_dict_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/importer/bookmark_html_reader.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/importer/bookmark_html_reader_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/importer/bookmarks_file_importer.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/importer/bookmarks_file_importer_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/importer/edge_database_reader_unittest_win.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/importer/firefox_importer.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/importer/safari_importer_unittest.mm
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/safe_browsing/mac/hfs.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/safe_browsing/mac/hfs_unittest.cc
[modify] https://crrev.com/35a93c1ca219f698ace9358df126429291a445a0/chrome/utility/safe_browsing/mac/udif.cc

Comment 68 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d251e9163d8a4dc1e9ab78e2576560957acf35e3

commit d251e9163d8a4dc1e9ab78e2576560957acf35e3
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 26 15:46:37 2018

Use base::size rather than arraysize in chrome/ part 1.

This is purely a mechanical change; there is no intended behavior change.

This is a reland of a8583823ab9ad8966de41037bbd4b50aa7dbad2b without the
problematic file.

BUG=837308
TBR=thakis@chromium.org

Change-Id: I730f831be9ceeb041db5660b17becee51c3e887f
Reviewed-on: https://chromium-review.googlesource.com/c/1390956
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618929}
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/app/android/chrome_jni_onload.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/app/chrome_exe_main_win.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/app/chrome_watcher_client_unittest_win.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/app/chrome_watcher_client_win.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/app/chrome_watcher_command_line_win.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/about_flags.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/android/chrome_backup_agent.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/android/preferences/prefs_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/android/signin/signin_manager_android_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/app_mode/app_mode_utils.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/apps/platform_apps/api/music_manager_private/device_id.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/apps/platform_apps/api/music_manager_private/device_id_linux.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browser_encoding_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browser_keyevents_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browsing_data/browsing_data_file_system_helper.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/browsing_data/site_data_size_collector_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chrome_plugin_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/arc/file_system_watcher/arc_file_system_watcher_service.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/attestation/fake_certificate.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/customization/customization_document_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/extensions/default_app_order.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/extensions/gfx_utils.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/file_manager/open_with_browser.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/fileapi/file_system_backend.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/input_method/textinput_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/locale_change_guard.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/login_ui_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/network_change_manager_client_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/note_taking_helper.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/policy/app_install_event_log_manager_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/policy/device_local_account.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/power/power_metrics_reporter.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/preferences_chromeos_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/proxy_cros_settings_parser.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/chromeos/resource_reporter/resource_reporter_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/component_updater/file_type_policies_component_installer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/component_updater/mei_preload_component_installer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/component_updater/origin_trials_component_installer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/component_updater/recovery_component_installer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/conflicts/module_info_util_win_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/data_reduction_proxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/devtools/device/android_device_info_query.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/diagnostics/diagnostics_controller_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/diagnostics/diagnostics_metrics.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/diagnostics/diagnostics_writer.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/download/download_prefs.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/download/notification/download_notification_interactive_uitest.cc
[modify] https://crrev.com/d251e9163d8a4dc1e9ab78e2576560957acf35e3/chrome/browser/engagement/site_engagement_metrics.cc

Comment 69 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/118cee8f3cb6224803c569f63c496d077ccbe6b6

commit 118cee8f3cb6224803c569f63c496d077ccbe6b6
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 26 17:07:16 2018

Use base::size rather than arraysize in ipc/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308

Change-Id: I696e8015bd186b2977777eac39ed49e6ec0fa6b5
Reviewed-on: https://chromium-review.googlesource.com/c/1390725
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618936}
[modify] https://crrev.com/118cee8f3cb6224803c569f63c496d077ccbe6b6/ipc/message_filter_router.cc
[modify] https://crrev.com/118cee8f3cb6224803c569f63c496d077ccbe6b6/ipc/sync_socket_unittest.cc

Comment 70 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194c414dae90882ab569d041cc183f43534ddcc8

commit 194c414dae90882ab569d041cc183f43534ddcc8
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 26 19:45:20 2018

Unbreak win builder after switch to base::size().

BUG=837308, 917865
TBR=thakis@chromium.org

Signed-off-by: Avi Drissman <avi@chromium.org>
Change-Id: I317104f7dbe46dad56804631050ee34cba9d7e89
Reviewed-on: https://chromium-review.googlesource.com/c/1391290
Cr-Commit-Position: refs/heads/master@{#618950}
[modify] https://crrev.com/194c414dae90882ab569d041cc183f43534ddcc8/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc

Comment 72 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2

commit 2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 26 22:27:21 2018

Reinstate removed but needed header files.

BUG=837308

Change-Id: Id8c91d2f4a12ed3a60da30e5e7104ec25414feee
Reviewed-on: https://chromium-review.googlesource.com/c/1391291
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618970}
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/browser/api/declarative_net_request/indexed_rule_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/browser/event_router_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/common/features/simple_feature_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/bindings/api_binding_js_util_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/bindings/api_binding_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/bindings/api_event_handler_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/bindings/argument_spec_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/bindings/declarative_event_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/bindings/event_emitter_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/gin_port_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/native_extension_bindings_system_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/native_renderer_messaging_service_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/one_time_message_handler_unittest.cc
[modify] https://crrev.com/2f6e1be9ef6b53e97269dc24ae3c198a5c1098a2/extensions/renderer/render_frame_observer_natives.cc

Comment 73 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a52c974b6f2394e7df290171f466792c8214d4f1

commit a52c974b6f2394e7df290171f466792c8214d4f1
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 26 22:27:24 2018

Use base::size rather than arraysize in media/ ipc.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308

Change-Id: I0b636be13abe367abb6bfab4b581296f38d6df43
Reviewed-on: https://chromium-review.googlesource.com/c/1390722
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618971}
[modify] https://crrev.com/a52c974b6f2394e7df290171f466792c8214d4f1/media/mojo/common/media_type_converters_unittest.cc
[modify] https://crrev.com/a52c974b6f2394e7df290171f466792c8214d4f1/media/mojo/interfaces/audio_decoder_config_struct_traits_unittest.cc
[modify] https://crrev.com/a52c974b6f2394e7df290171f466792c8214d4f1/media/mojo/interfaces/video_decoder_config_struct_traits_unittest.cc

Comment 74 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035498578a999dc1e922c42fc52db6c1334ff36a

commit 035498578a999dc1e922c42fc52db6c1334ff36a
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 26 22:37:06 2018

Use base::size rather than arraysize.

BUG=837308

Change-Id: I7c8e3a6ccf454cd0bbaca2692d3eccbd772f2e0f
Reviewed-on: https://chromium-review.googlesource.com/c/1390098
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618973}
[modify] https://crrev.com/035498578a999dc1e922c42fc52db6c1334ff36a/mojo/public/tools/bindings/generators/cpp_templates/module-shared.cc.tmpl
[modify] https://crrev.com/035498578a999dc1e922c42fc52db6c1334ff36a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

Comment 75 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d512a498b4e88d800aa6af272fc48f411abaaeae

commit d512a498b4e88d800aa6af272fc48f411abaaeae
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 26 22:38:16 2018

Use base::size rather than arraysize in sandbox/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308

Change-Id: I161fec9229ffbf84983d606c2b347a3e5a1829a5
Reviewed-on: https://chromium-review.googlesource.com/c/1390113
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618974}
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/bpf_dsl/policy_compiler.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/bpf_dsl/syscall_set_unittest.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/bpf_dsl/test_trap_registry_unittest.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/seccomp-bpf/syscall_unittest.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/services/credentials.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/services/namespace_sandbox.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/suid/client/setuid_sandbox_host.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/linux/syscall_broker/broker_process_unittest.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/mac/seatbelt_extension_unittest.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/win/src/filesystem_policy.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/win/src/ipc_leak_test.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/win/src/win_utils.cc
[modify] https://crrev.com/d512a498b4e88d800aa6af272fc48f411abaaeae/sandbox/win/src/win_utils.h

Comment 76 by bugdroid1@chromium.org, Dec 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc1c52465e90432c098c93346e231efd0b5129a

commit acc1c52465e90432c098c93346e231efd0b5129a
Author: Avi Drissman <avi@chromium.org>
Date: Thu Dec 27 17:31:56 2018

Use base::size rather than arraysize in services/ ipcs.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308

Change-Id: Ic147f3f27f65adfbefb026296347a68e5ca5f2e3
Reviewed-on: https://chromium-review.googlesource.com/c/1390719
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619050}
[modify] https://crrev.com/acc1c52465e90432c098c93346e231efd0b5129a/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/acc1c52465e90432c098c93346e231efd0b5129a/services/service_manager/sandbox/win/sandbox_win.cc
[modify] https://crrev.com/acc1c52465e90432c098c93346e231efd0b5129a/services/ws/public/mojom/ime/ime_struct_traits_unittest.cc

Comment 77 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f01dc66c445c954d5c51aaa11cc8cc7c211c930

commit 6f01dc66c445c954d5c51aaa11cc8cc7c211c930
Author: Avi Drissman <avi@chromium.org>
Date: Fri Dec 28 17:36:29 2018

Use base::size and std::extent rather than arraysize in media/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
TBR=dalecurtis

Change-Id: Icc38b99f1ef5af58ce66ebeef1603e76cd3b6f78
Reviewed-on: https://chromium-review.googlesource.com/c/1391711
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619169}
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/filters/vp9_uncompressed_header_parser.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/v4l2/v4l2_h264_accelerator.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/v4l2/v4l2_vp8_accelerator.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/v4l2/v4l2_vp9_accelerator.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/vaapi/vaapi_jpeg_encoder.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/vaapi/vaapi_utils.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/vaapi/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/vaapi/vaapi_vp9_accelerator.cc
[modify] https://crrev.com/6f01dc66c445c954d5c51aaa11cc8cc7c211c930/media/gpu/vaapi/vaapi_wrapper.cc

Comment 78 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4365a478d0a7040d71331d0349102b6ef300aa2a

commit 4365a478d0a7040d71331d0349102b6ef300aa2a
Author: Avi Drissman <avi@chromium.org>
Date: Fri Dec 28 19:26:24 2018

Use base::size rather than arraysize in net/.

BUG=837308

Change-Id: Icc80e825ba0cee5d5a828aedf0ab7636824d903f
Reviewed-on: https://chromium-review.googlesource.com/c/1390419
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619176}
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/disk_cache/backend_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/disk_cache/blockfile/backend_impl.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/disk_cache/blockfile/mapped_file_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/disk_cache/blockfile/stats.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/disk_cache/simple/simple_index_file_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/dns/address_sorter_posix.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/dns/dns_config_service_posix_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/dns/dns_hosts_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/dns/dns_response_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/dns/dns_test_util.h
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/dns/dns_transaction_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/dns/dns_util_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/dns/host_cache_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/ftp/ftp_directory_listing_parser.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/ftp/ftp_directory_listing_parser_ls_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/ftp/ftp_directory_listing_parser_vms.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/ftp/ftp_directory_listing_parser_vms_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/ftp/ftp_directory_listing_parser_windows_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/ftp/ftp_util_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth_filter_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth_gssapi_posix.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth_gssapi_posix_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth_handler_basic_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth_handler_digest_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth_handler_negotiate_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth_handler_ntlm_portable_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_auth_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_basic_state.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_byte_range_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_cache_transaction.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_chunked_decoder_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_content_disposition_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_response_headers.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_stream_parser_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_transaction_test_util.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_util_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/http_vary_data_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/transport_security_state_static.template
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/transport_security_state_static_unittest.template
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/http/url_security_manager_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/log/net_log_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/nqe/network_quality_observation_source.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/pac_file_fetcher_impl.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/pac_file_fetcher_impl_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_config_service_linux_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_config_service_win_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_config_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_list_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_resolver_v8.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_resolver_v8_tracing_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_resolver_v8_tracing_wrapper_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_resolver_v8_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/proxy_resolution/proxy_server_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/quic/quic_chromium_client_stream_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/quic/quic_http_stream_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/quic/quic_stream_factory_fuzzer.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/reporting/reporting_header_parser_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/server/http_server_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/sequenced_socket_data_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/socks5_client_socket.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/socks_client_socket.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/ssl_client_socket_pool_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/ssl_server_socket_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/transport_client_socket_pool_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/socket/websocket_transport_client_socket_pool_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/fuzzing/hpack_fuzz_util_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_buffer_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_http_stream_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_read_queue_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_session_fuzzer.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_session_pool_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_stream_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_test_util_common.h
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/spdy/spdy_write_queue_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/ssl/client_cert_store_mac.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/ssl/ssl_cipher_suite_names_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/test/url_request/url_request_failed_job.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/tools/cachetool/cachetool.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/tools/crash_cache/crash_cache.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/tools/quic/quic_simple_server_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/tools/tld_cleanup/tld_cleanup_util.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/url_request/url_request_job_manager.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/url_request/url_request_simple_job_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/url_request/url_request_test_job.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/url_request/url_request_throttler_simulation_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/url_request/url_request_throttler_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_basic_stream_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_channel.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_channel_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_deflate_parameters_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_extension_parser_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_frame_parser_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_frame_perftest.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_frame_test.cc
[modify] https://crrev.com/4365a478d0a7040d71331d0349102b6ef300aa2a/net/websockets/websocket_stream_test.cc

Comment 80 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c029168ba251a240b0ec91fa3b4af4214fbbe9ab

commit c029168ba251a240b0ec91fa3b4af4214fbbe9ab
Author: Avi Drissman <avi@chromium.org>
Date: Fri Dec 28 19:38:42 2018

Use base::size and std::extent rather than arraysize in blink.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=chrishtr@chromium.org

Change-Id: Ie0bb3e2dda30ab41f5f1675666cc33b96f86dabd
Reviewed-on: https://chromium-review.googlesource.com/c/1391955
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619181}
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/common/client_hints/client_hints.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/common/mime_util/mime_util.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/common/origin_trials/trial_token_unittest.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/common/origin_trials/trial_token_validator_unittest.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/accessibility/ax_object_cache.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/animation/animation_input_helpers.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/css/css_computed_style_declaration.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/css/css_gradient_value.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/css/css_selector.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/css/font_face_cache_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/css/properties/css_property_base_custom.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/css/properties/shorthands/border_custom.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/css/style_property_serializer.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/css/style_property_shorthand_custom.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/editing/commands/editing_command_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/editing/commands/editor_command.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/editing/editing_style.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/editing/iterators/search_buffer_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/editing/serializers/markup_formatter.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/editing/state_machines/state_machine_util.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/events/input_event.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/exported/web_associated_url_loader_impl_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/exported/web_frame_content_dumper.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/fetch/fetch_data_loader_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/fetch/fetch_header_list_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/fetch/form_data_bytes_consumer_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/fetch/multipart_parser.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/html/html_document.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/html/track/vtt/buffered_line_reader_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/html/track/vtt/vtt_cue.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/layout/layout_quote.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/layout/layout_text_combine.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/layout/layout_text_control.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/loader/private/frame_client_hints_preferences_context.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/loader/text_resource_decoder_builder.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/mojo/tests/js_to_cpp_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/paint/box_border_painter.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/svg/svg_element.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/svg/svg_transform.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/svg/svg_transform_list.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/xml/parser/xml_document_parser.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/core/xml/xpath_functions.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/animationworklet/animator.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/crypto/crypto_key.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/crypto/normalize_algorithm.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/crypto/subtle_crypto.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/eventsource/event_source_parser.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_metrics.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/notifications/notification_data_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/payments/basic_card_helper.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/payments/payment_request.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/push_messaging/push_subscription_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/screen_orientation/screen_orientation.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/webdatabase/sql_transaction.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/webdatabase/sql_transaction_backend.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/webgl/webgl_compressed_texture_astc.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/exported/web_crypto_algorithm.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/fonts/font_description_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/fonts/win/font_cache_skia_win.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/fonts/win/font_fallback_win.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/graphics/filters/fe_component_transfer.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/graphics/logging_canvas.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/graphics/placeholder_image.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/image-decoders/webp/webp_image_decoder_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/loader/subresource_integrity.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/network/http_parsers_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/text/bidi_resolver_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/text/character.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/text/locale_icu.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/text/locale_mac.mm
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/text/locale_win.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/text/text_break_iterator.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/text/text_break_iterator.h
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/text/unicode_utilities_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/transforms/transform_operations_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/web_vector_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/weborigin/kurl_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/weborigin/security_origin_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/wtf/date_math.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/wtf/text/integer_to_string_conversion.h
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/wtf/text/string_builder_test.cc
[modify] https://crrev.com/c029168ba251a240b0ec91fa3b4af4214fbbe9ab/third_party/blink/renderer/platform/wtf/text/wtf_string_test.cc

Comment 81 by bugdroid1@chromium.org, Dec 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993bc2eb174c1216ebbdcc4ac7d46cd2771890ff

commit 993bc2eb174c1216ebbdcc4ac7d46cd2771890ff
Author: Avi Drissman <avi@chromium.org>
Date: Sun Dec 30 08:33:39 2018

Use base::size rather than arraysize in third_party/leveldatabase/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=pwnall@chromium.org

Change-Id: I0cb1795cec12770775a41c639feddb9e060de4ce
Reviewed-on: https://chromium-review.googlesource.com/c/1392745
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619268}
[modify] https://crrev.com/993bc2eb174c1216ebbdcc4ac7d46cd2771890ff/third_party/leveldatabase/env_chromium.cc

Comment 82 by bugdroid1@chromium.org, Dec 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1daac242cd39c3f270699f363fd93a386758310d

commit 1daac242cd39c3f270699f363fd93a386758310d
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 31 10:50:50 2018

Use base::size in net/third_party/quic/.

BUG=837308

Change-Id: I6aafd4b6e2fcc2dc5e021a6322c2e9ce1e23284c
Reviewed-on: https://chromium-review.googlesource.com/c/1391957
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619303}
[modify] https://crrev.com/1daac242cd39c3f270699f363fd93a386758310d/net/third_party/quic/core/crypto/crypto_utils.cc
[modify] https://crrev.com/1daac242cd39c3f270699f363fd93a386758310d/net/third_party/quic/platform/impl/quic_arraysize_impl.h
[modify] https://crrev.com/1daac242cd39c3f270699f363fd93a386758310d/net/third_party/quic/platform/impl/quic_socket_utils.cc

Comment 83 by bugdroid1@chromium.org, Jan 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7707f82395be87ca3524151c26d3dd2569fec043

commit 7707f82395be87ca3524151c26d3dd2569fec043
Author: Avi Drissman <avi@chromium.org>
Date: Wed Jan 02 16:22:02 2019

Use base::size rather than arraysize in third_party/zlib/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=agl@chromium.org

Change-Id: I1d226c45e473949a8af47311a6e089e5d9df10b4
Reviewed-on: https://chromium-review.googlesource.com/c/1392748
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619414}
[modify] https://crrev.com/7707f82395be87ca3524151c26d3dd2569fec043/third_party/zlib/google/compression_utils_unittest.cc

Comment 84 by bugdroid1@chromium.org, Jan 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2a2f8fab7fb2ad52a3508902cacb209ece8d04

commit cc2a2f8fab7fb2ad52a3508902cacb209ece8d04
Author: Avi Drissman <avi@chromium.org>
Date: Wed Jan 02 20:03:06 2019

Use base::size rather than arraysize in qcms's fuzzer.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=enne@chromium.org

Change-Id: I2a28091c571d44f8c828c3698d3dd4a7e6fac220
Reviewed-on: https://chromium-review.googlesource.com/c/1392747
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619470}
[modify] https://crrev.com/cc2a2f8fab7fb2ad52a3508902cacb209ece8d04/third_party/qcms/qcms_color_space_fuzzer.cc

Comment 85 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d729a52c458c1344f0fac1c29b1a01ca4264bae8

commit d729a52c458c1344f0fac1c29b1a01ca4264bae8
Author: Avi Drissman <avi@chromium.org>
Date: Thu Jan 03 17:47:09 2019

Use base::size rather than arraysize in url/ ipcs.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308

Change-Id: I85c15d42228d0e1c88f366af263d86dca15ba44e
Reviewed-on: https://chromium-review.googlesource.com/c/1390424
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619682}
[modify] https://crrev.com/d729a52c458c1344f0fac1c29b1a01ca4264bae8/url/ipc/url_param_traits_unittest.cc
[modify] https://crrev.com/d729a52c458c1344f0fac1c29b1a01ca4264bae8/url/mojom/url_gurl_mojom_traits_unittest.cc

Comment 86 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66

commit fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66
Author: Avi Drissman <avi@chromium.org>
Date: Thu Jan 03 22:10:21 2019

Update Crashpad to c8a016b99d97e2e5642fd7892b48a5ed0eb6d0d1

cc60f9329e54 Refactor PEImageAnnotationsReader test
760da9b96abf Delete snapshot/api/module_annotations_win*
60ff01287255 Change ProcessMemory to accept VMSizes
bcce07414385 Make crashpad support either PSAPI_VERSION 1 or 2
8f5d83b9e3cd Change ProcessMemoryRange to use VMSize
c8a016b99d97 Remove base's arraysize from Crashpad

Bug: chromium:837308, crashpad:270, chromium:584969
Change-Id: Idcf144be1fa83eabc4579cc7d58e55efe421f475
Reviewed-on: https://chromium-review.googlesource.com/c/1394012
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619776}
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/components/crash/content/app/BUILD.gn
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/README.chromium
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/client/crashpad_client_win_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/client/simulate_crash_mac.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/client/simulate_crash_mac_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/handler/mac/file_limit_annotation.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/handler/win/hanging_program.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_annotation_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_byte_array_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_exception_writer.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_file_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_memory_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_misc_info_writer.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_misc_info_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_module_crashpad_info_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_module_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_string_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_thread_id_map_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/minidump_writable.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/minidump/test/minidump_context_test_util.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/BUILD.gn
[delete] https://crrev.com/72c9e9b1973952ef2d8258f987322b2995f88ad1/third_party/crashpad/crashpad/snapshot/api/module_annotations_win.cc
[delete] https://crrev.com/72c9e9b1973952ef2d8258f987322b2995f88ad1/third_party/crashpad/crashpad/snapshot/api/module_annotations_win.h
[delete] https://crrev.com/72c9e9b1973952ef2d8258f987322b2995f88ad1/third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/cpu_context.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/cpu_context_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/fuchsia/memory_map_region_snapshot_fuchsia.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/mac/process_types.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/minidump/thread_snapshot_minidump.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/posix/timezone.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/posix/timezone_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/sanitized/sanitization_information_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/snapshot.gyp
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/test/test_cpu_context.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/win/cpu_context_win_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_image_reader.cc
[rename] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/win/pe_image_annotations_reader.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/win/pe_image_reader.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/win/pe_image_reader_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/win/process_reader_win_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/test/hex_string.h
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/test/hex_string_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/tools/crashpad_database_util.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/file/delimited_file_reader.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/file/delimited_file_reader_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/file/file_io_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/linux/direct_ptrace_connection.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/linux/proc_stat_reader.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/linux/ptrace_client.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mac/checked_mach_address_range_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mac/launchd_test.mm
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mac/xattr.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/child_port_handshake.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/child_port_server.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/composite_mach_message_server_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/exc_client_variants_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/exc_server_variants.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/exc_server_variants_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/exception_behaviors_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/exception_types_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/mach_message_server_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/mach_message_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/notify_server.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/symbolic_constants_mach.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/mach/symbolic_constants_mach_test.cc
[add] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/misc/arraysize.h
[rename] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/misc/arraysize_test.cc
[delete] https://crrev.com/72c9e9b1973952ef2d8258f987322b2995f88ad1/third_party/crashpad/crashpad/util/misc/arraysize_unsafe.h
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/misc/capture_context_test_util_win.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/misc/clock_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/misc/paths_win.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/misc/random_string_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/misc/uuid_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/net/http_transport_socket.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/net/http_transport_win.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/numeric/checked_range_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/posix/close_multiple.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/posix/close_stdio.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/posix/process_info_mac.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/posix/scoped_mmap_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/posix/signals.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/posix/signals_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/posix/symbolic_constants_posix.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/posix/symbolic_constants_posix_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/process/process_memory.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/process/process_memory.h
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/process/process_memory_range.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/process/process_memory_range.h
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/process/process_memory_range_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/stdlib/strlcpy_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/stdlib/thread_safe_vector_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/thread/thread_log_messages_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/thread/thread_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/util.gyp
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/util_test.gyp
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/win/command_line_test.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/win/get_module_information.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/win/get_module_information.h
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/win/ntstatus_logging.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/win/registration_protocol_win.cc
[modify] https://crrev.com/fa318207cc7cc3c53f18fd1981ea1bd5ac8cac66/third_party/crashpad/crashpad/util/win/safe_terminate_process_test.cc

Comment 87 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c02001b6b55026de15b4feb77ea11ac346c3ee0e

commit c02001b6b55026de15b4feb77ea11ac346c3ee0e
Author: Avi Drissman <avi@chromium.org>
Date: Fri Jan 04 18:35:14 2019

Use base::size rather than arraysize in third_party/libaddressinput/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=rouslan@chromium.org

Change-Id: I7d201f56e78f506f9f23da9cdb6944cb788ac62c
Reviewed-on: https://chromium-review.googlesource.com/c/1392746
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620005}
[modify] https://crrev.com/c02001b6b55026de15b4feb77ea11ac346c3ee0e/third_party/libaddressinput/chromium/addressinput_util.cc

Comment 89 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b70bf5026e868c5709fb4e89f8d43e49cd7960

commit e3b70bf5026e868c5709fb4e89f8d43e49cd7960
Author: Avi Drissman <avi@chromium.org>
Date: Fri Jan 04 19:50:22 2019

Use base::size rather than arraysize in base/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308

Change-Id: Id02b2c0bf9efcbdbefe2f8a3278bca90d167a85d
Reviewed-on: https://chromium-review.googlesource.com/c/1390906
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620036}
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/android/jni_array_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/command_line.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/command_line_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/containers/linked_list_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/containers/span_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/cpu.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/debug/alias.h
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/debug/debugger_posix.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/debug/proc_maps_linux_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/feature_list_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/file_version_info_win.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/file_path.h
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/file_path_constants.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/file_path_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/file_path_watcher_fsevents.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/file_proxy_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/file_util_posix.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/file_util_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/file_util_win.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/files/important_file_writer.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/i18n/bidi_line_iterator_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/i18n/break_iterator_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/i18n/build_utf8_validator_tables.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/i18n/file_util_icu_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/i18n/icu_string_conversions_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/i18n/rtl.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/i18n/streaming_utf8_validator_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/ios/ios_util.mm
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/json/json_parser_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/json/json_reader_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/json/string_escape_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/logging.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/mac/authorization_util.mm
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/mac/foundation_util.mm
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/mac/foundation_util_unittest.mm
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/mac/mac_util_unittest.mm
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/mac/os_crash_dumps.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/memory/ref_counted_memory_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/memory/shared_memory_helper.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/memory/shared_memory_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/message_loop/message_pump_mac.mm
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/metrics/field_trial_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/metrics/metrics_hashes_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/metrics/sparse_histogram_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/pickle_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/process/memory_win.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/process/process_handle_freebsd.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/process/process_handle_openbsd.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/process/process_iterator_freebsd.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/process/process_iterator_mac.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/process/process_iterator_openbsd.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/process/process_metrics_openbsd.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/strings/string_number_conversions_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/strings/string_util.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/strings/string_util_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/strings/stringprintf.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/strings/utf_offset_string_conversions_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/strings/utf_string_conversions_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/sync_socket_win.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/system/sys_info_chromeos.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/system/sys_info_ios.mm
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/system/sys_info_mac.mm
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/system/sys_info_openbsd.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/threading/platform_thread_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/threading/sequence_local_storage_slot_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/time/pr_time_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/time/time_mac.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/time/time_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/timer/timer_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/trace_event/heap_profiler_allocation_context_tracker.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/values.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/vlog.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/win/event_trace_consumer_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/win/i18n.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/win/registry.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/win/registry_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/win/scoped_bstr_unittest.cc
[modify] https://crrev.com/e3b70bf5026e868c5709fb4e89f8d43e49cd7960/base/win/shortcut_unittest.cc

Comment 90 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/cc166d71f48ff45fb9d171920ee9ca92b4ec0957

commit cc166d71f48ff45fb9d171920ee9ca92b4ec0957
Author: Mark Mentovai <mark@chromium.org>
Date: Fri Jan 04 22:42:57 2019

Use base::size where appropriate, and ArraySize elsewhere

This is a follow-up to c8a016b99d97, following the post-landing
discussion at
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7

base::size, and std::size that will eventually replace it when C++17 is
assured, does not allow the size of non-static data members to be taken
in constant expression context. The remaining uses of ArraySize are in:

minidump/minidump_exception_writer.cc (×1)
minidump/minidump_system_info_writer.cc (×2, also uses base::size)
snapshot/cpu_context.cc (×4, also uses base::size)
util/misc/arraysize_test.cc (×10, of course)

The first of these occurs when initializing a constexpr variable. All
others are in expressions used with static_assert.

Includes:
Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao

f701716d9546 Add Windows ARM64 build target to mini_chromium
87a95a3d6ac2 Remove the arraysize macro
1f7255ead1f7 Placate MSVC in areas of base::size usage
737433ebade4 Add cast

Bug: chromium:837308
Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19
Reviewed-on: https://chromium-review.googlesource.com/c/1396108
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/DEPS
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/client/crash_report_database_mac.mm
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/client/simulate_crash_mac.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/client/simulate_crash_mac_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/handler/mac/file_limit_annotation.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/handler/win/crashy_test_program.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/handler/win/hanging_program.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_annotation_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_byte_array_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_exception_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_file_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_memory_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_misc_info_writer.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_misc_info_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_module_crashpad_info_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_module_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_rva_list_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_string_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_thread_id_map_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_thread_writer_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/minidump_writable.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/minidump/test/minidump_context_test_util.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/capture_memory.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/cpu_context.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/cpu_context_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/fuchsia/memory_map_region_snapshot_fuchsia.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/fuchsia/process_snapshot_fuchsia_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/linux/exception_snapshot_linux_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/mac/mach_o_image_segment_reader_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/mac/process_reader_mac_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/mac/process_types.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/minidump/process_snapshot_minidump_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/minidump/thread_snapshot_minidump.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/posix/timezone.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/posix/timezone_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/sanitized/sanitization_information_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/test/test_cpu_context.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/win/cpu_context_win_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/win/crashpad_snapshot_test_image_reader.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/win/pe_image_annotations_reader.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/win/pe_image_reader.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/win/process_reader_win_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/snapshot/win/process_snapshot_win.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/test/hex_string.h
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/test/hex_string_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/tools/crashpad_database_util.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/file/delimited_file_reader.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/file/delimited_file_reader_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/file/file_io_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/linux/direct_ptrace_connection.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/linux/proc_stat_reader.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/linux/ptrace_client.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mac/checked_mach_address_range_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mac/launchd_test.mm
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/child_port_handshake.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/child_port_server.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/composite_mach_message_server_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/exc_client_variants_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/exc_server_variants.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/exc_server_variants_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/exception_behaviors_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/exception_types_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/mach_message_server_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/notify_server.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/symbolic_constants_mach.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/mach/symbolic_constants_mach_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/misc/arraysize.h
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/misc/capture_context_test_util_win.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/misc/clock_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/misc/paths_win.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/misc/random_string_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/misc/uuid_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/net/http_transport_socket.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/net/http_transport_win.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/numeric/checked_address_range_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/numeric/checked_range_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/posix/close_multiple.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/posix/process_info_mac.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/posix/scoped_mmap_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/posix/signals.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/posix/signals_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/posix/symbolic_constants_posix.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/posix/symbolic_constants_posix_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/process/process_memory_range_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/stdlib/string_number_conversion_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/stdlib/strlcpy_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/stdlib/thread_safe_vector_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/synchronization/semaphore_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/thread/thread_log_messages_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/win/command_line_test.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/win/exception_handler_server.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/win/ntstatus_logging.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/win/registration_protocol_win.cc
[modify] https://crrev.com/cc166d71f48ff45fb9d171920ee9ca92b4ec0957/util/win/safe_terminate_process_test.cc

Comment 91 by bugdroid1@chromium.org, Jan 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b18a3d4326875229de5301a1d7439dea52d846d

commit 9b18a3d4326875229de5301a1d7439dea52d846d
Author: Avi Drissman <avi@chromium.org>
Date: Sat Jan 05 01:35:10 2019

Use base::size and std::extent rather than arraysize in chrome/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=thakis@chromium.org

Change-Id: I3246cd4e8c500e9b5cf1192a381d349ef60263fa
Reviewed-on: https://chromium-review.googlesource.com/c/1391953
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620145}
[modify] https://crrev.com/9b18a3d4326875229de5301a1d7439dea52d846d/chrome/browser/conflicts/module_blacklist_cache_util_win.cc
[modify] https://crrev.com/9b18a3d4326875229de5301a1d7439dea52d846d/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc
[modify] https://crrev.com/9b18a3d4326875229de5301a1d7439dea52d846d/chrome/elevation_service/service_main.cc
[modify] https://crrev.com/9b18a3d4326875229de5301a1d7439dea52d846d/chrome/notification_helper/com_server_module.cc

Comment 92 by bugdroid1@chromium.org, Jan 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ecebb2651ead2f17555fb98328aae9e85ba67b0

commit 7ecebb2651ead2f17555fb98328aae9e85ba67b0
Author: Avi Drissman <avi@chromium.org>
Date: Sat Jan 05 02:37:19 2019

Use base::size rather than arraysize in ui/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308

Change-Id: I387e328cbcb7d51342bfa3736a06d7a12e292e0f
Reviewed-on: https://chromium-review.googlesource.com/c/1391710
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620160}
[modify] https://crrev.com/7ecebb2651ead2f17555fb98328aae9e85ba67b0/ui/events/ozone/evdev/event_device_info.cc
[modify] https://crrev.com/7ecebb2651ead2f17555fb98328aae9e85ba67b0/ui/gfx/nine_image_painter.cc

Comment 93 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfab7a3df6f5040cf0a79ebf2fc19edf7925ef78

commit dfab7a3df6f5040cf0a79ebf2fc19edf7925ef78
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jan 08 04:52:16 2019

Use base::size rather than arraysize in third_party/zlib/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=agl@chromium.org

Change-Id: I4505d29594dba38102d90f07276afb3828fcf995
Reviewed-on: https://chromium-review.googlesource.com/c/1399517
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620624}
[modify] https://crrev.com/dfab7a3df6f5040cf0a79ebf2fc19edf7925ef78/third_party/zlib/google/zip_reader_unittest.cc

Comment 94 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/da90c53e3db0b4d0da541d57475984cbf76799ed

commit da90c53e3db0b4d0da541d57475984cbf76799ed
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jan 08 15:57:21 2019

Update cpplint.

Using base/std::size and std::extent does not result in the creation
of a VLA; cpplint should not warn on their use.

BUG=837308

Change-Id: Ie133b2144b6c1c9f4f5e406144f28b333a212197
Reviewed-on: https://chromium-review.googlesource.com/c/1399961
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>

[modify] https://crrev.com/da90c53e3db0b4d0da541d57475984cbf76799ed/cpplint.py

Comment 95 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20be5c46714a2ffb599543d3372cbebd4e206fef

commit 20be5c46714a2ffb599543d3372cbebd4e206fef
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jan 08 16:12:25 2019

Use std::extent rather than arraysize in the VR API.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=vollick@chromium.org

Change-Id: I557797032e6b94217fe580a421524ae469f1b506
Reviewed-on: https://chromium-review.googlesource.com/c/1399455
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620745}
[modify] https://crrev.com/20be5c46714a2ffb599543d3372cbebd4e206fef/third_party/gvr-android-sdk/README.chromium
[modify] https://crrev.com/20be5c46714a2ffb599543d3372cbebd4e206fef/third_party/gvr-android-sdk/display_synchronizer_jni.h
[modify] https://crrev.com/20be5c46714a2ffb599543d3372cbebd4e206fef/third_party/gvr-android-sdk/gvr_api_jni.h
[modify] https://crrev.com/20be5c46714a2ffb599543d3372cbebd4e206fef/third_party/gvr-android-sdk/native_callbacks_jni.h

Comment 96 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e0395dde89b28661ed44e3831fcb216e3a845dd

commit 9e0395dde89b28661ed44e3831fcb216e3a845dd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 08 17:27:57 2019

Roll src/third_party/depot_tools d16b51b9bf17..da90c53e3db0 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d16b51b9bf17..da90c53e3db0


git log d16b51b9bf17..da90c53e3db0 --date=short --no-merges --format='%ad %ae %s'
2019-01-08 avi@chromium.org Update cpplint.


Created with:
  gclient setdep -r src/third_party/depot_tools@da90c53e3db0

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:837308
TBR=agable@chromium.org

Change-Id: I4988f4ab9ba26273b6abdeb0df929bc42fc64616
Reviewed-on: https://chromium-review.googlesource.com/c/1400965
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#620777}
[modify] https://crrev.com/9e0395dde89b28661ed44e3831fcb216e3a845dd/DEPS

Comment 97 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5d564663ada3cd0ea5340179010dcc7824a2b17

commit e5d564663ada3cd0ea5340179010dcc7824a2b17
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jan 08 20:28:57 2019

Use base::size rather than arraysize in base/android/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=nyquist@chromium.org

Change-Id: I13fdbed6c1b3ccddc02b7e1529c209ab45c3dd8c
Reviewed-on: https://chromium-review.googlesource.com/c/1399741
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620860}
[modify] https://crrev.com/e5d564663ada3cd0ea5340179010dcc7824a2b17/base/android/jni_generator/golden/testInnerClassNativesBothInnerAndOuterRegistrations.golden
[modify] https://crrev.com/e5d564663ada3cd0ea5340179010dcc7824a2b17/base/android/jni_generator/golden/testNativesRegistrations.golden
[modify] https://crrev.com/e5d564663ada3cd0ea5340179010dcc7824a2b17/base/android/jni_generator/golden/testProxyNativesMainDex.golden
[modify] https://crrev.com/e5d564663ada3cd0ea5340179010dcc7824a2b17/base/android/jni_generator/golden/testProxyNativesMainDexAndNonMainDex.golden
[modify] https://crrev.com/e5d564663ada3cd0ea5340179010dcc7824a2b17/base/android/jni_generator/golden/testProxyNativesRegistrations.golden
[modify] https://crrev.com/e5d564663ada3cd0ea5340179010dcc7824a2b17/base/android/jni_generator/jni_registration_generator.py

Comment 98 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3ee0b02475e5845f2404e707fb2f197410ca873

commit f3ee0b02475e5845f2404e707fb2f197410ca873
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jan 08 20:39:29 2019

Use base::size and std::extent rather than arraysize in net/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=eroman@chromium.org

Change-Id: I4c13761c26f91f9950b1f058b105fd248b3cc70e
Reviewed-on: https://chromium-review.googlesource.com/c/1399456
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620864}
[modify] https://crrev.com/f3ee0b02475e5845f2404e707fb2f197410ca873/net/disk_cache/simple/simple_entry_impl.cc
[modify] https://crrev.com/f3ee0b02475e5845f2404e707fb2f197410ca873/net/dns/dns_config_service_posix.cc
[modify] https://crrev.com/f3ee0b02475e5845f2404e707fb2f197410ca873/net/third_party/quic/test_tools/quic_stream_id_manager_peer.h

Comment 99 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/4157ba1c3c7a78d10887b50fbeda06f1bfb34860

commit 4157ba1c3c7a78d10887b50fbeda06f1bfb34860
Author: Avi Drissman <avi@chromium.org>
Date: Wed Jan 09 14:18:07 2019

Update cpplint.

da90c53e3db0b4d0da541d57475984cbf76799ed was incorrect; the size()
functions take almost anything, not just word characters, and
std::extent() uses brackets.

BUG=837308

Change-Id: I6ee75a5da7a021758bbfb0996aeaef81f2003cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1401581
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>

[modify] https://crrev.com/4157ba1c3c7a78d10887b50fbeda06f1bfb34860/cpplint.py

Comment 100 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90af3c177a9168daa429277d34533a381ea4e257

commit 90af3c177a9168daa429277d34533a381ea4e257
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 09 15:54:52 2019

Roll src/third_party/depot_tools 9d5b4682792f..4157ba1c3c7a (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9d5b4682792f..4157ba1c3c7a


git log 9d5b4682792f..4157ba1c3c7a --date=short --no-merges --format='%ad %ae %s'
2019-01-09 avi@chromium.org Update cpplint.


Created with:
  gclient setdep -r src/third_party/depot_tools@4157ba1c3c7a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:837308
TBR=agable@chromium.org

Change-Id: Id27da2e41f71377f877ae5f56d24bcd5703bb81e
Reviewed-on: https://chromium-review.googlesource.com/c/1403194
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#621158}
[modify] https://crrev.com/90af3c177a9168daa429277d34533a381ea4e257/DEPS

Comment 101 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/650c3b0d66883d79c4e628824c011468a2f09cc1

commit 650c3b0d66883d79c4e628824c011468a2f09cc1
Author: Avi Drissman <avi@chromium.org>
Date: Wed Jan 09 22:59:26 2019

Use base::size and std::extent rather than arraysize in components/.

This is purely a mechanical change; there is no intended behavior change.

BUG=837308

Change-Id: I62d090f0b976feedc9df2606076031969aca8c15
Reviewed-on: https://chromium-review.googlesource.com/c/1399520
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621354}
[modify] https://crrev.com/650c3b0d66883d79c4e628824c011468a2f09cc1/components/base32/BUILD.gn
[modify] https://crrev.com/650c3b0d66883d79c4e628824c011468a2f09cc1/components/base32/base32_unittest.cc
[modify] https://crrev.com/650c3b0d66883d79c4e628824c011468a2f09cc1/components/policy/tools/generate_policy_source.py
[modify] https://crrev.com/650c3b0d66883d79c4e628824c011468a2f09cc1/components/sync/base/unique_position_unittest.cc
[modify] https://crrev.com/650c3b0d66883d79c4e628824c011468a2f09cc1/components/vector_icons/aggregate_vector_icons.py

Comment 102 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1626bedbfe0d3a5b4f35104eb6ed6ed2d3c79b15

commit 1626bedbfe0d3a5b4f35104eb6ed6ed2d3c79b15
Author: Avi Drissman <avi@chromium.org>
Date: Thu Jan 10 16:26:43 2019

One last bit of base::size cleanup.

BUG=837308

Change-Id: I7ff4ac0d0d6399daac1f934a85924e0817017680
Reviewed-on: https://chromium-review.googlesource.com/c/1404703
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621594}
[modify] https://crrev.com/1626bedbfe0d3a5b4f35104eb6ed6ed2d3c79b15/components/sync/base/unique_position_unittest.cc

Comment 103 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b4cbab5a982e00ad473494d1c4e953046b607b

commit 72b4cbab5a982e00ad473494d1c4e953046b607b
Author: Avi Drissman <avi@chromium.org>
Date: Thu Jan 10 21:54:23 2019

Remove arraysize.

BUG=837308

Change-Id: I91071794afd9915486548196ae09831c7093664b
Reviewed-on: https://chromium-review.googlesource.com/c/1390417
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621760}
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/PRESUBMIT.py
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/debug/stack_trace.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/debug/stack_trace_android.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/debug/stack_trace_fuchsia.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/debug/stack_trace_posix.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/debug/stack_trace_win.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/i18n/utf8_validator_tables.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/macros.h
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/task/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/base/task/task_scheduler/task_scheduler_impl.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/chrome/app/nibs/generate_localizer.py
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/chrome/browser/ui/cocoa/ui_localizer.mm
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/chrome_elf/nt_registry/nt_registry_unittest.cc
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/mojo/core/ports/user_message.h
[modify] https://crrev.com/72b4cbab5a982e00ad473494d1c4e953046b607b/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc

Comment 104 by a...@chromium.org, Jan 10

Status: Fixed (was: Assigned)
Showing comments 5 - 104 of 104 Older

Sign in to add a comment