New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837292 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Arc Usb permission does not persist

Project Member Reported by lgcheng@google.com, Apr 26 2018

Issue description

Arc Usb granted permission does not persist after reboot.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cc08b02c472f6c081c47270b7f94a478120fe23

commit 3cc08b02c472f6c081c47270b7f94a478120fe23
Author: lgcheng <lgcheng@google.com>
Date: Fri Apr 27 21:23:49 2018

Restore Arc Usb permission correctly.

Arc usb permission are not restores correctly. When detecting a
non-matching package, we should skip rather than abort.

Bug:  837292 
Test: Manual test with reboot.
Change-Id: Id66156dcee36873f8afccaab5a619bafffd3721a
Reviewed-on: https://chromium-review.googlesource.com/1030785
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554513}
[modify] https://crrev.com/3cc08b02c472f6c081c47270b7f94a478120fe23/chrome/browser/ui/app_list/arc/arc_usb_host_permission_manager.cc

Comment 2 by lgcheng@google.com, Apr 27 2018

Labels: Merge-Request-67
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 28 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cindyb@chromium.org, Apr 30 2018

Is this a new bug introduced with M67 and please provide testing information. Thanks.

Comment 5 by lgcheng@google.com, Apr 30 2018

This is introduced by:
https://bugs.chromium.org/p/chromium/issues/detail?id=776476

Bug found by first party consumer that permission is not granted after reboot.
Tested with crafted test app, that permission can persist after reboot. 

Comment 6 by lgcheng@google.com, Apr 30 2018

Cc: kbleicher@chromium.org
Note that cindyb@ is shadowing M67.  I see the bug sans the cc per a search :-). 

This appears to be a fairly old issue (M64).   Limiting merges for M67 regressions at this point.  

Is #5 a confirmed test pass?  Not clear.

Comment 8 by lgcheng@google.com, May 1 2018

Re#7 yeah. This is a corner case fix.
Labels: -Merge-Review-67 Merge-Rejected-67
I'm going to reject since due to the age.  Better to limit M67 changes at this point.  Re-request if that escalates.
Cc: elijahtaylor@chromium.org
Labels: -Merge-Rejected-67 Merge-Request-67
This feature currently has very limit impact to ChromeOS since it's hidden API. 

And only one of our first party developer are using it in M67. But it's important to their launch schedule.

Please re-evaluate. 
Please also take a look at merge request at https://b.corp.google.com/issues/78231419
Project Member

Comment 11 by sheriffbot@chromium.org, May 1 2018

Labels: -Merge-Request-67 Merge-Review-67
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
FYI, b/78231419 was hidden from TPMs due to incorrect hotlist usaged; I commented as such on that bug.

See comments on that bug re: testing
Labels: Merge-Approved-67
Details provided in b/78231419. Merge approved, M67.
Project Member

Comment 14 by bugdroid1@chromium.org, May 4 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69ce4c57d92de29dc91e878502ca4c2e6fffd4d

commit c69ce4c57d92de29dc91e878502ca4c2e6fffd4d
Author: lgcheng <lgcheng@google.com>
Date: Fri May 04 16:43:56 2018

Restore Arc Usb permission correctly.

Arc usb permission are not restores correctly. When detecting a
non-matching package, we should skip rather than abort.

TBR=khmel@chromium.org

Bug:  837292 
Test: Manual test with reboot.
Change-Id: Id66156dcee36873f8afccaab5a619bafffd3721a
Reviewed-on: https://chromium-review.googlesource.com/1030785
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554513}(cherry picked from commit 3cc08b02c472f6c081c47270b7f94a478120fe23)
Reviewed-on: https://chromium-review.googlesource.com/1033456
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/branch-heads/3396@{#477}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/c69ce4c57d92de29dc91e878502ca4c2e6fffd4d/chrome/browser/ui/app_list/arc/arc_usb_host_permission_manager.cc

Status: Fixed (was: Started)
Labels: Merge-Merged
Labels: -Merge-Review-67
Project Member

Comment 18 by sheriffbot@chromium.org, May 8 2018

Cc: cindyb@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-67

Sign in to add a comment