Issue metadata
Sign in to add a comment
|
SVG appearing outside IMG bounds disappears when printed |
||||||||||||||||||||||
Issue descriptionA skia fix for issue 770032 and issue 772685 appears to have broken content in a different way Steps to reproduce the problem: 1. Save the files locally 2. Open booklet.html 3. Observe that the image is contained in its bounding box 4. Print - make sure Save as PDF is selected hat is the expected behavior? Print matches screen - the image is contained in its bounding box What went wrong? Parts of the SVG image which are clipped within the SVG itself - and occur outside the image bounds - no longer appear in print preview. I bisected the change in behavior (from bad to... also bad) to https://chromium.googlesource.com/chromium/src/+log/abc55490658e0ec0bf2be019449b7248b923ce90..45cabf37885e82ddfa0fbe9d76f6ec2996d2342d which includes the skia roll: https://chromium.googlesource.com/chromium/src/+/dadab4dd963f914bde1b4019f835b9c0c5c895be Attached images 542287.png and 542297.png show before/after behavior. (Note that neither is correct) Marking as Regression although I'm not sure the new-bad behavior is strictly worse.
,
Apr 26 2018
,
Apr 26 2018
,
Jun 5 2018
,
Jun 5 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/d00ef066198b40aa0b02603fe4766b31996eb835 commit d00ef066198b40aa0b02603fe4766b31996eb835 Author: Hal Canary <halcanary@google.com> Date: Tue Jun 05 17:36:29 2018 SkPDF: Fastpath for clipstack flattening BUG: chromium:837279 Change-Id: I79a675e7d9e713617711948e491e28babe06b1a2 Reviewed-on: https://skia-review.googlesource.com/132092 Auto-Submit: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> [modify] https://crrev.com/d00ef066198b40aa0b02603fe4766b31996eb835/src/pdf/SkPDFDevice.cpp
,
Jun 12 2018
Confirmed, appears to work correctly in a local build of Chrome at ToT at r566606 (which includes a skia roll to 8e4d09ae7af123eb3441bef8e39492c2cebfbfbb, much later than the above rev)
,
Today
(19 hours ago)
A (much delayed) thanks for fixing this! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jsb...@chromium.org
, Apr 26 2018