[MacViewsBrowser] Dropdown button stroke is too light |
|||||||
Issue descriptionChrome Version: 68.0.3406.0 OS: macOS 10.13 What steps will reproduce the problem? (1) Bring up the Bookmarks dialog What is the expected result? The dropdown button stroke should have the same color/thickness as the other buttons like More.... What happens instead? The dropdown button stroke is much lighter than the other buttons.
,
Apr 28 2018
Assigning to ellyjones for initial assessment.
,
Apr 30 2018
Yeah, we should maybe think about darkening it a bit. I'll follow up with bettes@.
,
Apr 30 2018
Oh, there's actually a bug in the MacViews code which is causing it *not* to use the Aura color. Easy fix. https://chromium-review.googlesource.com/c/chromium/src/+/1035107
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43d9d332843d529ceef39d73f5b4d47d3536c308 commit 43d9d332843d529ceef39d73f5b4d47d3536c308 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Apr 30 20:06:53 2018 macviews: use Aura unfocused border color The Mac unfocused border color is far lighter and looks wrong in the MacViews Harmony UI surfaces. Bug: 837278 Change-Id: I98807cf565e30f51ddc5486c3cc00b8cf6ae5c74 Reviewed-on: https://chromium-review.googlesource.com/1035107 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#554856} [modify] https://crrev.com/43d9d332843d529ceef39d73f5b4d47d3536c308/ui/native_theme/native_theme_mac.mm
,
Apr 30 2018
,
May 2 2018
Able to reproduce this issue on Mac OS 10.12.6 on the build without fix 68.0.3410.0 and the issue is fixed on the latest Canary 68.0.3417.0. By enabling #views-browser-windows flag, can observe that the bookmarks dialogue is having the same color/thickness as the other buttons. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
May 4 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by shrike@chromium.org
, Apr 26 2018