The first zip-selection command silently fails after sign in |
||||||||||
Issue descriptionChrome Version: 68.0.3410.0 (85eedfe0c) Chrome OS Version: 10611.0.0 Chrome OS Platform: any Steps To Reproduce: (1) Sign in with a regular user (2) Open a folder containing a file (or create a new folder to be zipped) (3) Right-click a file and click "zip selection" Expected Result: The file is zipped and a zip file is generated. (e.g. if the file were "IMG_00001.JPG", it will create IMG_00001.zip by default.) Notification shows zipping progress. Actual Result: Nothing happens. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) What is the impact to the user, and is there a workaround? If so, what is it? If user try again, it successfully generates a zip. Please provide any additional information below. Attach a screen shot or log if possible. This doesn't happen in the guest mode. I think this is related to https://chromium-review.googlesource.com/1018624
,
Apr 28 2018
The patch will take effect at 68.0.12.0. We can test on canary when the version is available. The patch should be merged after merging https://chromium-review.googlesource.com/1018624 (Isssue 834675).
,
Apr 28 2018
> The patch will take effect at 68.0.12.0. We can test on canary when the version is available. The correct version number is 68.0.3412.0.
,
Apr 28 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 30 2018
Is this a M67 regression? Why merge with M67 when found in M68? Testing is required for merge approval.
,
Apr 30 2018
This will happen on M67 as we fix issue 834675 on M67. The other fix we need for Issue 834675 on M67 causes this issue. However that can be resolved by merging this patch. We can test the both on canary now.
,
May 1 2018
songsuk@: Will you also verify this along with the test for Issue 833603 ? https://bugs.chromium.org/p/chromium/issues/detail?id=833603#c16
,
May 1 2018
Verified the fix on 68.0.3416.0/10635.0.0 (Canary)- Candy.
,
May 1 2018
Approving merge to M67 Chrome OS.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a7d85d899f574b94edce993fa4365578d7ac4fd commit 1a7d85d899f574b94edce993fa4365578d7ac4fd Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Wed May 02 01:16:47 2018 Zip Archiver: Catch the first onLaunched event after loading. When the app was unloaded, it seems loaded right before sending the onLaunched event. Therefore asynchronously adding the listener will miss the first event, being unable to respond for the user action in this case. https://developer.chrome.com/apps/app_lifecycle The issue was introduced by: https://chromium-review.googlesource.com/c/chromium/src/+/1018624 Bug: 837251 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d613f9e877a39b3db0e92919a83d05bc45a0e06 Reviewed-on: https://chromium-review.googlesource.com/1031752 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554317}(cherry picked from commit ff9926c746fcd530bb3768c9abb6132d96a33bc4) Reviewed-on: https://chromium-review.googlesource.com/1039043 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#435} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/1a7d85d899f574b94edce993fa4365578d7ac4fd/chrome/browser/resources/chromeos/zip_archiver/js/background.js
,
May 2 2018
,
May 11 2018
Verified the fix in 67.0.3396.41/0575.32.0 (Candy), 67.0.3396.42/0575.34.0 - Monroe |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 27 2018