New issue
Advanced search Search tips

Issue 837248 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Q2



Sign in to add a comment

NTPHomeTestCase/testOmniboxPinnedWidthRotation fails on bijou-simulator

Project Member Reported by olivierrobin@chromium.org, Apr 26 2018

Issue description

NTPHomeTestCase/testOmniboxPinnedWidthRotation:
../../ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm:273: error: -[NTPHomeTestCase testOmniboxPinnedWidthRotation] : Exception: AssertionFailedException
Exception Name: AssertionFailedException
Exception Reason: An assertion failed.
Exception with Assertion: {
  "Assertion Criteria" : "assertWithMatcher:Omnibox has correct width: 813 with margin: 2",
  "Element Matcher" : "(respondsToSelector(accessibilityIdentifier) && accessibilityID('NTPHomeFakeOmniboxAccessibilityID'))"
}
Exception Details: Error Trace: [
  {
    "Description" : "Assertion with matcher [M] failed: UI element [E] failed to match the following matcher(s): [S]",
    "Description Glossary" :     {
      "M" : "Omnibox has correct width: 813 with margin: 2",
      "E" : "<UIButton:0x7f9c5ddc41b0; AX=N; AX.id='NTPHomeFakeOmniboxAccessibilityID'; AX.frame={{190, 30.666666666666657}, {432, 49.666666666666657}}; AX.activationPoint={406, 55.499999999999986}; AX.traits='UIAccessibilityTraitButton'; AX.focused='N'; frame={{190, 200.66666666666666}, {432, 49.666666666666664}}; alpha=1>",
      "S" : "Omnibox has correct width: 813 with margin: 2"
    },
    "Error Domain" : "com.google.earlgrey.ElementInteractionErrorDomain",
    "Error Code" : "3",
    "File Name" : "GREYAssertions.m",
    "Function Name" : "+[GREYAssertions grey_createAssertionWithMatcher:]_block_invoke",
    "Line" : "75",
    "TestCase Class" : "NTPHomeTestCase",
    "TestCase Method" : "testOmniboxPinnedWidthRotation"
  }
]
Bundle ID: com.google.gtest.ios-chrome-ui-egtests
 
Labels: MS-New-Tab Q2
Owner: justincohen@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1565765370b4193f2ab829de00e893e505a44fcc

commit 1565765370b4193f2ab829de00e893e505a44fcc
Author: Justin Cohen <justincohen@google.com>
Date: Thu Apr 26 15:56:13 2018

[ios] Followup to NTP contentInset.bottom changes.

Bug:  837248 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If01a46f95b979a5069895e6135adc4203216817b
Reviewed-on: https://chromium-review.googlesource.com/1030060
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554042}
[modify] https://crrev.com/1565765370b4193f2ab829de00e893e505a44fcc/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
[modify] https://crrev.com/1565765370b4193f2ab829de00e893e505a44fcc/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm
[modify] https://crrev.com/1565765370b4193f2ab829de00e893e505a44fcc/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

Status: Fixed (was: Started)
Labels: Proj-UIRefresh

Sign in to add a comment