New issue
Advanced search Search tips

Issue 837236 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

IndependentOTRProfileManagerTest.BrowserClosingDoesntRemoveProfileObserver is flaky on Mac

Project Member Reported by maxmorin@chromium.org, Apr 26 2018

Issue description

Probably related to  issue 835834 ?

Example build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/12323

[ RUN      ] IndependentOTRProfileManagerTest.BrowserClosingDoesntRemoveProfileObserver
[27662:4611:0426/062120.857183:WARNING:notification_platform_bridge_mac.mm(509)] AlertNotificationService: XPC connection invalidated.
[27662:775:0426/062121.179901:ERROR:render_widget_host_view_base.cc(159)] Not implemented reached in virtual uint32_t content::RenderWidgetHostViewBase::GetCaptureSequenceNumber() const
../../chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc:303: Failure
Value of: base::ContainsValue(*BrowserList::GetInstance(), otr_browser)
  Actual: true
Expected: false
Stack trace:
0   browser_tests                       0x000000010c41d05b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   browser_tests                       0x000000010c41ca19 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   browser_tests                       0x000000010b1e0547 IndependentOTRProfileManagerTest_BrowserClosingDoesntRemoveProfileObserver_Test::RunTestOnMainThread() + 1351
3   browser_tests                       0x000000010e820bf3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 515
4   browser_tests                       0x000000010e345789 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4233
5   browser_tests                       0x000000010e3445fe ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
6   browser_tests                       0x000000010ce9ce33 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
7   browser_tests                       0x000000010d24cf07 content::StartupTaskRunner::RunAllTasksNow() + 39
8   browser_tests                       0x000000010ce9ba4d content::BrowserMainLoop::CreateStartupTasks() + 813
9   browser_tests                       0x000000010ce9f030 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96
10  browser_tests                       0x000000010ce99994 content::BrowserMain(content::MainFunctionParams const&) + 180
11  browser_tests                       0x000000010e188339 content::ContentMainRunnerImpl::Run() + 377
12  browser_tests                       0x000000010fe38072 service_manager::Main(service_manager::MainParams const&) + 2354
13  browser_tests                       0x000000010e187864 content::ContentMain(content::ContentMainParams const&) + 68
14  browser_tests                       0x000000010e82080e content::BrowserTestBase::SetUp() + 2574
15  browser_tests                       0x000000010e2cbe58 InProcessBrowserTest::SetUp() + 536
[27662:775:0426/062122.437266:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
BrowserTestBase received signal: Segmentation fault: 11. Backtrace:
0   browser_tests                       0x000000010e2961bc base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x000000010e820ed5 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229
2   libsystem_platform.dylib            0x00007fffc300db3a _sigtramp + 26
3   browser_tests                       0x0000000114280004 vtable for net::QuicSpdyServerStreamBase + 124
4   browser_tests                       0x000000010e4d3f01 TemplateURLServiceFactory::BuildServiceInstanceFor(content::BrowserContext*) const + 17
5   browser_tests                       0x000000011074a6f5 BrowserContextKeyedServiceFactory::BuildServiceInstanceFor(base::SupportsUserData*) const + 21
6   browser_tests                       0x000000010ffae6d5 KeyedServiceFactory::GetServiceForContext(base::SupportsUserData*, bool) + 229
7   browser_tests                       0x000000010e4d3c6e TemplateURLServiceFactory::GetForProfile(Profile*) + 30
8   browser_tests                       0x0000000110c74692 SearchProvider::~SearchProvider() + 66
9   browser_tests                       0x0000000110c7494e SearchProvider::~SearchProvider() + 14
10  browser_tests                       0x0000000110c3f822 AutocompleteController::~AutocompleteController() + 242
11  browser_tests                       0x0000000110c3f8ae AutocompleteController::~AutocompleteController() + 14
12  browser_tests                       0x0000000110c668ff OmniboxController::~OmniboxController() + 63
13  browser_tests                       0x0000000110c67074 OmniboxEditModel::~OmniboxEditModel() + 132
14  browser_tests                       0x0000000110c6710e OmniboxEditModel::~OmniboxEditModel() + 14
15  browser_tests                       0x0000000110f0b59e OmniboxViewMac::~OmniboxViewMac() + 14
16  browser_tests                       0x0000000110efdca3 LocationBarViewMac::~LocationBarViewMac() + 547
17  browser_tests                       0x0000000110efdede LocationBarViewMac::~LocationBarViewMac() + 14
18  browser_tests                       0x0000000110f3f8ab -[ToolbarController cleanUp] + 267
19  browser_tests                       0x0000000110ea6378 -[BrowserWindowController dealloc] + 216
20  Foundation                          0x00007fffaec84db4 __delayedPerformCleanup + 50
21  CoreFoundation                      0x00007fffad216186 CFRunLoopTimerInvalidate + 630
22  CoreFoundation                      0x00007fffad215aca __CFRunLoopDoTimer + 1130
23  CoreFoundation                      0x00007fffad2155ea __CFRunLoopDoTimers + 298
24  CoreFoundation                      0x00007fffad20cfc1 __CFRunLoopRun + 2081
25  CoreFoundation                      0x00007fffad20c544 CFRunLoopRunSpecific + 420
26  HIToolbox                           0x00007fffac76bebc RunCurrentEventLoopInMode + 240
27  HIToolbox                           0x00007fffac76bcf1 ReceiveNextEventCommon + 432
28  HIToolbox                           0x00007fffac76bb26 _BlockUntilNextEventMatchingListInModeWithFilter + 71
29  AppKit                              0x00007fffaad04a54 _DPSNextEvent + 1120
30  AppKit                              0x00007fffab4807ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796
31  browser_tests                       0x000000010e33f760 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64
32  browser_tests                       0x000000010e20127a base::mac::CallWithEHFrame(void () block_pointer) + 10
33  browser_tests                       0x000000010e33f694 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164
34  AppKit                              0x00007fffaacf93db -[NSApplication run] + 926
35  browser_tests                       0x000000010e2113ec base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364
36  browser_tests                       0x000000010e20ff0e base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110
37  browser_tests                       0x000000010e233e55 base::RunLoop::Run() + 53
38  browser_tests                       0x000000010e845259 content::RunAllPendingInMessageLoop() + 281
39  browser_tests                       0x000000010e2ccdf0 InProcessBrowserTest::PostRunTestOnMainThread() + 32
40  browser_tests                       0x000000010e820db3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 963
41  browser_tests                       0x000000010e345789 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4233
42  browser_tests                       0x000000010e3445fe ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
43  browser_tests                       0x000000010ce9ce33 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
44  browser_tests                       0x000000010d24cf07 content::StartupTaskRunner::RunAllTasksNow() + 39
45  browser_tests                       0x000000010ce9ba4d content::BrowserMainLoop::CreateStartupTasks() + 813
46  browser_tests                       0x000000010ce9f030 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96
47  browser_tests                       0x000000010ce99994 content::BrowserMain(content::MainFunctionParams const&) + 180
48  browser_tests                       0x000000010e188339 content::ContentMainRunnerImpl::Run() + 377
49  browser_tests                       0x000000010fe38072 service_manager::Main(service_manager::MainParams const&) + 2354
50  browser_tests                       0x000000010e187864 content::ContentMain(content::ContentMainParams const&) + 68
51  browser_tests                       0x000000010e82080e content::BrowserTestBase::SetUp() + 2574
52  browser_tests                       0x000000010e2cbe58 InProcessBrowserTest::SetUp() + 536
53  browser_tests                       0x000000010c42343d testing::Test::Run() + 109
54  browser_tests                       0x000000010c424080 testing::TestInfo::Run() + 304
55  browser_tests                       0x000000010c4245f7 testing::TestCase::Run() + 279
56  browser_tests                       0x000000010c42fc57 testing::internal::UnitTestImpl::RunAllTests() + 855
57  browser_tests                       0x000000010c42f8de testing::UnitTest::Run() + 110
58  browser_tests                       0x000000010e2e3ec7 base::TestSuite::Run() + 167
59  browser_tests                       0x000000010e1dfb55 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37
60  browser_tests                       0x000000010e841ac5 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 389
61  browser_tests                       0x000000010e1e003c LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 348

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0910c6de9eec91536841bf2f52115259ca59074

commit f0910c6de9eec91536841bf2f52115259ca59074
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Apr 26 14:14:29 2018

Disable flaky IndependentOTRProfileManagerTest

Bug:  837236 
Change-Id: Ie0852edee35515e5d5c1e7ccfded6454f85e94e6
Tbr: xidachen
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1030492
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554014}
[modify] https://crrev.com/f0910c6de9eec91536841bf2f52115259ca59074/chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc

Comment 2 by mfo...@chromium.org, Apr 26 2018

Components: -Internals>Cast Internals>Cast>Providers
Status: Assigned (was: Untriaged)
Brandon, can you take a look at this for M68? I seem to recall that the Mac code path for this might be a special case.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88ebf4f63a1960be3139ff3aea8045aeb40ea010

commit 88ebf4f63a1960be3139ff3aea8045aeb40ea010
Author: btolsch <btolsch@chromium.org>
Date: Mon Apr 30 21:13:23 2018

Wait for OnBrowserRemoved after closing window in tests

Some IndependentOTRProfileManager tests need to wait for a browser
window and its associated Browser object to be destroyed.  This was
originally done with base::RunLoop::RunUntilIdle, but this isn't
necessarily sufficient and may be a source of flakes on Mac.

Bug:  835834 ,  837236 
Change-Id: I8dfd71e45cea7df411693dbccb153f9554754809
Reviewed-on: https://chromium-review.googlesource.com/1034279
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554874}
[modify] https://crrev.com/88ebf4f63a1960be3139ff3aea8045aeb40ea010/chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc

Status: Fixed (was: Assigned)
Marking fixed after ~24 hours of clean bots.

Sign in to add a comment