New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837230 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MacViews: webview context menus should be MacViews menus

Project Member Reported by ellyjo...@chromium.org, Apr 26 2018

Issue description

Right now they're Cocoa menus and it looks weird.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b878d97c1be5685f677ea1d15d55c8a6c0219121

commit b878d97c1be5685f677ea1d15d55c8a6c0219121
Author: spqchan <spqchan@chromium.org>
Date: Tue May 15 16:00:31 2018

[MacViews] Use Views Context Menu for Web View

This CL refactors RenderViewContextMenuMac by moving
the logic to show a Cocoa menu into a
RenderViewContextMenuMacCocoa class.

To show the context menu using Views, this CL adds a
RenderViewContextMenuMacViews.

Bug:  837230 
Change-Id: Id07f9e758278638c6fc47003de1055d9357ed1fa
Reviewed-on: https://chromium-review.googlesource.com/1056468
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558726}
[modify] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h
[modify] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm
[add] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa.h
[add] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa.mm
[rename] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa_browsertest.mm
[add] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_views.h
[add] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_views.mm
[modify] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h
[modify] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm
[modify] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/chrome/test/BUILD.gn
[modify] https://crrev.com/b878d97c1be5685f677ea1d15d55c8a6c0219121/components/renderer_context_menu/views/toolkit_delegate_views.h

Components: UI>Browser
Status: Fixed (was: Started)

Sign in to add a comment