New issue
Advanced search Search tips

Issue 837229 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

MacViews: arrow keys should not wrap on menus

Project Member Reported by ellyjo...@chromium.org, Apr 26 2018

Issue description

Holding down the down arrow key in a Mac menu should not cycle back to the top of the menu.
 
Labels: Sprint-2
Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c51ff6498075dcc21e6d8b400eb69c67a9264ec

commit 7c51ff6498075dcc21e6d8b400eb69c67a9264ec
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon May 07 21:53:05 2018

macviews: don't wrap menu selection with arrow keys

This change causes arrowing upwards at the top of a menu, or arrowing downward
at the bottom of the menu, not to wrap around on Mac. It also adds a test
for this behavior.

This also moves and documents a helper in MenuConfig.

Bug:  837229 
Change-Id: Iad73206dcede3a742242754801588e6d6a96c18b
Reviewed-on: https://chromium-review.googlesource.com/1038323
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556579}
[modify] https://crrev.com/7c51ff6498075dcc21e6d8b400eb69c67a9264ec/ui/views/controls/menu/menu_config.cc
[modify] https://crrev.com/7c51ff6498075dcc21e6d8b400eb69c67a9264ec/ui/views/controls/menu/menu_config.h
[modify] https://crrev.com/7c51ff6498075dcc21e6d8b400eb69c67a9264ec/ui/views/controls/menu/menu_config_mac.mm
[modify] https://crrev.com/7c51ff6498075dcc21e6d8b400eb69c67a9264ec/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/7c51ff6498075dcc21e6d8b400eb69c67a9264ec/ui/views/controls/menu/menu_controller_unittest.cc

Pls mark bug as fixed if nothing else is pending. Thank you.
Status: Fixed (was: Assigned)

Sign in to add a comment