wptserve randomly throws 500 when {{sub}} is used |
||||||||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fhtml%2Fsemantics%2Fscripting-1%2Fthe-script-element%2Fmodule%2Fcrossorigin.html Example log: 04:53:03.484 10739 worker/0 starting 04:53:03.758 10739 "system_profiler SPDisplaysDataType" took 0.27s 04:53:05.080 10739 worker/0 external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin.html output stderr lines: 04:53:05.081 10739 04:53:05.081 10739 DevTools listening on ws://127.0.0.1:52731/devtools/browser/0c9b2857-7580-4b57-87c1-d912ef698f7a 04:53:05.081 10739 [11771:1299:0426/045304.650273:ERROR:render_widget_host_view_base.cc(159)] Not implemented reached in virtual uint32_t content::RenderWidgetHostViewBase::GetCaptureSequenceNumber() const 04:53:05.081 10739 [04:53:04.711] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTDecompressionSession.c line 1181 04:53:05.081 10739 <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1' 04:53:05.081 10739 04:53:05.081 10739 [04:53:04.785] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245 04:53:05.081 10739 [04:53:04.785] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTCompressionSession.c line 946 04:53:05.081 10739 CONSOLE ERROR: line 8: Uncaught ReferenceError: nonExistentMethod is not defined 04:53:05.081 10739 CONSOLE ERROR: Access to Script at 'http://www2.web-platform.test:8001/html/semantics/scripting-1/the-script-element/module/crossorigin-scripterror.js' from origin 'http://web-platform.test:8001' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://web-platform.test:8001' is therefore not allowed access. 04:53:05.081 10739 CONSOLE ERROR: Access to Script at 'http://www2.web-platform.test:8001/html/semantics/scripting-1/the-script-element/module/crossorigin-scripterror.js' from origin 'http://web-platform.test:8001' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://web-platform.test:8001' is therefore not allowed access. 04:53:05.081 10739 CONSOLE ERROR: Access to Script at 'http://www2.web-platform.test:8001/html/semantics/scripting-1/the-script-element/module/crossorigin-scripterror.js?pipe=header(Access-Control-Allow-Origin,http://www2.web-platform.test:8001)' from origin 'http://web-platform.test:8001' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'http://www2.web-platform.test:8001' that is not equal to the supplied origin. Origin 'http://web-platform.test:8001' is therefore not allowed access. 04:53:05.082 10739 CONSOLE ERROR: Access to Script at 'http://www2.web-platform.test:8001/html/semantics/scripting-1/the-script-element/module/crossorigin-scripterror.js' from origin 'http://web-platform.test:8001' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://web-platform.test:8001' is therefore not allowed access. 04:53:05.082 10739 CONSOLE ERROR: Access to Script at 'http://www2.web-platform.test:8001/html/semantics/scripting-1/the-script-element/module/crossorigin-scripterror.js' from origin 'http://web-platform.test:8001' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://web-platform.test:8001' is therefore not allowed access. 04:53:05.082 10739 CONSOLE ERROR: line 8: Uncaught ReferenceError: nonExistentMethod is not defined 04:53:05.082 10739 CONSOLE ERROR: Access to Script at 'http://www2.web-platform.test:8001/html/semantics/scripting-1/the-script-element/module/crossorigin-scripterror.js?pipe=header(Access-Control-Allow-Origin,http://www2.web-platform.test:8001)' from origin 'http://web-platform.test:8001' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'http://www2.web-platform.test:8001' that is not equal to the supplied origin. Origin 'http://web-platform.test:8001' is therefore not allowed access. 04:53:05.085 10739 [1/1] external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin.html failed unexpectedly (text diff) 04:53:05.085 10739 worker/0 external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin.html failed: 04:53:05.085 10739 worker/0 text diff
,
Apr 26 2018
possibly related to https://chromium.googlesource.com/chromium/src/+/79310a7243d9a2ba9ba0d225f9099fd436d8162f ?
,
Apr 26 2018
Reproduced locally:
GET html/semantics/scripting-1/the-script-element/module/crossorigin-import-same.sub.html sometimes returns 500, with the following traceback from wptserve:
list index out of range
Traceback (most recent call last):
File "/usr/local/google/home/robertma/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/server.py", line 256, in handle_one_request
handler(request, response)
File "/usr/local/google/home/robertma/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/handlers.py", line 151, in __call__
response = wrap_pipeline(path, request, response)
File "/usr/local/google/home/robertma/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/handlers.py", line 117, in wrap_pipeline
response = pipeline(request, response)
File "/usr/local/google/home/robertma/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/pipes.py", line 36, in __call__
response = func(request, response, *args)
File "/usr/local/google/home/robertma/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/pipes.py", line 129, in inner
return f(request, response, *arg_values)
File "/usr/local/google/home/robertma/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/pipes.py", line 375, in sub
new_content = template(request, content, escape_type=escape_type)
File "/usr/local/google/home/robertma/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/pipes.py", line 489, in template
new_content = template_regexp.sub(config_replacement, content)
File "/usr/local/google/home/robertma/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/pipes.py", line 472, in config_replacement
value = value[item[1]]
IndexError: list index out of range
,
Apr 26 2018
Upstream wptserve bug: https://github.com/w3c/web-platform-tests/issues/10667
,
Apr 26 2018
,
Apr 26 2018
Issue 836627 has been merged into this issue.
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aa62f9a1ab8d73cfab92f725bf8ea97c7ac1e6e commit 8aa62f9a1ab8d73cfab92f725bf8ea97c7ac1e6e Author: Robert Ma <robertma@chromium.org> Date: Thu Apr 26 21:50:08 2018 Remove a wrong baseline caused by flakes This test is expected to pass. The baseline was created by wpt-importer incorrectly because of a flaky failure. The flake itself is being investigated and worked on; meanwhile, the test has been marked as flaky in TestExpectations. TBR=jochen No-Try: True Bug: 837213 Change-Id: I9e187aebb20718cfc18db6f5c147bd417d2f737c Reviewed-on: https://chromium-review.googlesource.com/1031394 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#554158} [delete] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/third_party/WebKit/LayoutTests/platform/linux/external/wpt/html/semantics/scripting-1/the-script-element/module/crossorigin-expected.txt
,
Apr 27 2018
This is probably also causing many flakes in service worker tests, so adding the component. Service worker tests make heavy use of sub and importScript. Example: external/wpt/service-workers/service-worker/fetch-cors-xhr.https.html FAIL Verify CORS XHR of fetch() in a Service Worker get_host_info is not defined
,
Apr 27 2018
Found a suspected culprit. Reverting in upstream https://github.com/w3c/web-platform-tests/pull/10696
,
Apr 27 2018
,
Apr 30 2018
Found the root cause and landed a proper fix in the upstream: https://github.com/w3c/web-platform-tests/pull/10723 Roll in progress: https://chromium-review.googlesource.com/c/chromium/src/+/1036455
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5e0543a335afb8d91694b9b9c0ae3f982791905 commit b5e0543a335afb8d91694b9b9c0ae3f982791905 Author: Robert Ma <robertma@chromium.org> Date: Tue May 01 14:33:15 2018 Roll WPT tools again to fix a race condition in wptserve Namely to include this upstream fix: https://github.com/w3c/web-platform-tests/pull/10723 Besides, remove six/CHANGES from the whitelist as we generally don't include changelogs. Bug: 837213 Change-Id: I45caea8c391042937659d17ce9dd70a2adb586b5 Reviewed-on: https://chromium-review.googlesource.com/1036455 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#555035} [modify] https://crrev.com/b5e0543a335afb8d91694b9b9c0ae3f982791905/third_party/blink/tools/blinkpy/third_party/README.chromium [modify] https://crrev.com/b5e0543a335afb8d91694b9b9c0ae3f982791905/third_party/blink/tools/blinkpy/third_party/wpt/WPTWhiteList [modify] https://crrev.com/b5e0543a335afb8d91694b9b9c0ae3f982791905/third_party/blink/tools/blinkpy/third_party/wpt/checkout.sh [modify] https://crrev.com/b5e0543a335afb8d91694b9b9c0ae3f982791905/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/manifest.py [modify] https://crrev.com/b5e0543a335afb8d91694b9b9c0ae3f982791905/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/serve/serve.py [delete] https://crrev.com/aed77bf7b96062ead04616eeac810d25ae4d23a0/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/six/CHANGES [modify] https://crrev.com/b5e0543a335afb8d91694b9b9c0ae3f982791905/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/run.py [modify] https://crrev.com/b5e0543a335afb8d91694b9b9c0ae3f982791905/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/config.py [modify] https://crrev.com/b5e0543a335afb8d91694b9b9c0ae3f982791905/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/request.py
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f648d48b5309253d4390a7e0b67f16f2a41ffaab commit f648d48b5309253d4390a7e0b67f16f2a41ffaab Author: Robert Ma <robertma@chromium.org> Date: Tue May 01 17:34:54 2018 Remove a few expectations as the bug has been fixed The 500 (IndexError) issue of wptserve has been fixed at r555035, so we can remove all the related temporary expectations. Also remove some redundant and incorrect baseline files which were created because of the flake caused by the wptserve bug. TBR=foolip Bug: 837213 , 836627 , 836763 Change-Id: Icbba544e32d2709c38083fc27528050e3107cf23 Reviewed-on: https://chromium-review.googlesource.com/1037204 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#555093} [modify] https://crrev.com/f648d48b5309253d4390a7e0b67f16f2a41ffaab/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/content-security-policy/inside-worker/dedicated-script-expected.txt [delete] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/content-security-policy/inside-worker/dedicated-script-expected.txt [delete] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/content-security-policy/inside-worker/dedicated-script-expected.txt [delete] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/third_party/WebKit/LayoutTests/platform/mac/external/wpt/content-security-policy/inside-worker/dedicated-script-expected.txt
,
May 1 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 26 2018