ArcTermsOfServiceDefaultNegotiatorTest. and ArcSupportHostTest.TermsOfServiceAccept flaky/failing |
|||||
Issue descriptionBuild: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/linux-chromeos-dbg/5382 Logs: [ RUN ] ArcSupportHostTest.TermsOfServiceAccept [20767:21268:0426/024832.744504:16340721853:WARNING:sync_backend_registrar.cc(101)] No history worker -- removing TYPED_URLS [20767:21268:0426/024832.744582:16340721926:WARNING:sync_backend_registrar.cc(105)] No password worker -- removing PASSWORDS [20767:21268:0426/024832.745778:16340723122:WARNING:syncer_proto_util.cc(338)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: SYNC_AUTH_ERROR [20767:20767:0426/024832.781567:16340758915:FATAL:message_loop_current.cc(197)] Check failed: MessageLoop::TYPE_IO == loop->type() (3 vs. 1) #0 0x7fae2c44677d base::debug::StackTrace::StackTrace() #1 0x7fae2c17675c base::debug::StackTrace::StackTrace() #2 0x7fae2c1e2c3d logging::LogMessage::~LogMessage() #3 0x7fae2c21026a base::MessageLoopCurrentForIO::Get() #4 0x7fae304e17a8 net::SocketPosix::Connect() #5 0x7fae304e6635 net::TCPSocketPosix::Connect() #6 0x7fae302b9b31 net::TCPClientSocket::DoConnect() #7 0x7fae302b8efb net::TCPClientSocket::DoConnectLoop() #8 0x7fae302b8cc6 net::TCPClientSocket::Connect() #9 0x7fae302c0132 net::TransportConnectJob::DoTransportConnect() #10 0x7fae302bf23b net::TransportConnectJob::DoLoop() #11 0x7fae302bef7f net::TransportConnectJob::OnIOComplete() #12 0x7fae2fae661f _ZN4base8internal13FunctorTraitsIMN3net18ClientSocketHandleEFviEvE6InvokeIS5_PS3_JiEEEvT_OT0_DpOT1_ #13 0x7fae2fae654f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3net18ClientSocketHandleEFviEJPS5_iEEEvOT_DpOT0_ #14 0x7fae302c5415 _ZN4base8internal7InvokerINS0_9BindStateIMN3net19TransportConnectJobEFviEJNS0_17UnretainedWrapperIS4_EEEEEFviEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEEOi #15 0x7fae302c534b _ZN4base8internal7InvokerINS0_9BindStateIMN3net19TransportConnectJobEFviEJNS0_17UnretainedWrapperIS4_EEEEEFviEE3RunEPNS0_13BindStateBaseEi #16 0x000000cec5e2 _ZNO4base17RepeatingCallbackIFvjEE3RunEj #17 0x0000078bc046 net::MockHostResolverBase::RequestImpl::OnResolveCompleted() #18 0x0000078b8397 net::MockHostResolverBase::ResolveNow() #19 0x00000374fe32 _ZN4base8internal13FunctorTraitsIMN11google_apis22FilesListRequestRunnerEFvPNS_17RepeatingCallbackIFvvEEEEvE6InvokeIS9_RKNS_7WeakPtrIS3_EEJS7_EEEvT_OT0_DpOT1_ #20 0x0000078be065 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3net20MockHostResolverBaseEFvmERKNS_7WeakPtrIS5_EEJRKmEEEvOT_OT0_DpOT1_ #21 0x0000078bdfdd _ZN4base8internal7InvokerINS0_9BindStateIMN3net20MockHostResolverBaseEFvmEJNS_7WeakPtrIS4_EEmEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_mEEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #22 0x0000078bdeec _ZN4base8internal7InvokerINS0_9BindStateIMN3net20MockHostResolverBaseEFvmEJNS_7WeakPtrIS4_EEmEEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x7fae2c1278a1 _ZNO4base12OnceCallbackIFvvEE3RunEv #24 0x7fae2c177b5a base::debug::TaskAnnotator::RunTask() #25 0x7fae2c20424a base::internal::IncomingTaskQueue::RunTask() #26 0x7fae2c20c8a1 base::MessageLoop::RunTask() #27 0x7fae2c20caf5 base::MessageLoop::DeferOrRunPendingTask() #28 0x7fae2c20cdb3 base::MessageLoop::DoWork() #29 0x7fae2c47c34b base::MessagePumpLibevent::Run() #30 0x7fae2c20c18e base::MessageLoop::Run() #31 0x7fae2c2b58e2 base::RunLoop::Run() #32 0x7fae2c2b650e base::RunLoop::RunUntilIdle() #33 0x000001d42fed BrowserWithTestWindowTest::TearDown() #34 0x00000390c35a (anonymous namespace)::ArcSupportHostTest::TearDown() #35 0x000002caed7e _ZN7testing8internal12InvokeHelperIN16sync_file_system18RemoteServiceStateENSt3__15tupleIJEEEE12InvokeMethodINS2_25MockRemoteFileSyncServiceEMS9_KFS3_vEEES3_PT_T0_RKS6_ #36 0x0000044bc4a2 testing::internal::HandleExceptionsInMethodIfSupported<>() #37 0x0000044a084b testing::Test::Run() #38 0x0000044a11ed testing::TestInfo::Run() #39 0x0000044a1c9c testing::TestCase::Run() #40 0x0000044b3ea7 testing::internal::UnitTestImpl::RunAllTests() #41 0x00000426f71e _ZN7testing8internal12InvokeHelperIbNSt3__15tupleIJEEEE12InvokeMethodI17TetherServiceTestMS7_FbvEEEbPT_T0_RKS4_ #42 0x0000044bda52 testing::internal::HandleExceptionsInMethodIfSupported<>() #43 0x0000044b3b05 testing::UnitTest::Run() #44 0x0000076202a1 RUN_ALL_TESTS() #45 0x00000761ccfb base::TestSuite::Run() #46 0x0000077e96b0 content::UnitTestTestSuite::Run() #47 0x0000009f139d _ZN4base8internal13FunctorTraitsIMNS_7RunLoopEFvvEvE6InvokeIS4_PS2_JEEEvT_OT0_DpOT1_ #48 0x0000009f12e4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMNS_7RunLoopEFvvEJPS4_EEEvOT_DpOT0_ #49 0x000007606d35 _ZN4base8internal7InvokerINS0_9BindStateIMN7content17UnitTestTestSuiteEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #50 0x000007606c7c _ZN4base8internal7InvokerINS0_9BindStateIMN7content17UnitTestTestSuiteEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #51 0x000004325521 _ZNO4base12OnceCallbackIFN5drive9FileErrorEvEE3RunEv #52 0x000007629180 base::(anonymous namespace)::LaunchUnitTestsInternal() #53 0x000007629002 base::LaunchUnitTests() #54 0x000007606a8f main #55 0x7fae0d356f45 __libc_start_main #56 0x0000009d7a5a _start [ RUN ] ArcTermsOfServiceDefaultNegotiatorTest.Accept [21586:21586:0426/024841.030654:16349008035:WARNING:device_settings_provider.cc(742)] Changing settings from non-owner, setting=cros.metrics.reportingEnabled [21586:21954:0426/024841.069357:16349046710:WARNING:sync_backend_registrar.cc(101)] No history worker -- removing TYPED_URLS [21586:21954:0426/024841.069428:16349046775:WARNING:sync_backend_registrar.cc(105)] No password worker -- removing PASSWORDS [21586:21954:0426/024841.071212:16349048560:WARNING:syncer_proto_util.cc(338)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: SYNC_AUTH_ERROR [21586:21586:0426/024841.126129:16349103481:FATAL:message_loop_current.cc(197)] Check failed: MessageLoop::TYPE_IO == loop->type() (3 vs. 1) #0 0x7faf9e34177d base::debug::StackTrace::StackTrace() #1 0x7faf9e07175c base::debug::StackTrace::StackTrace() #2 0x7faf9e0ddc3d logging::LogMessage::~LogMessage() #3 0x7faf9e10b26a base::MessageLoopCurrentForIO::Get() #4 0x7fafa23dc7a8 net::SocketPosix::Connect() #5 0x7fafa23e1635 net::TCPSocketPosix::Connect() #6 0x7fafa21b4b31 net::TCPClientSocket::DoConnect() #7 0x7fafa21b3efb net::TCPClientSocket::DoConnectLoop() #8 0x7fafa21b3cc6 net::TCPClientSocket::Connect() #9 0x7fafa21bb132 net::TransportConnectJob::DoTransportConnect() #10 0x7fafa21ba23b net::TransportConnectJob::DoLoop() #11 0x7fafa21b9f7f net::TransportConnectJob::OnIOComplete() #12 0x7fafa19e161f _ZN4base8internal13FunctorTraitsIMN3net18ClientSocketHandleEFviEvE6InvokeIS5_PS3_JiEEEvT_OT0_DpOT1_ #13 0x7fafa19e154f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3net18ClientSocketHandleEFviEJPS5_iEEEvOT_DpOT0_ #14 0x7fafa21c0415 _ZN4base8internal7InvokerINS0_9BindStateIMN3net19TransportConnectJobEFviEJNS0_17UnretainedWrapperIS4_EEEEEFviEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEEOi #15 0x7fafa21c034b _ZN4base8internal7InvokerINS0_9BindStateIMN3net19TransportConnectJobEFviEJNS0_17UnretainedWrapperIS4_EEEEEFviEE3RunEPNS0_13BindStateBaseEi #16 0x000000cec5e2 _ZNO4base17RepeatingCallbackIFvjEE3RunEj #17 0x0000078bc046 net::MockHostResolverBase::RequestImpl::OnResolveCompleted() #18 0x0000078b8397 net::MockHostResolverBase::ResolveNow() #19 0x00000374fe32 _ZN4base8internal13FunctorTraitsIMN11google_apis22FilesListRequestRunnerEFvPNS_17RepeatingCallbackIFvvEEEEvE6InvokeIS9_RKNS_7WeakPtrIS3_EEJS7_EEEvT_OT0_DpOT1_ #20 0x0000078be065 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3net20MockHostResolverBaseEFvmERKNS_7WeakPtrIS5_EEJRKmEEEvOT_OT0_DpOT1_ #21 0x0000078bdfdd _ZN4base8internal7InvokerINS0_9BindStateIMN3net20MockHostResolverBaseEFvmEJNS_7WeakPtrIS4_EEmEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_mEEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #22 0x0000078bdeec _ZN4base8internal7InvokerINS0_9BindStateIMN3net20MockHostResolverBaseEFvmEJNS_7WeakPtrIS4_EEmEEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x7faf9e0228a1 _ZNO4base12OnceCallbackIFvvEE3RunEv #24 0x7faf9e072b5a base::debug::TaskAnnotator::RunTask() #25 0x7faf9e0ff24a base::internal::IncomingTaskQueue::RunTask() #26 0x7faf9e1078a1 base::MessageLoop::RunTask() #27 0x7faf9e107af5 base::MessageLoop::DeferOrRunPendingTask() #28 0x7faf9e107db3 base::MessageLoop::DoWork() #29 0x7faf9e37734b base::MessagePumpLibevent::Run() #30 0x7faf9e10718e base::MessageLoop::Run() #31 0x7faf9e1b08e2 base::RunLoop::Run() #32 0x7faf9e1b150e base::RunLoop::RunUntilIdle() #33 0x000001d42fed BrowserWithTestWindowTest::TearDown() #34 0x0000039dfba6 arc::ArcTermsOfServiceDefaultNegotiatorTest::TearDown() #35 0x000002caed7e _ZN7testing8internal12InvokeHelperIN16sync_file_system18RemoteServiceStateENSt3__15tupleIJEEEE12InvokeMethodINS2_25MockRemoteFileSyncServiceEMS9_KFS3_vEEES3_PT_T0_RKS6_ #36 0x0000044bc4a2 testing::internal::HandleExceptionsInMethodIfSupported<>() #37 0x0000044a084b testing::Test::Run() #38 0x0000044a11ed testing::TestInfo::Run() #39 0x0000044a1c9c testing::TestCase::Run() #40 0x0000044b3ea7 testing::internal::UnitTestImpl::RunAllTests() #41 0x00000426f71e _ZN7testing8internal12InvokeHelperIbNSt3__15tupleIJEEEE12InvokeMethodI17TetherServiceTestMS7_FbvEEEbPT_T0_RKS4_ #42 0x0000044bda52 testing::internal::HandleExceptionsInMethodIfSupported<>() #43 0x0000044b3b05 testing::UnitTest::Run() #44 0x0000076202a1 RUN_ALL_TESTS() #45 0x00000761ccfb base::TestSuite::Run() #46 0x0000077e96b0 content::UnitTestTestSuite::Run() #47 0x0000009f139d _ZN4base8internal13FunctorTraitsIMNS_7RunLoopEFvvEvE6InvokeIS4_PS2_JEEEvT_OT0_DpOT1_ #48 0x0000009f12e4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMNS_7RunLoopEFvvEJPS4_EEEvOT_DpOT0_ #49 0x000007606d35 _ZN4base8internal7InvokerINS0_9BindStateIMN7content17UnitTestTestSuiteEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #50 0x000007606c7c _ZN4base8internal7InvokerINS0_9BindStateIMN7content17UnitTestTestSuiteEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #51 0x000004325521 _ZNO4base12OnceCallbackIFN5drive9FileErrorEvEE3RunEv #52 0x000007629180 base::(anonymous namespace)::LaunchUnitTestsInternal() #53 0x000007629002 base::LaunchUnitTests() #54 0x000007606a8f main #55 0x7faf7f251f45 __libc_start_main #56 0x0000009d7a5a _start
,
Apr 26 2018
Probably https://chromium-review.googlesource.com/c/chromium/src/+/983914 will also have to be reverted, since it depended on those test updates.
,
Apr 26 2018
,
Apr 26 2018
Flakiness dashboard link for future reference: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=TermsOfService
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6 commit fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6 Author: Marc Treib <treib@chromium.org> Date: Thu Apr 26 12:49:02 2018 Revert "Sync: Use IdentityManager instead of SigninManager" This reverts commit aab579140be16a85c587bbdc696f9393ba2bc08c. Reason for revert: Depends on crrev.com/c/1025898 which was reverted Original change's description: > Sync: Use IdentityManager instead of SigninManager > > This CL migrates ProfileSyncService to IdentityManager for getting > info on the primary account. This includes switching from > SigninManagerBase::Observer to IdentityManager::Observer. > The only remaining use of SigninManager within PSS it to call > SignOut() which isn't exposed by IdentityManager yet. > > Bug: 825190 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Icf9398d63794cab03cb559adba5c767e18c31c0a > Reviewed-on: https://chromium-review.googlesource.com/983914 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553973} TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org Change-Id: Ib40dbff0f1c8e5fba95cb9881681361abec5aeec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825190 , 837201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1030372 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#553997} [modify] https://crrev.com/fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6/chrome/browser/sync/test/integration/profile_sync_service_harness.cc [modify] https://crrev.com/fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6/components/browser_sync/profile_sync_service_unittest.cc [modify] https://crrev.com/fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6/components/sync/driver/signin_manager_wrapper.cc [modify] https://crrev.com/fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6/components/sync/driver/sync_service_base.cc
,
Apr 26 2018
,
Apr 26 2018
Issue 837233 has been merged into this issue.
,
Apr 26 2018
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5d0c430e0a16f0c67bea814c5674c3f96dd259b commit a5d0c430e0a16f0c67bea814c5674c3f96dd259b Author: Marc Treib <treib@chromium.org> Date: Fri May 04 09:06:46 2018 Reland "Migrate Arc unit tests to IdentityManager" Original CL: https://crrev.com/c/1025898 Revert: https://crrev.com/c/1030150 Patchset 1 contains the original CL. What's changed from there is to set up the primary account without providing a refresh token (like the tests did before this change). Original change's description: > Revert "Migrate Arc unit tests to IdentityManager" > > This reverts commit 1e3550d572933d5dd57a47ce32d7a56f53f01887. > > Reason for revert: Failing tests, see crbug.com/837201 > > Original change's description: > > Migrate Arc unit tests to IdentityManager > > > > identity::IdentityManager is the new API that replaces SigninManager[Base]. > > > > This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest. > > > > Bug: 825190 , 731023 > > Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b > > Reviewed-on: https://chromium-review.googlesource.com/1025898 > > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > > Commit-Queue: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553949} > > TBR=yusukes@chromium.org,treib@chromium.org > > Change-Id: Iba9649631ec8633c0b89b867a60e89d3d63a01ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 825190 , 731023, 837201 > Reviewed-on: https://chromium-review.googlesource.com/1030150 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553979} Bug: 825190 , 731023, 837201 Change-Id: I83753ba9036eb9f93ba32c74302dbd151b03c0bf Reviewed-on: https://chromium-review.googlesource.com/1030451 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556017} [modify] https://crrev.com/a5d0c430e0a16f0c67bea814c5674c3f96dd259b/chrome/browser/chromeos/arc/arc_support_host_unittest.cc [modify] https://crrev.com/a5d0c430e0a16f0c67bea814c5674c3f96dd259b/chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc [modify] https://crrev.com/a5d0c430e0a16f0c67bea814c5674c3f96dd259b/services/identity/public/cpp/identity_manager.h
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a3600c1bf36d80734992e8998447ac3edff997c commit 0a3600c1bf36d80734992e8998447ac3edff997c Author: Marc Treib <treib@chromium.org> Date: Fri May 04 11:12:28 2018 Reland "Sync: Use IdentityManager instead of SigninManager" This reverts commit fd8a3a1f08a5836029eaee2f6f7dbf24715ddad6. Reason for revert: The depended-on CL has been relanded as https://crrev.com/c/1030451 Original change's description: > Revert "Sync: Use IdentityManager instead of SigninManager" > > This reverts commit aab579140be16a85c587bbdc696f9393ba2bc08c. > > Reason for revert: Depends on crrev.com/c/1025898 which was reverted > > Original change's description: > > Sync: Use IdentityManager instead of SigninManager > > > > This CL migrates ProfileSyncService to IdentityManager for getting > > info on the primary account. This includes switching from > > SigninManagerBase::Observer to IdentityManager::Observer. > > The only remaining use of SigninManager within PSS it to call > > SignOut() which isn't exposed by IdentityManager yet. > > > > Bug: 825190 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > Change-Id: Icf9398d63794cab03cb559adba5c767e18c31c0a > > Reviewed-on: https://chromium-review.googlesource.com/983914 > > Commit-Queue: Marc Treib <treib@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553973} > > TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org > > Change-Id: Ib40dbff0f1c8e5fba95cb9881681361abec5aeec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 825190 , 837201 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/1030372 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553997} TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825190 , 837201 Change-Id: If6858f033ac8390acfc904379afbf9726a6301c2 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1043885 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556026} [modify] https://crrev.com/0a3600c1bf36d80734992e8998447ac3edff997c/chrome/browser/sync/test/integration/profile_sync_service_harness.cc [modify] https://crrev.com/0a3600c1bf36d80734992e8998447ac3edff997c/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/0a3600c1bf36d80734992e8998447ac3edff997c/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/0a3600c1bf36d80734992e8998447ac3edff997c/components/browser_sync/profile_sync_service_unittest.cc [modify] https://crrev.com/0a3600c1bf36d80734992e8998447ac3edff997c/components/sync/driver/signin_manager_wrapper.cc [modify] https://crrev.com/0a3600c1bf36d80734992e8998447ac3edff997c/components/sync/driver/sync_service_base.cc
,
May 7 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 26 2018