Fuchsia runner script continues trying to run if files are missing |
||
Issue descriptionWhat steps will reproduce the problem? (1) Build a unit-tests target. (2) Delete <out-dir>/fvm* (3) Run the target runner script. What is the expected result? Expect that the runner script errors out because necessary files are missing. What happens instead? The runner script logs an error from QEMU but then continues trying to connect to the VM via SSH, making it harder to spot the failure in the log output. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
May 1 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46266c4cc1adbcda47d85566126b8096587d3785 commit 46266c4cc1adbcda47d85566126b8096587d3785 Author: Dirk Pranke <dpranke@chromium.org> Date: Tue May 01 21:13:18 2018 Revert "Fuchsia: Explicitly check that all file dependencies exist." This reverts commit 7891d057259d6df8483de1f03a39a6c202cca241. Reason for revert: See last comment, broke webkit_lint on the win tryservers. Original change's description: > Fuchsia: Explicitly check that all file dependencies exist. > > Wrap file path references with "EnsureFileExists()" which acts as a > simple identity function, except for invalid paths for which it > raises IOErrors. > > Bug: 837200 > Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04 > Reviewed-on: https://chromium-review.googlesource.com/1037778 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555137} TBR=wez@chromium.org,kmarshall@chromium.org,scottmg@chromium.org Change-Id: Ic53f3c5b7bc2a6177166a8564584999dd2477454 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837200 Reviewed-on: https://chromium-review.googlesource.com/1038444 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555183} [modify] https://crrev.com/46266c4cc1adbcda47d85566126b8096587d3785/build/fuchsia/common.py [modify] https://crrev.com/46266c4cc1adbcda47d85566126b8096587d3785/build/fuchsia/device_target.py [modify] https://crrev.com/46266c4cc1adbcda47d85566126b8096587d3785/build/fuchsia/qemu_target.py
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe0226186fa4a13732cdbf2aa175cc318b882748 commit fe0226186fa4a13732cdbf2aa175cc318b882748 Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed May 02 21:13:10 2018 Reland "Fuchsia: Explicitly check that all file dependencies exist." This is a reland of 7891d057259d6df8483de1f03a39a6c202cca241 The underlying issue in crbug.com/838703 was fixed and "lint_test_expectations.py" Works On My Box(TM). TBR=scottmg@chromium.org Original change's description: > Fuchsia: Explicitly check that all file dependencies exist. > > Wrap file path references with "EnsureFileExists()" which acts as a > simple identity function, except for invalid paths for which it > raises IOErrors. > > Bug: 837200 > Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04 > Reviewed-on: https://chromium-review.googlesource.com/1037778 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555137} Bug: 837200 Change-Id: I21713adc9e8d9fcaab06957a25255de3ee6e596e Reviewed-on: https://chromium-review.googlesource.com/1038963 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#555534} [modify] https://crrev.com/fe0226186fa4a13732cdbf2aa175cc318b882748/build/fuchsia/common.py [modify] https://crrev.com/fe0226186fa4a13732cdbf2aa175cc318b882748/build/fuchsia/device_target.py [modify] https://crrev.com/fe0226186fa4a13732cdbf2aa175cc318b882748/build/fuchsia/qemu_target.py |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 1 2018