New issue
Advanced search Search tips

Issue 837189 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: May 2018
Cc:
apronin@chromium.org
mnissler@chromium.org
pmalani@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Cryptohome doesn't remove PIN credentials on account removal

Project Member Reported by mnissler@chromium.org, Apr 26 2018 
Repro:

1. cryptohome --action=mount_ex --user=testing@gmail.com --create --key_label=default
2. cryptohome --action=add_key_ex --key_policy=le --user=testing@gmail.com --new_key_label=lecred0
3. cryptohome --action=remove_key_ex --user=testing@gmail.com --remove_key_label=lecred0
4. Observe that there's no pinweaver log entry for removal in syslog and /home/.shadow/low_entropy_creds/ still contains the subdir corresponding to the credential.
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f1863ee9368746a7e44fcb73b22b3c96d0737ce7

commit f1863ee9368746a7e44fcb73b22b3c96d0737ce7
Author: Prashant Malani <pmalani@google.com>
Date: Tue May 08 03:45:35 2018

cryptohome: Connect cryptohome for LE Credential removal

BUG= chromium:837189 
TEST=1. Unit tests
     2. cryptohome --action=add_key_ex --key_policy=le
        --user=testing@gmail.com --new_key_label=lecred0
     3. cryptohome --action=remove_key_ex
        --user=testing@gmail.com --remove_key_label=lecred0
     Removal succeeds.

Change-Id: I66473ff1d3cb073d7a0120702a33ae478f072e5f
Reviewed-on: https://chromium-review.googlesource.com/1040730
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Prashant Malani <pmalani@google.com>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/f1863ee9368746a7e44fcb73b22b3c96d0737ce7/cryptohome/homedirs_unittest.cc
[modify] https://crrev.com/f1863ee9368746a7e44fcb73b22b3c96d0737ce7/cryptohome/crypto.h
[modify] https://crrev.com/f1863ee9368746a7e44fcb73b22b3c96d0737ce7/cryptohome/homedirs.cc
[modify] https://crrev.com/f1863ee9368746a7e44fcb73b22b3c96d0737ce7/cryptohome/crypto.cc

Comment 2 by pmalani@chromium.org, May 9 2018

Status: Fixed (was: Available)

Comment 3 by pmalani@chromium.org, May 9 2018

Cc: mnissler@chromium.org
►

Sign in to add a comment