Issue metadata
Sign in to add a comment
|
Regression: [DevTools] Eye dropper doesn’t change to mouse pointer on moving the mouse into DevTools window.
Reported by
dchau...@etouch.net,
Apr 26 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 66.0.3359.139 (Official Build)(64-bit)Revision a020eddf0d85fe84d4a6787b304f50aafb670969-refs/branch-heads/3359@{#767} OS: Mac(10.12.6, 10.13.1, 10.13.5). What steps will reproduce the problem? 1. Launch Chrome, go to NTP, open DevTools and undock it into separate window. 2. Click to open ColorPicker dialog under ‘Styles’ section and move the mouse pointer out of DevTools (eye dropper will appear). 3. Now move the mouse into DevTools window and observe. (Refer the attached ‘Actual behaviour’ screen-cast) Actual: Eye dropper doesn’t change to mouse pointer. Expected: Eye dropper should change to mouse pointer. This is a Mac specific regression issue, broken in M-62 series, below is manual regression range. Good build: 62.0.3168.0 (Revision: 489804) Bad build: 62.0.3169.0 (Revision: 490187) Using the per-revision bisect providing the bisect results: You are probably looking for a change made after 489865 (known good), but no later than 489866 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/01d4ebd95a59a8eb8cc368e28d2d8d236faf14d6..ecfc59c0dcd79727c03fd8e835036cd7a8ad8e99 Suspecting: https://chromium.googlesource.com/chromium/src/+/ecfc59c0dcd79727c03fd8e835036cd7a8ad8e99 @tapted: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. NOTE: 1. This issue is also reproducible on M-66 Beta (build # 66.0.3359.117), M-67 Dev (build #67.0.3396.18) and M-68 Canary (build # 68.0.3409.0). 2. This issue is not reproducible on Win(7,8,8.1,10), Linux (14.04 LTS) machines. Kindly review the attached screen-cast for reference. Thank you.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcee59f1c00ec3d0e6dbd8b1b3bf916ccdfea481 commit fcee59f1c00ec3d0e6dbd8b1b3bf916ccdfea481 Author: jongkwon.lee <jongkwon.lee@navercorp.com> Date: Fri May 04 04:15:41 2018 Fix the eye dropper cursor of DevTools |updateCursor:| might be called outside the view bounds. Check the mouse location before setting the cursor. Also, do not set cursor if it's not a key window. Bug: 837182 Change-Id: Idd2f12648e858284c6fc4cb1ba3b03eb7ad4f274 Reviewed-on: https://chromium-review.googlesource.com/1039283 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555979} [modify] https://crrev.com/fcee59f1c00ec3d0e6dbd8b1b3bf916ccdfea481/content/browser/renderer_host/render_widget_host_view_cocoa.mm
,
May 7 2018
Update: Rechecked this issue on Mac(10.12.6, 10.13.1, 10.13.5) machines using latest Canary #68.0.3423.0 and unable to verify it due to issue 839742 Thank you.
,
May 25 2018
,
May 25 2018
Update:- Re-tested this issue on Mac(10.12.6, 10.13.1, 10.13.5) machines using latest Chrome Canary build# 68.0.3440.0 and fix is working as expected.. Hence adding TE-Verified labels. Please find the attached screen-cast for reference. Thanks..!
,
May 25 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jongkwon...@navercorp.com
, May 2 2018