WebKit Win10 and WebKit Win7 having mass shard timeouts. |
|||||
Issue descriptionhttps://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/ https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/ Results all look like shard #0 timed out, took too much time to complete shard #1 timed out, took too much time to complete shard #10 timed out, took too much time to complete shard #11 timed out, took too much time to complete shard #2 timed out, took too much time to complete shard #3 timed out, took too much time to complete shard #4 timed out, took too much time to complete shard #5 timed out, took too much time to complete shard #6 timed out, took too much time to complete shard #7 timed out, took too much time to complete shard #8 timed out, took too much time to complete shard #9 timed out, took too much time to complete
,
Apr 26 2018
,
Apr 26 2018
Possibly related to: https://chromium-review.googlesource.com/c/chromium/src/+/1026889 robertma@ is investigating.
,
Apr 26 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1026889 didn't run webkit_layout_tests (due to analyze) so it incorrectly passed the CQ. This is a problem with analyze.
,
Apr 26 2018
I don't think it's an issue with analyze. I took the layout tests off of win7_chromium_rel_ng a couple of weeks ago because of persistent issues they were causing on the bot; martiniss@ added them back as a 100% experiment last night in https://chromium-review.googlesource.com/c/chromium/src/+/1028009
,
Apr 26 2018
Reverting: https://chromium-review.googlesource.com/c/chromium/src/+/1030570 (Waiting for win{7,10}_blink_rel to pass before submitting the revert) The more fundamental cause is that we currently don't run layout tests on any Windows CQ bots. I know we previously disabled layout tests on win7_chromium_rel_ng in issue 831585 , but I think we've added it back, haven't we?
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f964cedb43a0f8682f2ab1facdf35c03f26affa2 commit f964cedb43a0f8682f2ab1facdf35c03f26affa2 Author: Robert Ma <robertma@chromium.org> Date: Thu Apr 26 15:36:08 2018 Revert "[blinkpy] Manage the lifecycle of wptserve better" This reverts commit 805c043e94a3b6dcc47e52530575c53f025632aa. Reason for revert: might have broken layout tests on Windows Original change's description: > [blinkpy] Manage the lifecycle of wptserve better > > During a recent roll of wpt tools, wptserve was broken and it was very > hard to debug. A few changes are made to improve the debuggability and > overall code health of wptserve management in blinkpy. > > * Stop discarding the output of wptserve. Set the logging level to info > (the default is debug) and preserve the output, so that it can be > dumped out when something goes wrong. > * When checking and killing wptserve, we now poll the process before > sending the null signal, as `kill -0` a defunct process will still > succeed. We can now reap zombies much faster :) > * Lastly, _check_and_kill no longer does blocking wait inside. Now, > _wait_for_action(_check_and_kill) makes more sense and matches the > pattern in ServerBase better; and we send SIGKILL as a last resort > (on POSIX). > > apache_http.py is modified by the way to replace an unnecessary popen > with run_command. httpd exits immediately after it spawns the daemon, > so there's no use holding onto the defunct main process. > > Change-Id: I441d36739451ad1e37afc6afe8f3c089cf224822 > Reviewed-on: https://chromium-review.googlesource.com/1026889 > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553619} TBR=qyearsley@chromium.org,robertma@chromium.org Bug: 837170 Change-Id: I1874e946aff690ff0a1fcfb84c4324f2604df778 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1030570 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#554035} [modify] https://crrev.com/f964cedb43a0f8682f2ab1facdf35c03f26affa2/third_party/blink/tools/blinkpy/common/system/executive.py [modify] https://crrev.com/f964cedb43a0f8682f2ab1facdf35c03f26affa2/third_party/blink/tools/blinkpy/third_party/wpt/wpt.config.json [modify] https://crrev.com/f964cedb43a0f8682f2ab1facdf35c03f26affa2/third_party/blink/tools/blinkpy/web_tests/servers/apache_http.py [modify] https://crrev.com/f964cedb43a0f8682f2ab1facdf35c03f26affa2/third_party/blink/tools/blinkpy/web_tests/servers/wptserve.py [modify] https://crrev.com/f964cedb43a0f8682f2ab1facdf35c03f26affa2/third_party/blink/tools/blinkpy/web_tests/servers/wptserve_unittest.py
,
Apr 26 2018
The immediate problem should be fixed by the revert above. jbudorick/maruel, if webkit_layout_tests hasn't been added back to win7_chromium_rel_ng, could you reopen issue 831585 (or open another bug) to track it? Thanks!
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dcb8fb1572229b75271a9dee2ac0b1333447234 commit 3dcb8fb1572229b75271a9dee2ac0b1333447234 Author: Robert Ma <robertma@chromium.org> Date: Thu Apr 26 18:32:55 2018 Fix up Windows baselines after an outage Layout tests didn't run on Windows for a while ( issue 837170 ) so some imported tests didn't get the correct baselines in the interim. This CL fixes these baselines. TBR=foolip Bug: 837170 Change-Id: Ia5f50ac894ecb8bf06b4b6ced95c579093fca850 Reviewed-on: https://chromium-review.googlesource.com/1030757 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#554092} [add] https://crrev.com/3dcb8fb1572229b75271a9dee2ac0b1333447234/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/border-radius-clipped-layer-second-column-expected.txt [delete] https://crrev.com/5d86246b01926e5aa41d3a68d2283abee2ca2262/third_party/WebKit/LayoutTests/virtual/off-main-thread-websocket/external/wpt/websockets/Create-protocols-repeated-case-insensitive.any-expected.txt |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sugoi@chromium.org
, Apr 26 2018