Issue metadata
Sign in to add a comment
|
Regression:Unwanted extra space is seen besides the permission drop down options
Reported by
vineetha...@etouch.net,
Apr 26 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3409.0 (Official Build) Revision 14c5d49cfb5674793fe0d5223cc4cf257732a8ff-refs/heads/master@{#553714}(64 bit) OS: Mac(10.12.6,10.13.1), 10.13.5(Macbook Pro Touchbar) URL: https://permission.site What steps will reproduce the problem? (1) Launch Chrome, navigate to above URL. (2) Now click on any of the available option e.g: Notification or Location etc. (3) Now click on the 'Secure' chip on the LHS of omnibox, then click on the drop down corresponding to each option and observe. Actual Result: Extra space is seen besides the permission drop down options. Expected Result: Extra space should not be seen besides the permission drop down options. This is regression issue broken in ‘M-68’ and providing the bisect info below, (Unable to provide bisect using per-revision script,Hence providing bisect with old script): Good build: 68.0.3406.0(Revision: 553302) Bad build: 68.0.3409.0(Revision: 553714) Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/86440056a3ed001d5ef5e3dd9d64eca9ad8f4b99..280a408413bcffc6b6540f5dafe766ebad59d0af?pretty=fuller&n=10000 Suspecting: r553584? @ellyjones: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. The issue is not seen Windows(7,8,8.1,10) and Linux(14.04) OS. 2. Same issue is also observed for 'Folder' drop down on 'Edit bookmark' overlay. Thank You!
,
Apr 26 2018
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ca3f90e4f51a96d0a5aec9915406898a2ff4058 commit 3ca3f90e4f51a96d0a5aec9915406898a2ff4058 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Apr 27 20:24:28 2018 views: don't impose minimum sizes on comboboxes It looks quite bad. This was an unintended regression from the fixed-width look. Adding a test for this regression is unfortunately difficult - mocking out the MenuController used by a single MenuItemView is complex to do. Bug: 837158 Change-Id: Ie2e094a69c1d25bbcf8b53cfd66da4dec51e0f1b Reviewed-on: https://chromium-review.googlesource.com/1030038 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#554491} [modify] https://crrev.com/3ca3f90e4f51a96d0a5aec9915406898a2ff4058/ui/views/controls/menu/menu_item_view.cc [modify] https://crrev.com/3ca3f90e4f51a96d0a5aec9915406898a2ff4058/ui/views/controls/menu/menu_item_view_unittest.cc
,
Apr 30 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Apr 26 2018