New issue
Advanced search Search tips

Issue 837155 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Remove TestWebGraphicsContext3D

Project Member Reported by xing...@intel.com, Apr 26 2018

Issue description

Below idea is from danakj@ and enne@:
1a. Modify tests that create TestContextProvider from TestWebGraphicsContext3D to use TestGLES2Interface instead.
1b. Modify tests that query the TestWebGraphicsContext3D off TestContextProvider to use TestGLES2Interface instead.
* At this point tests no longer know about the TestWebGraphicsContext3D.
2. Merge functionality of TestWebGraphicsContext3D up into TestGLES2Interface and delete the former.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d5087769b2d4b0d7dd5c23bf650d0c7d8ce716d

commit 3d5087769b2d4b0d7dd5c23bf650d0c7d8ce716d
Author: Xu Xing <xing.xu@intel.com>
Date: Fri Apr 27 01:47:36 2018

viz: Avoid TestWebGraphicsContext3D in GLRendererWithMockContextTest

Also LoseContextOnFirstGetContext.
BUG= 837155 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I2c4dfc2edacf539736c4e42a75d027c1a822bf95
Reviewed-on: https://chromium-review.googlesource.com/1029375
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554261}
[modify] https://crrev.com/3d5087769b2d4b0d7dd5c23bf650d0c7d8ce716d/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/3d5087769b2d4b0d7dd5c23bf650d0c7d8ce716d/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/3d5087769b2d4b0d7dd5c23bf650d0c7d8ce716d/components/viz/test/test_context_provider.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1252efe8a81c5960f0b7871d00c76e4ba64ebd98

commit 1252efe8a81c5960f0b7871d00c76e4ba64ebd98
Author: Xu Xing <xing.xu@intel.com>
Date: Sat May 05 00:20:25 2018

viz: Remove TestWebGraphicsContext3D in GLRendererTest-Step 1a

Exception is OutputSurfaceMockContext, will be handled next.

BUG= 837155 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If098503da8a0f52b4c9442eecdb194c41b4731ee
Reviewed-on: https://chromium-review.googlesource.com/1032238
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#556270}
[modify] https://crrev.com/1252efe8a81c5960f0b7871d00c76e4ba64ebd98/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/1252efe8a81c5960f0b7871d00c76e4ba64ebd98/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/1252efe8a81c5960f0b7871d00c76e4ba64ebd98/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/1252efe8a81c5960f0b7871d00c76e4ba64ebd98/components/viz/test/test_gles2_interface.cc
[modify] https://crrev.com/1252efe8a81c5960f0b7871d00c76e4ba64ebd98/components/viz/test/test_gles2_interface.h

Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91a73861d9760d878bb55d3c4a5395fd9dc8a00e

commit 91a73861d9760d878bb55d3c4a5395fd9dc8a00e
Author: Xu Xing <xing.xu@intel.com>
Date: Tue May 08 00:29:12 2018

viz: convert OutputSurfaceMockContext to TestGLES2Interface-Step 1a

This is a followup for:
https://chromium-review.googlesource.com/c/chromium/src/+/1032238

BUG= 837155 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I5dbca02b6a2eb2433a497f2a1d589fe5c477c38d
Reviewed-on: https://chromium-review.googlesource.com/1046161
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#556624}
[modify] https://crrev.com/91a73861d9760d878bb55d3c4a5395fd9dc8a00e/components/viz/service/display/gl_renderer_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4162f59ed9e38c27e971a9ba3a182e905206a818

commit 4162f59ed9e38c27e971a9ba3a182e905206a818
Author: Xu Xing <xing.xu@intel.com>
Date: Tue May 08 02:14:22 2018

viz: Remove TestWebGraphicsContext3D in DisplayTest and ShaderTest-Step 1a

BUG= 837155 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I0ee28059ab44ace3fd066d500a57cbde252863d7
Reviewed-on: https://chromium-review.googlesource.com/1046371
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556651}
[modify] https://crrev.com/4162f59ed9e38c27e971a9ba3a182e905206a818/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/4162f59ed9e38c27e971a9ba3a182e905206a818/components/viz/service/display/shader_unittest.cc

Comment 5 by piman@chromium.org, May 9 2018

Labels: -Type-Bug Type-Task
This is double-plus awesome, thanks a ton for taking this on!
Project Member

Comment 6 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d4b2bf906ee2d067769dbb265cc854fea15fc54

commit 0d4b2bf906ee2d067769dbb265cc854fea15fc54
Author: Xu Xing <xing.xu@intel.com>
Date: Thu May 17 00:20:12 2018

viz: Remove TestWebGraphicsContext3D in Layer*Test-Step 1a

BUG= 837155 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I51327a0a0fcd8f23050ccc214f0169e8b6740e6d
Reviewed-on: https://chromium-review.googlesource.com/1051262
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#559360}
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/components/viz/test/test_context_provider.h
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/components/viz/test/test_gles2_interface.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/components/viz/test/test_gles2_interface.h
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/components/viz/test/test_web_graphics_context_3d.cc
[modify] https://crrev.com/0d4b2bf906ee2d067769dbb265cc854fea15fc54/components/viz/test/test_web_graphics_context_3d.h

Project Member

Comment 7 by bugdroid1@chromium.org, May 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/934a630160cf5b0cc94a767ee53c05dee9bb7f61

commit 934a630160cf5b0cc94a767ee53c05dee9bb7f61
Author: Xu Xing <xing.xu@intel.com>
Date: Sun May 27 04:27:55 2018

viz: Move TestWebGraphicsContext3D into TestGLES2Interface-Step 2

TestWebGraphicsContext3D was used to subclass no-longer-existing WebGraphicsContext3D, which has
a lot of code for tracking GL states for tests. In this CL, we move the GL states related code
into TestGLES2Interface, and turn all TestWebGraphicsContext3D related cases into TestGLES2Interface.

In a followup CL,when TestWebGraphicsContext3DTest is moved into TestGLES2InterfaceTest,
TestWebGraphicsContext3D can be removed.

BUG= 837155 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iedfac5b3550c64bda5f7c191bc69f631538786e1
Reviewed-on: https://chromium-review.googlesource.com/1065507
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#562140}
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/service/display/display_resource_provider_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/service/display/texture_deleter_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/service/display_embedder/buffer_queue_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/test/test_context_provider.h
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/test/test_gles2_interface.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/components/viz/test/test_gles2_interface.h
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/934a630160cf5b0cc94a767ee53c05dee9bb7f61/content/renderer/gpu/render_widget_compositor_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd642283e958a93ebf6891600db055f1f1b4f3b2

commit dd642283e958a93ebf6891600db055f1f1b4f3b2
Author: Xu Xing <xing.xu@intel.com>
Date: Wed May 30 03:05:51 2018

viz: Move TestWebGraphicsContext3DTest to TestGLES2InterfaceTest

Also delete TestWebGraphicsContext3D. This is a follow up CL for:
https://chromium-review.googlesource.com/1065507.

BUG= 837155 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I09c3d1ba98484c48d4ec5b8b0f1b2c16ae2d8873
Reviewed-on: https://chromium-review.googlesource.com/1074810
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#562713}
[modify] https://crrev.com/dd642283e958a93ebf6891600db055f1f1b4f3b2/components/viz/test/BUILD.gn
[add] https://crrev.com/dd642283e958a93ebf6891600db055f1f1b4f3b2/components/viz/test/test_gles2_interface_unittest.cc
[delete] https://crrev.com/7102df0bab2d95d2af25a21a5a96ac11d95998e5/components/viz/test/test_web_graphics_context_3d.cc
[delete] https://crrev.com/7102df0bab2d95d2af25a21a5a96ac11d95998e5/components/viz/test/test_web_graphics_context_3d.h
[delete] https://crrev.com/7102df0bab2d95d2af25a21a5a96ac11d95998e5/components/viz/test/test_web_graphics_context_3d_unittest.cc

Comment 9 by xing...@intel.com, May 30 2018

Status: Fixed (was: Started)
This is done, so mark it as Fix.

Sign in to add a comment