We should be able to be more clever about how we filter out warnings, so we don't emit warnings for things caused by Gmock macros.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b41cd2897fc4609d66d1a3d5579131eaf7ab21b commit 8b41cd2897fc4609d66d1a3d5579131eaf7ab21b Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 26 20:41:15 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //remoting Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //remoting. This CL was uploaded by git cl split. R=joedow@chromium.org Bug: 837148 Change-Id: Ia3674401a07b9c701e43965f99bb07b8f23b5a93 Reviewed-on: https://chromium-review.googlesource.com/1031173 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#554133} [modify] https://crrev.com/8b41cd2897fc4609d66d1a3d5579131eaf7ab21b/remoting/host/config_file_watcher_unittest.cc [modify] https://crrev.com/8b41cd2897fc4609d66d1a3d5579131eaf7ab21b/remoting/host/host_mock_objects.h [modify] https://crrev.com/8b41cd2897fc4609d66d1a3d5579131eaf7ab21b/remoting/host/ipc_desktop_environment_unittest.cc [modify] https://crrev.com/8b41cd2897fc4609d66d1a3d5579131eaf7ab21b/remoting/protocol/fake_connection_to_host.h [modify] https://crrev.com/8b41cd2897fc4609d66d1a3d5579131eaf7ab21b/remoting/protocol/video_frame_pump_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90eaf58b4c6d8bdda18f98bb8306157832aacd1e commit 90eaf58b4c6d8bdda18f98bb8306157832aacd1e Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 26 20:54:53 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //services Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //services. Bug: 837148 Change-Id: I5b60e5a997940cfc33f6cad2c90f7895eec41fac Reviewed-on: https://chromium-review.googlesource.com/1031177 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554148} [modify] https://crrev.com/90eaf58b4c6d8bdda18f98bb8306157832aacd1e/services/audio/input_stream_unittest.cc [modify] https://crrev.com/90eaf58b4c6d8bdda18f98bb8306157832aacd1e/services/audio/output_controller_unittest.cc [modify] https://crrev.com/90eaf58b4c6d8bdda18f98bb8306157832aacd1e/services/preferences/unittest_common.h [modify] https://crrev.com/90eaf58b4c6d8bdda18f98bb8306157832aacd1e/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f0b701ad077c288be15767b211717ee4533b628 commit 9f0b701ad077c288be15767b211717ee4533b628 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 26 21:09:05 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //media Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //media. R=dalecurtis@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieb8c499fd303028947809d214d09b1ed99b054f8 Reviewed-on: https://chromium-review.googlesource.com/1031013 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554150} [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/alsa/alsa_output_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/audio_debug_recording_helper_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/audio_input_controller_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/audio_input_stream_data_interceptor_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/audio_output_controller_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/audio_output_device_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/audio_output_proxy_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/mock_audio_source_callback.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/virtual_audio_input_stream_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/audio/virtual_audio_output_stream_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/base/audio_renderer_mixer_input_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/base/audio_renderer_mixer_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/base/mock_audio_renderer_sink.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/base/mock_demuxer_host.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/base/mock_filters.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/base/pipeline_impl_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/base/text_renderer_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/blink/mock_webassociatedurlloader.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/blink/multibuffer_data_source_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/blink/video_decode_stats_reporter_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/blink/video_frame_compositor_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/blink/webmediaplayer_impl_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/capture/video/file_video_capture_device_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/capture/video/video_capture_device_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/cast/net/pacing/mock_paced_packet_sender.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/cast/net/rtp/mock_rtp_payload_feedback.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/cast/test/mock_cast_transport.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/cdm/simple_cdm_allocator_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/audio_decoder_selector_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/blocking_url_protocol_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/decrypting_audio_decoder_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/decrypting_demuxer_stream_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/decrypting_video_decoder_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/ffmpeg_demuxer_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/ffmpeg_video_decoder_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/pipeline_controller_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/filters/video_decoder_selector_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/formats/webm/webm_parser_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/mojo/clients/mojo_audio_decoder_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/mojo/clients/mojo_cdm_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/mojo/clients/mojo_renderer_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/mojo/services/mojo_audio_input_stream_observer_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/mojo/services/mojo_audio_input_stream_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/mojo/services/mojo_audio_output_stream_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/renderers/audio_renderer_impl_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/renderers/renderer_impl_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/renderers/video_renderer_impl_unittest.cc [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/video/mock_video_decode_accelerator.h [modify] https://crrev.com/9f0b701ad077c288be15767b211717ee4533b628/media/video/mock_video_encode_accelerator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/657bf20a476b721ac0d069f8323ab7b134b626ee commit 657bf20a476b721ac0d069f8323ab7b134b626ee Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 26 21:50:02 2018 Chrome style plugin: also check virtual specifiers in Gmock objects. Originally, the style plugin skipped checks on virtual methods for Gmock objects since it would emit many spurious warnings. The source type classifier has improved since then to not emit warnings when the source is a third-party macro, so the style plugin no longer needs to suppress all checks on Gmock objects. The style plugin still skips the inline virtual body check on Gmock objects for convenience though. Bug: 837148 Change-Id: I1d0b6c89d6b4e4b47e9b706686959535fa35bc40 Reviewed-on: https://chromium-review.googlesource.com/1029773 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#554157} [modify] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/CMakeLists.txt [modify] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/ChromeClassTester.cpp [modify] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/ChromeClassTester.h [modify] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/FindBadConstructsAction.cpp [modify] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/FindBadConstructsConsumer.cpp [modify] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/FindBadConstructsConsumer.h [modify] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/Options.h [add] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/Util.cpp [add] https://crrev.com/657bf20a476b721ac0d069f8323ab7b134b626ee/tools/clang/plugins/Util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4496d0822a40dc1813e610828062783e397504b3 commit 4496d0822a40dc1813e610828062783e397504b3 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 26 21:52:15 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //net Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //net. Bug: 837148 Change-Id: I9f65b485272c931b18d4c5851ec7c29327b4f40b Reviewed-on: https://chromium-review.googlesource.com/1031192 Reviewed-by: Matt Mueller <mattm@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554161} [modify] https://crrev.com/4496d0822a40dc1813e610828062783e397504b3/net/cookies/cookie_monster_unittest.cc [modify] https://crrev.com/4496d0822a40dc1813e610828062783e397504b3/net/dns/mdns_cache_unittest.cc [modify] https://crrev.com/4496d0822a40dc1813e610828062783e397504b3/net/dns/mdns_client_unittest.cc [modify] https://crrev.com/4496d0822a40dc1813e610828062783e397504b3/net/socket/client_socket_pool_base_unittest.cc [modify] https://crrev.com/4496d0822a40dc1813e610828062783e397504b3/net/ssl/ssl_config_service_unittest.cc [modify] https://crrev.com/4496d0822a40dc1813e610828062783e397504b3/net/websockets/websocket_basic_stream_adapters_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad7d8fc5170de04205938c0018d9a1f263ef2dfe commit ad7d8fc5170de04205938c0018d9a1f263ef2dfe Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 26 22:25:49 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //extensions Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //extension. Bug: 837148 Change-Id: I0d567df519e54e8e4758fe74be2c7863a2a477a4 Reviewed-on: https://chromium-review.googlesource.com/1031183 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554171} [modify] https://crrev.com/ad7d8fc5170de04205938c0018d9a1f263ef2dfe/extensions/browser/api/idle/idle_api_unittest.cc [modify] https://crrev.com/ad7d8fc5170de04205938c0018d9a1f263ef2dfe/extensions/browser/extension_pref_value_map_unittest.cc [modify] https://crrev.com/ad7d8fc5170de04205938c0018d9a1f263ef2dfe/extensions/renderer/native_extension_bindings_system_test_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8473a3c1f0b3afb9382015c800a9215de3b9194e commit 8473a3c1f0b3afb9382015c800a9215de3b9194e Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 26 23:53:36 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //device Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //device. Bug: 837148 Change-Id: Ife28dad1274c14770ee8fdcaae286052e15ccfee Reviewed-on: https://chromium-review.googlesource.com/1031197 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554194} [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_adapter.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_device.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_discovery_session.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_gatt_characteristic.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_gatt_connection.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_gatt_descriptor.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_gatt_notify_session.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_gatt_service.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/bluetooth/test/mock_bluetooth_socket.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/usb/mock_usb_device.h [modify] https://crrev.com/8473a3c1f0b3afb9382015c800a9215de3b9194e/device/usb/mojo/device_manager_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea6cb7c2e95f3c6660922410b5407e837f8007e commit 3ea6cb7c2e95f3c6660922410b5407e837f8007e Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 27 01:59:34 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //dbus. Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //dbus. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 837148 Change-Id: I2af67226ab01879be81437c2bcf6a2e5e6002987 Reviewed-on: https://chromium-review.googlesource.com/1031184 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554265} [modify] https://crrev.com/3ea6cb7c2e95f3c6660922410b5407e837f8007e/dbus/mock_bus.h [modify] https://crrev.com/3ea6cb7c2e95f3c6660922410b5407e837f8007e/dbus/mock_exported_object.h [modify] https://crrev.com/3ea6cb7c2e95f3c6660922410b5407e837f8007e/dbus/mock_object_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ed4537c67e7a0e38981dbde6a3971debcedbba5 commit 5ed4537c67e7a0e38981dbde6a3971debcedbba5 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 27 02:00:04 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //content Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //content. R=kinuko@chromium.org Bug: 837148 Change-Id: Ic509a56551e78539f0c46daddad3509ef9cea908 Reviewed-on: https://chromium-review.googlesource.com/1030959 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554266} [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/download/download_browsertest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/download/download_manager_impl_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/download/drag_download_file_browsertest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/indexed_db/indexed_db_pre_close_task_queue_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/indexed_db/leveldb/mock_level_db.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/indexed_db/leveldb/mock_leveldb_factory.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/indexed_db/mock_indexed_db_factory.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/indexed_db/mock_mojo_indexed_db_callbacks.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/indexed_db/mock_mojo_indexed_db_database_callbacks.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/media/session/mock_media_session_observer.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/presentation/presentation_service_impl_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/renderer_host/media/mock_video_capture_provider.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/renderer_host/media/video_capture_manager_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/browser/renderer_host/p2p/socket_host_test_utils.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/public/test/mock_notification_observer.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/indexed_db/mock_webidbcallbacks.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/mojo_audio_output_ipc_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/renderer_webaudiodevice_impl_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/stream/media_stream_video_capturer_source_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/stream/mock_media_stream_video_source.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/stream/mock_mojo_media_stream_dispatcher_host.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/video_capture_impl_manager_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/webrtc/mock_peer_connection_impl.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/webrtc/mock_web_rtc_peer_connection_handler_client.h [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media/webrtc/webrtc_audio_renderer_unittest.cc [modify] https://crrev.com/5ed4537c67e7a0e38981dbde6a3971debcedbba5/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/247106733e005ed929010c6a75fb47a5907b96ea commit 247106733e005ed929010c6a75fb47a5907b96ea Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 27 03:00:43 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //jingle. Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //jingle. This CL was uploaded by git cl split. R=zea@chromium.org Bug: 837148 Change-Id: I0e7f4a597b80536b61e094fcf3c30b4003c69a9c Reviewed-on: https://chromium-review.googlesource.com/1031187 Reviewed-by: Nicolas Zea <zea@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554274} [modify] https://crrev.com/247106733e005ed929010c6a75fb47a5907b96ea/jingle/glue/fake_ssl_client_socket_unittest.cc [modify] https://crrev.com/247106733e005ed929010c6a75fb47a5907b96ea/jingle/glue/jingle_glue_mock_objects.h [modify] https://crrev.com/247106733e005ed929010c6a75fb47a5907b96ea/jingle/glue/mock_task.h [modify] https://crrev.com/247106733e005ed929010c6a75fb47a5907b96ea/jingle/notifier/base/fake_base_task.cc [modify] https://crrev.com/247106733e005ed929010c6a75fb47a5907b96ea/jingle/notifier/base/weak_xmpp_client_unittest.cc [modify] https://crrev.com/247106733e005ed929010c6a75fb47a5907b96ea/jingle/notifier/base/xmpp_connection_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c50b3f033970597b7c9e7f1be06edc5ee40649d5 commit c50b3f033970597b7c9e7f1be06edc5ee40649d5 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 27 03:01:55 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //gpu Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //gpu. R=piman@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ica08fb44c7c548c3467d96b13888b4ce87956350 Reviewed-on: https://chromium-review.googlesource.com/1031191 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554277} [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/client/client_test_helper.h [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/client/cmd_buffer_helper_test.cc [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/client/transfer_buffer_unittest.cc [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/service/error_state_mock.h [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/service/gl_context_mock.h [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/service/gl_surface_mock.h [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/service/gles2_cmd_decoder_mock.h [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/service/mocks.h [modify] https://crrev.com/c50b3f033970597b7c9e7f1be06edc5ee40649d5/gpu/command_buffer/service/raster_decoder_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff0961b08c823f09670a47084d32420191f9cc81 commit ff0961b08c823f09670a47084d32420191f9cc81 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 27 03:02:59 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //cc Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //cc. R=enne@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If5a2518598d97444695e70bfd7b2777ffbd838b1 Reviewed-on: https://chromium-review.googlesource.com/1030960 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554279} [modify] https://crrev.com/ff0961b08c823f09670a47084d32420191f9cc81/cc/input/scrollbar_animation_controller_unittest.cc [modify] https://crrev.com/ff0961b08c823f09670a47084d32420191f9cc81/cc/input/single_scrollbar_animation_controller_thinning_unittest.cc [modify] https://crrev.com/ff0961b08c823f09670a47084d32420191f9cc81/cc/layers/video_frame_provider_client_impl_unittest.cc [modify] https://crrev.com/ff0961b08c823f09670a47084d32420191f9cc81/cc/test/mock_layer_tree_mutator.h [modify] https://crrev.com/ff0961b08c823f09670a47084d32420191f9cc81/cc/test/test_skcanvas.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51249958806ff2ba5cabbe7f710d4413f017151d commit 51249958806ff2ba5cabbe7f710d4413f017151d Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 27 06:48:50 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //chrome Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //chrome. R=thestig@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ieb2216cb355b5cba4406a43dbb6a82f3a5e16875 Reviewed-on: https://chromium-review.googlesource.com/1031051 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554329} [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/autofill/content_autofill_driver_browsertest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/content_settings/content_settings_browsertest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/content_settings/content_settings_mock_observer.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/content_settings/host_content_settings_map_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/content_settings/mock_settings_observer.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/content_settings/tab_specific_content_settings_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/download/download_commands_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/download/download_item_model_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/api/identity/gaia_web_auth_flow_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/api/image_writer_private/test_utils.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/api/mdns/mdns_api_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/api/storage/settings_apitest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/event_router_forwarder_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/extensions/menu_manager_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/local_discovery/service_discovery_client_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/media/router/test/media_router_mojo_test.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/media/router/test/mock_media_router.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/media/router/test/mock_mojo_media_router.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/media/router/test/test_helper.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/media/webrtc/webrtc_event_log_uploader_impl_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/media/webrtc/webrtc_rtp_dump_writer_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/media_galleries/media_galleries_dialog_controller_mock.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/predictors/loading_test_util.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/predictors/preconnect_manager_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/printing/cloud_print/privet_http_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/printing/cloud_print/privet_url_fetcher_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/profile_resetter/profile_resetter_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/profiles/gaia_info_update_service_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/safe_browsing/incident_reporting/mock_incident_receiver.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/service_process/service_process_control_browsertest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/speech/extension_api/tts_extension_apitest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/supervised_user/supervised_user_browsertest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/sync_file_system/local/mock_sync_status_observer.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/sync_file_system/mock_local_change_processor.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/sync_file_system/mock_remote_change_processor.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/sync_file_system/mock_remote_file_sync_service.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/sync_file_system/sync_file_system_service_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/translate/translate_manager_render_view_host_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/media_router/presentation_receiver_window_controller_browsertest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/page_info/page_info_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/passwords/manage_passwords_test.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/search/search_ipc_router_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/toolbar/media_router_action_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/views/media_router/cast_dialog_sink_button_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/webui/fileicon_source_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/usb/usb_chooser_controller_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/browser/vr/test/mock_browser_ui_interface.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/common/safe_browsing/file_type_policies_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/common/search/mock_embedded_search_client.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/renderer/extensions/extension_localization_peer_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/renderer/safe_browsing/mock_feature_extractor_clock.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/service/cloud_print/printer_job_handler_unittest.cc [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/test/data/webui/async_gen.h [modify] https://crrev.com/51249958806ff2ba5cabbe7f710d4413f017151d/chrome/test/data/webui/chrome_send_browsertest.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8f0b40b3c702ecbfe82fe2c44cb5f18492e9c7c commit c8f0b40b3c702ecbfe82fe2c44cb5f18492e9c7c Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 27 17:28:20 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //base Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //base. Bug: 837148 Change-Id: Id5e0a556b4c4c501076f586068aef4034e0156cd Reviewed-on: https://chromium-review.googlesource.com/1031016 Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554413} [modify] https://crrev.com/c8f0b40b3c702ecbfe82fe2c44cb5f18492e9c7c/base/bind_unittest.cc [modify] https://crrev.com/c8f0b40b3c702ecbfe82fe2c44cb5f18492e9c7c/base/task_scheduler/scheduler_worker_unittest.cc [modify] https://crrev.com/c8f0b40b3c702ecbfe82fe2c44cb5f18492e9c7c/base/test/mock_devices_changed_observer.h [modify] https://crrev.com/c8f0b40b3c702ecbfe82fe2c44cb5f18492e9c7c/base/threading/scoped_blocking_call_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67848525e5578a7fd49491230b4e6e6baf163020 commit 67848525e5578a7fd49491230b4e6e6baf163020 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 27 22:04:41 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //components Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //components. R=blundell@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I14f72dd481c02acdc8ea35d58d9fb4801140d353 Reviewed-on: https://chromium-review.googlesource.com/1031090 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554524} [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/autofill/content/browser/content_autofill_driver_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/autofill/core/browser/autocomplete_history_manager_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/autofill/core/browser/autofill_external_delegate_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/autofill/core/browser/form_data_importer_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/autofill/core/browser/webdata/web_data_service_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/bookmarks/test/mock_bookmark_model_observer.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/browser_sync/profile_sync_service_mock.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/browser_sync/profile_sync_service_startup_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/cast_channel/cast_transport_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/component_updater/component_installer_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/component_updater/component_updater_service_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/component_updater/mock_component_updater_service.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/dom_distiller/core/distiller_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/dom_distiller/core/dom_distiller_service_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/dom_distiller/core/dom_distiller_store_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/dom_distiller/core/fake_distiller.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/dom_distiller/core/task_tracker_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/download/content/public/all_download_item_notifier_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/download/internal/background_service/in_memory_download_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/download/public/common/mock_download_file.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/feed/core/feed_image_manager_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/image_fetcher/core/mock_image_decoder.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/mirroring/browser/single_client_video_capture_host_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/ntp_snippets/mock_content_suggestions_provider.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/offline_pages/core/prefetch/mock_thumbnail_fetcher.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/omnibox/browser/base_search_provider_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/password_manager/core/browser/android_affiliation/affiliation_backend_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/cloud_policy_service_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/device_management_service_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/mock_cloud_external_data_manager.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/mock_cloud_policy_client.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/mock_cloud_policy_store.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/mock_device_management_service.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/cloud/mock_user_cloud_policy_store.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/mock_configuration_policy_provider.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/mock_policy_service.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/policy/core/common/schema_registry_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/prefs/pref_change_registrar_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/prefs/pref_notifier_impl_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/safe_browsing/password_protection/mock_password_protection_service.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/safe_browsing/triggers/mock_trigger_manager.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/suggestions/suggestions_service_impl_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/driver/async_directory_type_controller_mock.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/driver/async_directory_type_controller_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/driver/backend_migrator_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/driver/data_type_manager_mock.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/driver/frontend_data_type_controller_mock.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/driver/model_association_manager_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/driver/model_associator_mock.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/engine_impl/sync_manager_impl_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/engine_impl/syncer_proto_util_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/js/js_test_util.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/model/change_processor_mock.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/model/mock_model_type_change_processor.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/sync/model/sync_error_factory_mock.h [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/update_client/update_client_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/viz/service/display/gl_renderer_unittest.cc [modify] https://crrev.com/67848525e5578a7fd49491230b4e6e6baf163020/components/viz/test/begin_frame_source_test.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2e3f7a69aedde91cda95918f44e5ff163f4bfff commit a2e3f7a69aedde91cda95918f44e5ff163f4bfff Author: Daniel Cheng <dcheng@chromium.org> Date: Mon Apr 30 17:33:56 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //mojo. Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //mojo. This CL was uploaded by git cl split. R=jam@chromium.org Bug: 837148 Change-Id: Iface36adbfe57737c6601cc17d528e04254ee3df Reviewed-on: https://chromium-review.googlesource.com/1031186 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554806} [modify] https://crrev.com/a2e3f7a69aedde91cda95918f44e5ff163f4bfff/mojo/edk/system/channel_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ea5bb72773c38c771c56b18547a3ec7b8fc7e9e commit 9ea5bb72773c38c771c56b18547a3ec7b8fc7e9e Author: Daniel Cheng <dcheng@chromium.org> Date: Mon Apr 30 19:08:34 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //google_apis/gaia. Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //google_apis/gaia. This CL was uploaded by git cl split. R=rogerta@chromium.org Bug: 837148 Change-Id: Ia35de72ebe190980cbce1b3a8b0e96bd7f6fa246 Reviewed-on: https://chromium-review.googlesource.com/1031198 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554833} [modify] https://crrev.com/9ea5bb72773c38c771c56b18547a3ec7b8fc7e9e/google_apis/gaia/gaia_auth_fetcher_unittest.cc [modify] https://crrev.com/9ea5bb72773c38c771c56b18547a3ec7b8fc7e9e/google_apis/gaia/gaia_oauth_client_unittest.cc [modify] https://crrev.com/9ea5bb72773c38c771c56b18547a3ec7b8fc7e9e/google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc [modify] https://crrev.com/9ea5bb72773c38c771c56b18547a3ec7b8fc7e9e/google_apis/gaia/oauth2_api_call_flow_unittest.cc [modify] https://crrev.com/9ea5bb72773c38c771c56b18547a3ec7b8fc7e9e/google_apis/gaia/oauth2_mint_token_flow_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d70e1bc09efc9905323841f8e58fd223bad0f93b commit d70e1bc09efc9905323841f8e58fd223bad0f93b Author: Daniel Cheng <dcheng@chromium.org> Date: Wed May 02 15:20:46 2018 Chrome style plugin: enable virtual specifier checks for Gmock objects in //headless. Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //headless. This CL was uploaded by git cl split. R=dvallet@chromium.org Bug: 837148 Change-Id: I1b20f722f974410fa64cab3bd4c2fc56732bbe42 Reviewed-on: https://chromium-review.googlesource.com/1031199 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555392} [modify] https://crrev.com/d70e1bc09efc9905323841f8e58fd223bad0f93b/headless/lib/headless_web_contents_browsertest.cc
Comment 1 by dcheng@chromium.org
, Apr 26 2018Status: Started (was: Available)