New issue
Advanced search Search tips

Issue 837144 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Apr 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 832173



Sign in to add a comment

Regression: Button outline of 'Reload' button is missing on error dialog box.

Reported by db...@etouch.net, Apr 26 2018 
Chrome Version:68.0.3409.0 Revision 14c5d49cfb5674793fe0d5223cc4cf257732a8ff-refs/heads/master@{#553714}(32/64 bit)
OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
(1) Launch chrome, navigate to http://www.orimi.com/pdf-test.pdf pdf file.
(2) Right click on page and select Inspect option, now press Ctrl+R (Error dialg gets opened)
(3) Observe Reload button.

Actual: Button outline of Reload button is missing on error dialog.

Expected: Button outline of Reload button should seen on error dialog.

This is a regression issue, broken in 'M68', will soon update the other info:

Good Build:68.0.3406.0
Bad Build: 68.0.3409.0

Comment 1 by db...@etouch.net, Apr 26 2018

Labels: hasbisect OS-Linux OS-Mac
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect info : 

https://chromium.googlesource.com/chromium/src/+log/b3d7ea8cb1769efdcc5ba3a3a8a359f0a42366a0..f496b3ba7952691970a00e8f1a4d0bcd0de47ce0?pretty=fuller&n=10000

Suspecting: r553382

@dpapad: Could you please help to reassign if your change is not the cause for this change.

Note:
1.Error shown while doing with new-script(RuntimeError: We don't have enough builds to bisect. revlist: [])
2.Unable to provide bisect using per-revision script,Hence providing bisect with old script.
3.Issue is also Mac(10.12.6,10.13.1,10.13.5),Linux(14.04LTS) OS.


Thank You!

Comment 2 by db...@etouch.net, Apr 26 2018

Screenshot.png
15.1 KB View Download
Actual_PDF.mp4
479 KB View Download

Comment 3 by dpa...@chromium.org, Apr 26 2018

Status: Started (was: Assigned)
This was caused because the paper-button styling was moved from shared_style_css.html to paper_button_style_css.html. Should be easy to fix.

Comment 4 by dpa...@chromium.org, Apr 26 2018

Blocking: 832173
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/985b443b911bfcfa7025aba207203ce9c589224f

commit 985b443b911bfcfa7025aba207203ce9c589224f
Author: dpapad <dpapad@chromium.org>
Date: Thu Apr 26 23:52:21 2018

PDF Viewer: Fix "Reload" button styling in error dialog.

paper-button styles were moved from cr-shared-style to paper-button-style
at r553689.

Bug:  837144 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6f58d55bee359c199552370b11a0da8661264609
Reviewed-on: https://chromium-review.googlesource.com/1030822
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554193}
[modify] https://crrev.com/985b443b911bfcfa7025aba207203ce9c589224f/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html

Comment 7 by dpa...@chromium.org, Apr 27 2018

Status: Fixed (was: Started)

Comment 8 by db...@etouch.net, Apr 27 2018

Labels: TE-Verified-M68 TE-Verified-68.0.3410.0
Update : 
Retested above issue in latest canary build #68.0.3410.0 on Windows(7,8,8.1,10) Mac(10.12.6,10.13.1,10.13.5) and Linux(14.04LTS) OS and the issue is fixed.
Kindly review an attached screen-cast.

Thank you!
Canary_Fix.mp4
393 KB View Download

Comment 9 by dpa...@chromium.org, May 22 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
►

Sign in to add a comment