New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837139 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 0
Type: Bug-Regression



Sign in to add a comment

Regression: Browser crash is seen on hitting Enter Key for Reset Setting button.

Reported by aiman.an...@etouch.net, Apr 26 2018

Issue description

Chrome Version: 68.0.3409.0 (Official Build) Revision14c5d49cfb5674793fe0d5223cc4cf257732a8ff-refs/heads/master@{#553714}  (32/64 Bit)
 	
OS: Win(7,8,8.1,10), and Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/resetProfileSettings?origin=userclick.
2. Press tab and bring focus on Reset Setting Button.
3. Hit Enter key and observe.

Actual Result: Browser crash is seen on hitting enter key for Reset Key button.
Expected Result: Browser should not crash on hitting enter key for Reset Key button.

Uploaded Crash Report ID e1ff4182da471732 (Local Crash ID: d60cbba9-6cda-42f6-be00-71d452fc8332)

This is a regression issue, broken in M-68  series, and will soon update other info.

Good Build: 68.0.3406.0
Bad Build: 68.0.3409.0 



 
Actual_Result.mp4
911 KB View Download
Labels: RegressedIn-68 FoundIn-68 Target-68 OS-Mac
Owner: pilgrim@chromium.org
Status: Assigned (was: Unconfirmed)
Hi

Unable to provide bisect via per-revision script (as builds are not getting generated, it gives 'not enough builds error') and old bisect script (getting all good builds even after increasing the bisect range.)
Hence, providing bisect manually.

Change-Log URL:
https://chromium.googlesource.com/chromium/src/+log/68.0.3406.0..68.0.3409.0?pretty=fuller&n=10000

Suspecting:
https://chromium.googlesource.com/chromium/src/+/72cd15a2564239beb8eacb23527ef1d0aa8f9406

@pilgrim: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is also seen on Mac(10.12.6,10.13.1,10.13.5) OS.

Thank You!
Cc: pbomm...@chromium.org gov...@chromium.org abdulsyed@chromium.org ligim...@chromium.org pilgrim@google.com mmenke@chromium.org ajha@chromium.org
Labels: -Pri-1 ReleaseBlock-Dev Pri-0
Please find the stack trace for the crash:
------------------------------------------
Thread 0 (id: 3216) CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000000 ] MAGIC SIGNATURE THREAD
Stack Quality100%Show frame trust levels
0x000007fedf278b8a	(chrome.dll -reset_report_uploader.cc:87 )	ResetReportUploader::DispatchReport(reset_report::ChromeResetReport const &)
0x000007fedf057988	(chrome.dll -reset_settings_handler.cc:180 )	settings::ResetSettingsHandler::OnResetProfileSettingsDone(std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,reset_report::ChromeResetReport_ResetRequestOrigin)
0x000007fedf057c88	(chrome.dll -bind_internal.h:447 )	base::internal::FunctorTraits<void (settings::ResetSettingsHandler::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> >, bool, reset_report::ChromeResetReport_ResetRequestOrigin),void>::Invoke<const base::WeakPtr<settings::ResetSettingsHandler> &,const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &,const bool &,const reset_report::ChromeResetReport_ResetRequestOrigin &>
0x000007fedf057c12	(chrome.dll -bind_internal.h:586 )	base::internal::Invoker<base::internal::BindState<void (settings::ResetSettingsHandler::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> >, bool, reset_report::ChromeResetReport_ResetRequestOrigin),base::WeakPtr<settings::ResetSettingsHandler>,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,reset_report::ChromeResetReport_ResetRequestOrigin>,void ()>::Run
0x000007fedd0c66a4	(chrome.dll -task_annotator.cc:101 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x000007fedd0c614b	(chrome.dll -message_loop.cc:319 )	base::MessageLoop::RunTask(base::PendingTask *)
0x000007fedd0c5b97	(chrome.dll -message_loop.cc:373 )	base::MessageLoop::DoWork()
0x000007fedd1dcec8	(chrome.dll -message_pump_win.cc:174 )	base::MessagePumpForUI::DoRunLoop()
0x000007fedd116997	(chrome.dll -message_pump_win.cc:57 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x000007fedd0c5710	(chrome.dll -run_loop.cc:130 )	base::RunLoop::Run()
0x000007fedd4b3596	(chrome.dll -chrome_browser_main.cc:2122 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x000007fedd4b338d	(chrome.dll -browser_main_loop.cc:975 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x000007fedd4b3338	(chrome.dll -browser_main_runner.cc:161 )	content::BrowserMainRunnerImpl::Run()
0x000007fedd0b9f49	(chrome.dll -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const &)
0x000007fedd0b9de6	(chrome.dll -content_main_runner.cc:633 )	content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x000007fedd0b9c90	(chrome.dll -content_main_runner.cc:922 )	content::ContentMainRunnerImpl::Run()
0x000007fedd0a566a	(chrome.dll -main.cc:452 )	service_manager::Main(service_manager::MainParams const &)
0x000007fedd0a5137	(chrome.dll -content_main.cc:19 )	content::ContentMain(content::ContentMainParams const &)
0x000007fedd0a1c01	(chrome.dll -chrome_main.cc:101 )	ChromeMain
0x000000013f83351b	(chrome.exe -main_dll_loader_win.cc:200 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x000000013f831698	(chrome.exe -chrome_exe_main_win.cc:230 )	wWinMain
0x000000013f90c322	(chrome.exe -exe_common.inl:283 )	__scrt_common_main_seh
0x772059cc	(KERNEL32.dll + 0x000159cc )	BaseThreadInitThunk
0x7736383c	(ntdll.dll + 0x0005383c )	RtlUserThreadStart

1)This crash is first started on 68.0.3409.0 and on latest Canary 68.0.3409.0 seeing 1 from 1 different clients.
2)This crash seen on Windows>Browser and it is in 2nd rank position.
3)This crash not seen on latest Dev,Beta & Stable builds.

68.0.3409.0	80.00%	4  - Canary

Link to the list of builds:
---------------------------
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27ResetReportUploader%3A%3ADispatchReport%27

Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!

Comment 3 by ajha@chromium.org, Apr 26 2018

Cc: battre@chromium.org
pligrim@/battré@: Could you please get the suspected CL reverted as this will block M-68 dev release(tentatively tomorrow).
.
looking.
This is the #1 crash in latest canary, which is the Dev RC. Could you please revert the same 3409 branch.

Comment 9 by ajha@chromium.org, Apr 27 2018

Windows canary version: 68.0.3409.2 was live in production for 5 hrs and didn't report any crashes for magic signature 'ResetReportUploader::DispatchReport'.

Revert and merge to 3409 branch seems to be working as intended.
Labels: TE-Verified-68.0.3409.2 TE-Verified-M68
Hi,

Retested the above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5) and Linux (14.04 LTS) OS using Dev build #68.0.3409.2 and issue is fixed. Now browser crash is not seen on hitting enter key for Reset Button.

Kindly refer the attached screen-cast

Thank You
Current_Result.mov
8.1 MB View Download
If there is no pending work, can we tag the bug as fixed?
Status: Fixed (was: Assigned)

Sign in to add a comment