New issue
Advanced search Search tips

Issue 837137 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Apr 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 832173



Sign in to add a comment

Regression: Button size doesnot appear according to font size on settings page.

Reported by db...@etouch.net, Apr 26 2018 
Chrome Version:68.0.3409.0 Revision 14c5d49cfb5674793fe0d5223cc4cf257732a8ff-refs/heads/master@{#553714}(32/64 bit)
OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://settings/appearance page and change font size to 'Very Large'.
(2) Then navigate to 'chrome://settings/languages' page and observe Change button.

Actual: Change button doesnot appear according to font size.

Expected: Change button should appear according to font size.

This is a regression issue, broken in 'M68', will soon update the other info:

Good Build:68.0.3406.0
Bad Build: 68.0.3409.0

Comment 1 by db...@etouch.net, Apr 26 2018

Labels: hasbisect OS-Linux OS-Mac OS-Windows
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect info : 

https://chromium.googlesource.com/chromium/src/+log/b3d7ea8cb1769efdcc5ba3a3a8a359f0a42366a0..f496b3ba7952691970a00e8f1a4d0bcd0de47ce0?pretty=fuller&n=10000

Suspecting: r553382

@dpapad: Could you please help to reassign if your change is not the cause for this change.

Note:
1.Error shown while doing with new-script(RuntimeError: We don't have enough builds to bisect. revlist: [])
2.Unable to provide bisect using per-revision script,Hence providing bisect with old script.
3.Issue is also Mac(10.12.6,10.13.1,10.13.5),Linux(14.04LTS) OS.


Thank You!
Actual_Font.mp4
785 KB View Download
Screenshot.png
23.8 KB View Download

Comment 2 by rbasuvula@chromium.org, Apr 26 2018

Labels: ReleaseBlock-Stable
As this is a recent regression adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!

Comment 3 by dpa...@chromium.org, Apr 26 2018

Status: Started (was: Assigned)

Comment 4 by dpa...@chromium.org, Apr 26 2018

Blocking: 832173
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f701cb25f1c31037a185f1a5b767156c2d6e0254

commit f701cb25f1c31037a185f1a5b767156c2d6e0254
Author: dpapad <dpapad@chromium.org>
Date: Thu Apr 26 23:57:28 2018

WebUI MD Refresh: Restore button size to 13px, respect font prefs.

Bug:  837190 , 832173 , 837137 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I185bf0e3c4e0a4bdb3a15d4288c60c91bed1221b
Reviewed-on: https://chromium-review.googlesource.com/1030881
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554197}
[modify] https://crrev.com/f701cb25f1c31037a185f1a5b767156c2d6e0254/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 6 by dpa...@chromium.org, Apr 27 2018

Status: Fixed (was: Started)

Comment 7 by db...@etouch.net, Apr 27 2018

Labels: TE-Verified-M68 TE-Verified-68.0.3410.0
Update : 
Retested above issue in latest canary build #68.0.3410.0 on Windows(7,8,8.1,10) Mac(10.12.6,10.13.1,10.13.5) and Linux(14.04LTS) OS and the issue is fixed.
Kindly review an attached screen-cast.

Thank you!
Fix_Canary.mp4
670 KB View Download

Comment 8 by dpa...@chromium.org, May 22 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
►

Sign in to add a comment