"WebAuthFocusTest.Focus" is flaky |
|
Issue description"WebAuthFocusTest.Focus" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyIQsSBUZsYWtlIhZXZWJBdXRoRm9jdXNUZXN0LkZvY3VzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3b8f3551053d5271f7eb5c8967a189aadc144bb commit c3b8f3551053d5271f7eb5c8967a189aadc144bb Author: Max Morin <maxmorin@chromium.org> Date: Thu Apr 26 09:53:30 2018 Revert "webauthn: require focused tab, rather than focused frame." This reverts commit 3a01c2259dfad218493b628483fe8e1d9cb2acbc. Reason for revert: New test is flaky: crbug.com/837124. Original change's description: > webauthn: require focused tab, rather than focused frame. > > Kim points out in the bug that the current logic (see > https://chromium-review.googlesource.com/c/chromium/src/+/991073) > doesn't allow dev tools to be focused, so it's not possible to trigger > webauthn requests from the dev tools console. > > Nasko thought that the addition of a ContentBrowserClient API was too > large a hammer too. I've not been able to come up with any cleaner > solution however, but this change perhaps makes the hammer more > reasonable: > > In order to address the devtools issue, this change switches the focus > check to requiring that the tab be active in the focused window. (This > also matches what the cryptotoken extension does.) This means that it > has to chrome/ logic, rather than content/ logic, but we already had to > add an API to ContentBrowserClient for this and we can reuse that to > solve this problem too. > > Additionally, this change adds an interactive_ui_test to ensure that we > don't regress. > > Bug: 827266 ,836203 > Change-Id: I62226fc0366a83dc69d9cb32016108bdbe590d29 > Reviewed-on: https://chromium-review.googlesource.com/1007637 > Commit-Queue: Adam Langley <agl@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553838} TBR=nasko@chromium.org,thestig@chromium.org,agl@chromium.org,engedy@chromium.org No-Try: true Bug: 827266 , 836203, 837124 Change-Id: I9a243c93eac8d27eb33fae22c703f1faaeb7b83e Reviewed-on: https://chromium-review.googlesource.com/1029970 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553968} [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/chrome/browser/DEPS [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/chrome/browser/devtools/BUILD.gn [delete] https://crrev.com/a62ef37c0f828a8f85db123feefbc49f373b8c41/chrome/browser/webauth_interactive_uitest.cc [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/chrome/test/BUILD.gn [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/content/browser/webauth/authenticator_impl.cc [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/content/browser/webauth/authenticator_impl_unittest.cc [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/content/public/browser/content_browser_client.cc [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/content/public/browser/content_browser_client.h [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/device/fido/virtual_fido_device.h [modify] https://crrev.com/c3b8f3551053d5271f7eb5c8967a189aadc144bb/device/fido/virtual_u2f_device.cc |
|
►
Sign in to add a comment |
|
Comment 1 by maxmorin@chromium.org
, Apr 26 2018Owner: agl@chromium.org
Status: Assigned (was: Untriaged)