New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837116 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-VR
Proj-XR



Sign in to add a comment

Hook up ARCoreDevice to ARCore library

Project Member Reported by lincolnfrog@chromium.org, Apr 26 2018

Issue description

Once the ARCore library is added to third_party, change the ARCoreDevice code to call into the real ARCore API and produce camera images / poses / etc. through ARCore.
 
Labels: M-68 OS-Android
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778

commit 1cfbf9f53aa4eba9ed7fbbbc58e149667a463778
Author: Ian Vollick <vollick@chromium.org>
Date: Fri May 18 16:47:20 2018

Hook up ARCoreDevice to real ARCore binaries

This hooks up the stub ARCoreDevice code with
the real ARCore libraries so that AR
is actually functional and generates proper
poses and camera frames.

Bug:  837116 , 837947 ,841555
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I78ae38aaa577899f392e058bf0e36d5b34d7147d
Reviewed-on: https://chromium-review.googlesource.com/1020199
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559923}
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/android/java/AndroidManifest.xml
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/android/java_sources.gni
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/app/android/DEPS
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/BUILD.gn
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/DEPS
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/ar_image_transport.cc
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/ar_image_transport.h
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore.h
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_gl.h
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_gl_thread.cc
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_gl_thread.h
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_impl.cc
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_impl.h
[delete] https://crrev.com/8af5e106aa826f15b44303af358312d3a7e35c96/chrome/browser/android/vr/arcore_device/arcore_interface.h
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_java_utils.h
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_shim.cc
[add] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/arcore_shim.h
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/fake_arcore.cc
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/arcore_device/fake_arcore.h
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/android/vr/vr_shell_delegate.cc
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/vr/service/vr_device_manager.cc
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/chrome/browser/vr/testapp/vr_testapp.cc
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/device/vr/BUILD.gn
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/device/vr/buildflags/BUILD.gn
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/device/vr/buildflags/buildflags.gni
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/device/vr/vr_display_impl.cc
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/third_party/arcore-android-sdk/README.chromium
[modify] https://crrev.com/1cfbf9f53aa4eba9ed7fbbbc58e149667a463778/third_party/blink/renderer/modules/xr/xr_frame_provider.cc

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a81ee32602493a68125e60b992c702eab7b6905f

commit a81ee32602493a68125e60b992c702eab7b6905f
Author: Klaus Weidner <klausw@chromium.org>
Date: Wed Jun 06 22:02:29 2018

WebXR: Handle AR tracking loss

When ARCore loses tracking, continue providing camera images, but send null
poses. This allows JS applications to handle tracking loss, i.e. by displaying
a pose-independent info message.

BUG:  837116 
Change-Id: I92238f1bf158ca2714a4068ddba8ac5bbdb123fc
Reviewed-on: https://chromium-review.googlesource.com/1043207
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565051}
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/chrome/browser/android/vr/arcore_device/arcore.h
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/chrome/browser/android/vr/arcore_device/arcore_impl.cc
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/chrome/browser/android/vr/arcore_device/arcore_impl.h
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/chrome/browser/android/vr/arcore_device/fake_arcore.cc
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/chrome/browser/android/vr/arcore_device/fake_arcore.h
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/device/vr/public/mojom/vr_service.mojom
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/third_party/blink/renderer/modules/xr/xr_frame_provider.cc
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/third_party/blink/renderer/modules/xr/xr_frame_provider.h
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/third_party/blink/renderer/modules/xr/xr_session.h
[modify] https://crrev.com/a81ee32602493a68125e60b992c702eab7b6905f/third_party/blink/renderer/modules/xr/xr_webgl_layer.cc

Components: Blink>WebXR

Sign in to add a comment