New issue
Advanced search Search tips

Issue 837111 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

WebXR: Clearly separate IDL-related methods, inherited methods, and other public functions

Project Member Reported by ddorwin@chromium.org, Apr 26 2018

Issue description

It's not very clear where in the XRSession class definition that IDL-related methods end. Furthermore, overrides follow and are mixed with other non-inherited non-IDL-related methods. We should reorder these and make it clearer in this class definition as well as others.

See, for example, media_key_session.h.


 
Labels: -M-68 M-69
Components: Blink>WebXR
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
Hello, can I start this issue?
Cc: billorr@chromium.org
Yes.  The methods are mostly ordered correctly, so it may be as simple as adding a comment to delineate the idl methods from non-idl methods.

envrionmentIntegration() appears to be the one exception where its ordered with idl methods and shouldn't be.

Sign in to add a comment