"DownloadContentTest.ForceDownloadMultipartRelatedPage" is flaky |
|||
Issue description"DownloadContentTest.ForceDownloadMultipartRelatedPage" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQAsSBUZsYWtlIjVEb3dubG9hZENvbnRlbnRUZXN0LkZvcmNlRG93bmxvYWRNdWx0aXBhcnRSZWxhdGVkUGFnZQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77dc96f5b3853e6e40755c637cfd57888375c313 commit 77dc96f5b3853e6e40755c637cfd57888375c313 Author: Rakina Zata Amni <rakina@chromium.org> Date: Thu Apr 26 05:08:54 2018 Disable flaky DownloadContentTest.ForceDownloadMultipartRelatedPage TBR=qinmin@chromium.org Bug: 837104 Change-Id: I8f59a618815ce71de395af29795b891529a75ef4 Reviewed-on: https://chromium-review.googlesource.com/1029554 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#553923} [modify] https://crrev.com/77dc96f5b3853e6e40755c637cfd57888375c313/content/browser/download/download_browsertest.cc
,
Apr 26 2018
so this is caused by a race condition between content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread() and SetBrowserClientForTesting(), both trying to access the browser instance
,
May 3 2018
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de94d59196994afbb5f26865535b7154163fa53a commit de94d59196994afbb5f26865535b7154163fa53a Author: Jian Li <jianli@chromium.org> Date: Tue Jun 05 20:16:50 2018 Move the browser client initialization for MHTML download tests to SetUp This is to avoid potential data race issues in tests. Bug: 836442 , 837104 Change-Id: Ic46e2834e1a50fa3644e6fe5ec0d4ef874e0b0a0 Reviewed-on: https://chromium-review.googlesource.com/1086156 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#564638} [modify] https://crrev.com/de94d59196994afbb5f26865535b7154163fa53a/content/browser/download/download_browsertest.cc
,
Jun 5 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rakina@chromium.org
, Apr 26 2018Labels: -Sheriff-Chromium
Owner: qin...@chromium.org