movementX/Y shouldn't apply frame_scale |
||
Issue descriptionChrome Version: 66.0.3359.117 OS: All MovementX/Y is screenX/Y - old screenX/y, should not apply frame_scale. We should remove them in: WebMouseEvent::MovementInRootFrame(), WebPointerEvent::WebPointerEventInRootFrame(), WebTouchEvent::TouchPointInRootFrame()
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/733e8096c00900e0051c42701760bdc374451b6b commit 733e8096c00900e0051c42701760bdc374451b6b Author: Ella Ge <eirage@chromium.org> Date: Wed Nov 07 01:02:32 2018 remove frame_scale from movementX/Y The pointerlock spec defines MovementX/Y follow the scale of screenX/Y, which is not scaled by pinch-zoom scale. https://w3c.github.io/pointerlock/#dom-mouseevent-movementx Although currently in chrome, it is movement is in physical pixel, it should still be unscaled value. We should not apply frame_scale to movement_x/y. Note that right now WebMouseEvent::MovementInRootFrame is not used anywhere other than test. we only scales the touch PointerEvent but not mouse event. This CL removes unused WebMouseEvent::MovementInRootFrame, and also makes touch pointer event movementX/Y not scaled by pinch zoom. Bug: 837004 Change-Id: I4bb39b3b01ecbd77c58fd4501a5c63ccb44e5a5b Reviewed-on: https://chromium-review.googlesource.com/c/1313280 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#605901} [modify] https://crrev.com/733e8096c00900e0051c42701760bdc374451b6b/third_party/blink/public/platform/web_mouse_event.h [modify] https://crrev.com/733e8096c00900e0051c42701760bdc374451b6b/third_party/blink/renderer/core/events/web_input_event_conversion_test.cc [modify] https://crrev.com/733e8096c00900e0051c42701760bdc374451b6b/third_party/blink/renderer/core/input/pointer_event_manager_test.cc [modify] https://crrev.com/733e8096c00900e0051c42701760bdc374451b6b/third_party/blink/renderer/platform/web_mouse_event.cc [modify] https://crrev.com/733e8096c00900e0051c42701760bdc374451b6b/third_party/blink/renderer/platform/web_pointer_event.cc [modify] https://crrev.com/733e8096c00900e0051c42701760bdc374451b6b/third_party/blink/renderer/platform/web_touch_event.cc
,
Nov 7
|
||
►
Sign in to add a comment |
||
Comment 1 by eirage@chromium.org
, Nov 5Owner: eirage@chromium.org
Status: Assigned (was: Available)