New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 837003 link

Starred by 1 user
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Browser doesn't go back into PiP mode when PiP was exited.

Project Member Reported by apaci...@chromium.org, Apr 25 2018 
Repro steps:
1. Pip a video.
2. Exit pip mode.
3. Attempt tp pip the video again.
4. Video media player shows "in pip mode" interstitial, but no window appears.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af4ffc5c1648e8f0d7a436297e3c48ada8f77741

commit af4ffc5c1648e8f0d7a436297e3c48ada8f77741
Author: Jennifer Apacible <apacible@chromium.org>
Date: Thu Apr 26 18:58:31 2018

[Picture in Picture] Allow re-entering PiP mode after exiting.

Currently, the Picture-in-Picture window can only be shown once during
a browser session because the window is closed after exiting PiP mode.

This change hides the Picture-in-Picture window rather than completely
closing it, which would require recreating a new window to enter PiP
mode again.

This change also reorders the relevant functions to follow the
views::Widget ordering of those functions.

BUG:  837003 
Change-Id: I4323a724dcf7c41176c331794c0a4464e412baf3
Reviewed-on: https://chromium-review.googlesource.com/1028988
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554106}
[modify] https://crrev.com/af4ffc5c1648e8f0d7a436297e3c48ada8f77741/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/af4ffc5c1648e8f0d7a436297e3c48ada8f77741/chrome/browser/ui/views/overlay/overlay_window_views.h
[modify] https://crrev.com/af4ffc5c1648e8f0d7a436297e3c48ada8f77741/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/af4ffc5c1648e8f0d7a436297e3c48ada8f77741/content/public/browser/overlay_window.h

Comment 2 by viswa.karala@chromium.org, Apr 27 2018

Labels: Needs-Feedback
@Jennifer Apacible: Could you please provide sample test file/URL to test and confirm the fix from TE end.

Thanks!

Comment 3 by apaci...@chromium.org, May 4 2018

Status: Fixed (was: Started)
►

Sign in to add a comment