Multiple "FlingControllerTest.*" tests are flaky |
|||||||
Issue description"FlingControllerTest.GestureFlingNotCancelledBySmallTimeDelta" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxGbGluZ0NvbnRyb2xsZXJUZXN0Lkdlc3R1cmVGbGluZ05vdENhbmNlbGxlZEJ5U21hbGxUaW1lRGVsdGEM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9993c30f656438c4a9c7b9a5d7b178cd1924fd58 commit 9993c30f656438c4a9c7b9a5d7b178cd1924fd58 Author: Patrick Noland <pnoland@google.com> Date: Wed Apr 25 23:27:05 2018 Disable flaky test GestureFlingControllerNotCancelledBySmallTimeDelta TBR=tdresser@chromium.org Bug: 836996 Change-Id: Ieb41ef895cdc2ea3ca26b47c4f3a2e9694bacf78 Reviewed-on: https://chromium-review.googlesource.com/1029110 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#553818} [modify] https://crrev.com/9993c30f656438c4a9c7b9a5d7b178cd1924fd58/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Apr 25 2018
Assigning to sahel@, who seems to be leading the renderer->browser fling conversion. Feel feel to re-assign.
,
Jul 30
We're seeing other FlingControllerTest tests flake on Fuchsia/ARM64, e.g. in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-arm64-rel/548 with: [ RUN ] FlingControllerTest.ControllerHandlesTouchpadGestureFling ../../content/browser/renderer_host/input/fling_controller_unittest.cc:173: Failure Expected equality of these values: WebMouseWheelEvent::kPhaseChanged Which is: 4 last_sent_wheel_.momentum_phase Which is: 1 Stack trace: bt#00: pc 0x980f42909b38 (app:/pkg/bin/app,0x2b76b38) bt#01: pc 0x980f41bf41fc (app:/pkg/bin/app,0x1e611fc) bt#02: end ../../content/browser/renderer_host/input/fling_controller_unittest.cc:181: Failure Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -7.68858 vs 0 Stack trace: bt#00: pc 0x980f42909b38 (app:/pkg/bin/app,0x2b76b38) bt#01: pc 0x980f41bf4558 (app:/pkg/bin/app,0x1e61558) bt#02: end [ FAILED ] FlingControllerTest.ControllerHandlesTouchpadGestureFling (243 ms)
,
Jul 31
,
Aug 2
,
Aug 2
Flaked in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-arm64-rel/637 with: [ RUN ] FlingControllerTest.ControllerHandlesTouchpadGestureFling ../../content/browser/renderer_host/input/fling_controller_unittest.cc:175: Failure Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -6.88942 vs 0 Stack trace: bt#00: pc 0x38333d81e878 (app:/pkg/bin/app,0x29b1878) bt#01: pc 0x38333cbb278c (app:/pkg/bin/app,0x1d4578c) bt#02: end [ FAILED ] FlingControllerTest.ControllerHandlesTouchpadGestureFling (171 ms) I'll post a CL to disable this test.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11b2bb0c9afe6eb843155b458fe7b14b0cabfbc0 commit 11b2bb0c9afe6eb843155b458fe7b14b0cabfbc0 Author: Wez <wez@chromium.org> Date: Thu Aug 02 22:32:49 2018 Disable FlingControllerTest.ControllerHandlesTouchpadGestureFling. This test often flakes on the Fuchsia/ARM64 FYI bot, indicating that it is likely racey under pathological scheduler timings. TBR=tdresser@chromium.org Bug: 836996 Change-Id: I365050083bc4a7ee21d3ef5f1e05ccee35dc6cb1 Reviewed-on: https://chromium-review.googlesource.com/1161326 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580355} [modify] https://crrev.com/11b2bb0c9afe6eb843155b458fe7b14b0cabfbc0/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Aug 7
,
Aug 7
FlingControllerTest.ControllerHandlesTouchscreenGestureFling flaked in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-arm64-rel/697 with: [ RUN ] FlingControllerTest.ControllerHandlesTouchscreenGestureFling ../../content/browser/renderer_host/input/fling_controller_unittest.cc:210: Failure Expected: (last_sent_gesture_.data.scroll_update.delta_x) > (0.f), actual: -5.20933 vs 0 Stack trace: #00: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:? #01: content::FlingControllerTest_ControllerHandlesTouchscreenGestureFling_Test::TestBody() at fling_controller_unittest.cc:? [ FAILED ] FlingControllerTest.ControllerHandlesTouchscreenGestureFling (148 ms) FlingControllerTest.ControllerSendsWheelEndWhenTouchpadFlingIsOver flaked in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-arm64-rel/717 with: [ RUN ] FlingControllerTest.ControllerSendsWheelEndWhenTouchpadFlingIsOver ../../content/browser/renderer_host/input/fling_controller_unittest.cc:241: Failure Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -0.338616 vs 0 Stack trace: #00: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:? #01: content::FlingControllerTest_ControllerSendsWheelEndWhenTouchpadFlingIsOver_Test::TestBody() at fling_controller_unittest.cc:? [ FAILED ] FlingControllerTest.ControllerSendsWheelEndWhenTouchpadFlingIsOver (256 ms)
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05b2a8edd34b97b7551f923e2640e9959967225d commit 05b2a8edd34b97b7551f923e2640e9959967225d Author: Wez <wez@chromium.org> Date: Wed Aug 08 19:59:12 2018 Disable some more flaky FlingControllerTest tests. Disable the ControllerHandlesTouchscreenGestureFling and ControllerSendsWheelEndWhenTouchpadFlingIsOver tests, which appear to have timing-dependent flakiness. Bug: 836996 Change-Id: I42b7b23489b4cf2dbb2fdacf89c77bd102ac03a8 Reviewed-on: https://chromium-review.googlesource.com/1166328 Reviewed-by: Sahel Sharify <sahel@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581671} [modify] https://crrev.com/05b2a8edd34b97b7551f923e2640e9959967225d/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Aug 8
FlingControllerTest.GestureFlingWithNegativeTimeDelta flaked in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-arm64-rel/803 with: [ RUN ] FlingControllerTest.GestureFlingWithNegativeTimeDelta ../../content/browser/renderer_host/input/fling_controller_unittest.cc:454: Failure Expected: (last_sent_gesture_.data.scroll_update.delta_x) > (0.f), actual: -3.77142 vs 0 Stack trace: #00: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:? #01: content::FlingControllerTest_GestureFlingWithNegativeTimeDelta_Test::TestBody() at fling_controller_unittest.cc:? [ FAILED ] FlingControllerTest.GestureFlingWithNegativeTimeDelta (152 ms)
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42758fa33cac85e5b433718f6676c2ff8437e93f commit 42758fa33cac85e5b433718f6676c2ff8437e93f Author: Wez <wez@chromium.org> Date: Mon Aug 13 18:06:58 2018 Disable FlingControllerTest.GestureFlingWithNegativeTimeDelta test. This test appears to have timing-dependent flakiness. Bug: 836996 Change-Id: I52382fd881ac0872e98fcf71464f72dcc42f7dcc Reviewed-on: https://chromium-review.googlesource.com/1169960 Reviewed-by: Sahel Sharify <sahel@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#582638} [modify] https://crrev.com/42758fa33cac85e5b433718f6676c2ff8437e93f/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Aug 17
Issue 875186 has been merged into this issue.
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6587e83f92e08d3040ac7504187c09206264fa7c commit 6587e83f92e08d3040ac7504187c09206264fa7c Author: Friedrich Horschig <fhorschig@chromium.org> Date: Fri Aug 17 14:14:02 2018 [Flaky] Disable timing-dependent FlingControllerTest Adding another test to the pile of flaky test in this file. See bugs for recent failures. TBR=sahel@chromium.org,dtapuska@chromium.org Bug: 836996 , 875186 Change-Id: Ie8b3565a9f785304f60ca2e2dac1c6ff77f30fb4 Reviewed-on: https://chromium-review.googlesource.com/1179827 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584055} [modify] https://crrev.com/6587e83f92e08d3040ac7504187c09206264fa7c/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Aug 21
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb656ddad84a5a1ca86fe222fd6d46e2af8410ec commit fb656ddad84a5a1ca86fe222fd6d46e2af8410ec Author: Yoshifumi Inoue <yosin@chromium.org> Date: Tue Aug 21 03:17:18 2018 [Flaky] Disable FlingControllerTest.EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed The test should use better way to compare floating point numbers to handling below case: ../../content/browser/renderer_host/input/fling_controller_unittest.cc:303: Failure Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -0.121721 vs 0 TBR=sahel@chromium.org,dtapuska@chromium.org Bug: 836996 , 875777 Change-Id: Ib9eab4988b1809a753068f7cc2da5815ee7780f1 Reviewed-on: https://chromium-review.googlesource.com/1182713 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584625} [modify] https://crrev.com/fb656ddad84a5a1ca86fe222fd6d46e2af8410ec/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Aug 23
Issue 877228 has been merged into this issue.
,
Aug 23
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c86aa801eb1081d2e3013253268cd5edd0b0fb19 commit c86aa801eb1081d2e3013253268cd5edd0b0fb19 Author: Sahel Sharify <sahel@chromium.org> Date: Thu Aug 23 21:40:45 2018 [Flaky] Disable FlingControllerTest.EarlyTouchscreenFlingCancelationOnInertialGSUAckNotConsumed TBR=tdresser@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836996 Change-Id: Iceb8ee0ba3b67f2f222e7ec4f382814e846d5b5d Reviewed-on: https://chromium-review.googlesource.com/1187513 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585622} [modify] https://crrev.com/c86aa801eb1081d2e3013253268cd5edd0b0fb19/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bf97081ce074c95935ff9df176469112fd2c00a commit 4bf97081ce074c95935ff9df176469112fd2c00a Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Aug 24 23:16:24 2018 Disable flaky test FlingControllerTest.EarlyTouchpadFlingCancelationOnFlingStop . TBR=sahel@chromium.org,tdresser@chromium.org Bug: 836996 Change-Id: Ic88f4b3f3ced63a83a25fa9c341ceaec8a7302a0 Reviewed-on: https://chromium-review.googlesource.com/1189026 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586043} [modify] https://crrev.com/4bf97081ce074c95935ff9df176469112fd2c00a/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Sep 18
Issue 874944 has been merged into this issue.
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5d1654e10cf509a8fd6c572c13e53b6c9af43a5 commit a5d1654e10cf509a8fd6c572c13e53b6c9af43a5 Author: Asanka Herath <asanka@chromium.org> Date: Wed Sep 19 21:09:16 2018 Disable flaky FlingControllerTest FlingControllerTest.EarlyTouchscreenFlingCancelationOnFlingStop is flaky. Bug: 886992 , 836996 Change-Id: I80a732f729ee8691a18ea7948c78cb1c9eb54a01 Reviewed-on: https://chromium-review.googlesource.com/1234976 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592546} [modify] https://crrev.com/a5d1654e10cf509a8fd6c572c13e53b6c9af43a5/content/browser/renderer_host/input/fling_controller_unittest.cc
,
Sep 20
Issue 886992 has been merged into this issue.
,
Sep 25
Checking the flakiness dashboard no new flakiness found after landing the cl in comment #23 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pnoland@chromium.org
, Apr 25 2018