New issue
Advanced search Search tips

Issue 836995 link

Starred by 1 user
Status: Fixed
Owner:
eirage@chromium.org
Closed: May 2018
Cc:
nzolghadr@chromium.org
mustaq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Pointerevent movementX/Y is not set when locked

Project Member Reported by eirage@chromium.org, Apr 25 2018 
Chrome Version: 66.0.3359.117 
OS: All

What steps will reproduce the problem?
(1)https://eirage.github.io/PointerLockLog
(2)check pointermove, then request pointer lock
(3)Move mouse and look at movementX and movementY

What is the expected result?
pointermove event should have movementX/Y value

What happens instead?
pointermove event movementX/Y are all 0


CreateAndDispatchPointerEvent should call  MouseEvent::SetCoordinatesFromWebPointerProperties to set PE coordinates

https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/node.cc?l=2295
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0740ece4aad8c20ea91a9f13207c43af40c043eb

commit 0740ece4aad8c20ea91a9f13207c43af40c043eb
Author: Ella Ge <eirage@chromium.org>
Date: Thu May 17 20:43:07 2018

set movement value for pointer event while locked

This CL changes Node::CreateAndDispatchPointerEvent to use
SetCoordinatesFromWebPointerProperties to set DOM PE coordinates
correctly.

Bug:  836995 
Change-Id: I157a312b37f70f0804edeee39d4c48796bb92ea2
Reviewed-on: https://chromium-review.googlesource.com/1040361
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559666}
[add] https://crrev.com/0740ece4aad8c20ea91a9f13207c43af40c043eb/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerlock/pointerevent_movementxy_when_locked-manual.html
[add] https://crrev.com/0740ece4aad8c20ea91a9f13207c43af40c043eb/third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerlock/pointerevent_movementxy_when_locked-manual-automation.js
[modify] https://crrev.com/0740ece4aad8c20ea91a9f13207c43af40c043eb/third_party/blink/renderer/core/dom/node.cc

Comment 2 by eirage@chromium.org, May 17 2018

Status: Fixed (was: Available)

Comment 3 by eirage@chromium.org, May 17 2018

Cc: -eirage@chromium.org
Owner: eirage@chromium.org
►

Sign in to add a comment