New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836989 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 839175
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Pages with non-empty file_missing_time should be filtered when LoadCache()

Project Member Reported by romax@chromium.org, Apr 25 2018

Issue description

In DownloadUIAdapter::LoadCache(), there is a call to OfflinePageModel::GetAllPages, however we would like to set the temporarily_hidden bit of the item to true if the item(page) has its archive file missing.

This should be done as part of the persistent consistency check but it's been left behind.
 

Comment 1 by romax@chromium.org, Apr 27 2018

Labels: -Pri-1 Pri-3
This reveals a larger issue with DownloadUIAdapter, which is about to be refactored anyway, so maybe a workaround for now should be good enough.

Comment 2 by romax@chromium.org, May 3 2018

Mergedinto: 839175
Status: Duplicate (was: Started)
Merging into the issue which is used to track the right way to fix this issue.

Sign in to add a comment