New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836981 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Raise alert if Findit creates or comments on too many bugs

Project Member Reported by robert...@chromium.org, Apr 25 2018

Issue description

For this, we need to make sure that the codepaths that comment on bugs and file bugs call findit.services.monitoring.OnCulpritAction to increment the right metric.

Then, we need to add a monarch alert to monitor these thresholds.

This is important because this is not monitored (unlike reverts) by the audit app.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ddc334212eac75e76b88d528104c09d69893c1de

commit ddc334212eac75e76b88d528104c09d69893c1de
Author: Roberto Carrillo <robertocn@google.com>
Date: Mon May 07 20:47:15 2018

[Findit] Track bug creation metric for flake.

This is for setting up alerts.

R=lijeffrey,stgao,chanli,liaoyuke

Bug:836981
Change-Id: Ibf9b582e3fb3486df7611229d70f21e0483e27df
Reviewed-on: https://chromium-review.googlesource.com/1048039
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/ddc334212eac75e76b88d528104c09d69893c1de/appengine/findit/services/test/monitoring_test.py
[modify] https://crrev.com/ddc334212eac75e76b88d528104c09d69893c1de/appengine/findit/services/monitoring.py
[modify] https://crrev.com/ddc334212eac75e76b88d528104c09d69893c1de/appengine/findit/services/issue_tracking_service.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1fe4454a63c7e1b0bf7e327b000912704d2a6011

commit 1fe4454a63c7e1b0bf7e327b000912704d2a6011
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon May 07 21:07:56 2018

Revert "[Findit] Track bug creation metric for flake."

This reverts commit ddc334212eac75e76b88d528104c09d69893c1de.

Reason for revert: tests failed on CI:
fatal error: .concurrent map read and map write
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.infra%2Finfra-continuous-trusty-64%2F12121%2F%2B%2Frecipes%2Fsteps%2Finfra_go_tests%2F0%2Fstdout

Original change's description:
> [Findit] Track bug creation metric for flake.
> 
> This is for setting up alerts.
> 
> R=​lijeffrey,stgao,chanli,liaoyuke
> 
> Bug:836981
> Change-Id: Ibf9b582e3fb3486df7611229d70f21e0483e27df
> Reviewed-on: https://chromium-review.googlesource.com/1048039
> Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
> Reviewed-by: Chan Li <chanli@chromium.org>
> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
> Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

TBR=stgao@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org,liaoyuke@chromium.org

Change-Id: I537b721c8325152312d493944ab127e472ead20d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836981
Reviewed-on: https://chromium-review.googlesource.com/1047888
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/1fe4454a63c7e1b0bf7e327b000912704d2a6011/appengine/findit/services/test/monitoring_test.py
[modify] https://crrev.com/1fe4454a63c7e1b0bf7e327b000912704d2a6011/appengine/findit/services/monitoring.py
[modify] https://crrev.com/1fe4454a63c7e1b0bf7e327b000912704d2a6011/appengine/findit/services/issue_tracking_service.py

Project Member

Comment 3 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/64b11dfc9d93ee9cd6b443235d7008f6f55663a4

commit 64b11dfc9d93ee9cd6b443235d7008f6f55663a4
Author: Roberto Carrillo <robertocn@google.com>
Date: Mon May 07 23:39:15 2018

Reland "[Findit] Track bug creation metric for flake."

This is a reland of ddc334212eac75e76b88d528104c09d69893c1de

Original change's description:
> [Findit] Track bug creation metric for flake.
> 
> This is for setting up alerts.
> 
> R=lijeffrey,stgao,chanli,liaoyuke
> 
> Bug:836981
> Change-Id: Ibf9b582e3fb3486df7611229d70f21e0483e27df
> Reviewed-on: https://chromium-review.googlesource.com/1048039
> Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
> Reviewed-by: Chan Li <chanli@chromium.org>
> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
> Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

Bug: 836981
Change-Id: I9f5fea05283ef2a9399fea4f3cfccb66b34d97e1
Reviewed-on: https://chromium-review.googlesource.com/1048568
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/64b11dfc9d93ee9cd6b443235d7008f6f55663a4/appengine/findit/services/test/monitoring_test.py
[modify] https://crrev.com/64b11dfc9d93ee9cd6b443235d7008f6f55663a4/appengine/findit/services/monitoring.py
[modify] https://crrev.com/64b11dfc9d93ee9cd6b443235d7008f6f55663a4/appengine/findit/services/issue_tracking_service.py

Sign in to add a comment