[desktopCapture OSX] screen capture stops internally on some MBP |
||||||||
Issue descriptionThe high performance MBP has both discrete and integrated graphic cards in the device. By default Auto Graphics Switching is ON. Some Apps that request high performance card cause the switching from integrated card to discrete one. For energy saving, it will switch back to integrated card when high performance graphic is not needed. So far we notice that at switching from discrete card to integrated card, the current display ID will change, even if there is only the built-in display working on the MBP. Currently the screen capture will stop because of the change of display ID. As a matter of fact, the two display IDs are mapping to the same built-in display and both of them are valid. So one possible workaround is when we detect that it's the built-in display with different display ID, we can ignore the change and continue capturing its content.
,
Apr 27 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/ad7f6e5ccf77d8e66da46572f89c49b513ba9774 commit ad7f6e5ccf77d8e66da46572f89c49b513ba9774 Author: braveyao <braveyao@webrtc.org> Date: Fri Apr 27 04:07:05 2018 [desktopCapture Mac] Continue screen capture at graphic cards switching The MBP having both discrete and integrated graphic cards will do automate graphics switching by default. When it switches from discrete to integrated one, the current display ID of the built-in display will change and this will cause screen capture stops. So make screen capture of built-in display continuing even if its display ID is changed. Bug: chromium:836979 Change-Id: If4f2d04d99a2690ccd6f894d94e6f8ff58ba2ec8 Reviewed-on: https://webrtc-review.googlesource.com/72603 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23048} [modify] https://crrev.com/ad7f6e5ccf77d8e66da46572f89c49b513ba9774/modules/desktop_capture/mac/desktop_configuration.h [modify] https://crrev.com/ad7f6e5ccf77d8e66da46572f89c49b513ba9774/modules/desktop_capture/mac/desktop_configuration.mm
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19efe598865bd44b887849f8014adda35498da6f commit 19efe598865bd44b887849f8014adda35498da6f Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 27 06:37:17 2018 Roll src/third_party/webrtc/ e782abab1..ad7f6e5cc (3 commits) https://webrtc.googlesource.com/src.git/+log/e782abab190e..ad7f6e5ccf77 $ git log e782abab1..ad7f6e5cc --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:836979 ,chromium:None,chromium:829238 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I972385f763f181ae3e2f599e8db257bb3ae1f730 Reviewed-on: https://chromium-review.googlesource.com/1032051 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554327} [modify] https://crrev.com/19efe598865bd44b887849f8014adda35498da6f/DEPS
,
Apr 30 2018
Verified on Mac with Canary 68.0.3414.0.
,
Apr 30 2018
,
Apr 30 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 30 2018
Before we approve merge to M67, please answer followings: * Is this M67 regression? Is it critical? * Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M67? * Any other important details to justify the merge. Please note M67 is already in Beta, so merge bar is VERY high. Thank you.
,
Apr 30 2018
- It's not a regression. It's largely reported recently on Mac within Google, ~60K endpoints impacted daily according to the dashboard and has been tracked for months. The fact should be related to the massive machines switching to the new MBP 15" with touch bar. - It's verified in Canary. - The change is trivial. - This also depends on the fix to issue 836978 .
,
Apr 30 2018
Approving merge to M67 branch 3396 based on comment #8. Please merge ASAP. Thank you.
,
Apr 30 2018
Merged to branch/67 with https://webrtc-review.googlesource.com/c/src/+/73500.
,
Apr 30 2018
,
Jun 7 2018
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
,
Jun 7 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by braveyao@chromium.org
, Apr 25 2018