New issue
Advanced search Search tips

Issue 836975 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 836070



Sign in to add a comment

[CRD iOS] First frame not rendered after app brought back from the background

Project Member Reported by yuweih@chromium.org, Apr 25 2018

Issue description

App Version: 68.0.3400.0
OS: 11.3

What steps will reproduce the problem?
(1) Connect to a host
(2) Switch to touch input mode
(3) Make sure the desktop is static. Nothing is changing on the screen.
(4) Press home button to bring the app to background
(5) Resume the app from background

What is the expected result?
The user's current desktop is rendered almost immediately.

What happens instead?
The screen is black. User needs to tap or zoom a little bit to get the frame rendered.
 

Comment 1 by yuweih@chromium.org, Apr 25 2018

Blocking: 836070
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab25983531e94546c8d4e658c67c2cbaa4640900

commit ab25983531e94546c8d4e658c67c2cbaa4640900
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Apr 26 00:19:30 2018

[CRD iOS] Feed viewport transformation matrix when renderer context is recreated

The app no longer renders the first frame after we recreate the renderer
context when the app resumes. User has to move the cursor or viewport
to get the frame rendered. That's because we didn't set the transformation
matrix after the renderer context is recreated.

This CL makes GlRenderer cache the viewport matrix and set it on the
canvas when the canvas is recreated.

Bug:  836975 
Change-Id: I3d4bb2575aa59f9148181104f320cf7a72770ad5
Reviewed-on: https://chromium-review.googlesource.com/1028848
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553841}
[modify] https://crrev.com/ab25983531e94546c8d4e658c67c2cbaa4640900/remoting/client/display/gl_renderer.cc
[modify] https://crrev.com/ab25983531e94546c8d4e658c67c2cbaa4640900/remoting/client/display/gl_renderer.h

Comment 3 by yuweih@chromium.org, Apr 26 2018

Labels: Merge-Request-67
Requesting merge for M67.

This change only affects Chromoting and doesn't affect the Chrome browser. It has been tested on ToT build of Chrome Remote Desktop for iOS.
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 26 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: Less than 29 days to go before AppStore submit on M67
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cad2fb014d2a0d5f8c94090897e1563e365fa5a5

commit cad2fb014d2a0d5f8c94090897e1563e365fa5a5
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Apr 26 20:48:56 2018

[CRD iOS] Feed viewport transformation matrix when renderer context is recreated

The app no longer renders the first frame after we recreate the renderer
context when the app resumes. User has to move the cursor or viewport
to get the frame rendered. That's because we didn't set the transformation
matrix after the renderer context is recreated.

This CL makes GlRenderer cache the viewport matrix and set it on the
canvas when the canvas is recreated.

Bug:  836975 
Change-Id: I3d4bb2575aa59f9148181104f320cf7a72770ad5
Reviewed-on: https://chromium-review.googlesource.com/1028848
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553841}(cherry picked from commit ab25983531e94546c8d4e658c67c2cbaa4640900)
Reviewed-on: https://chromium-review.googlesource.com/1031271
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#340}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/cad2fb014d2a0d5f8c94090897e1563e365fa5a5/remoting/client/display/gl_renderer.cc
[modify] https://crrev.com/cad2fb014d2a0d5f8c94090897e1563e365fa5a5/remoting/client/display/gl_renderer.h

Comment 7 by yuweih@chromium.org, Apr 26 2018

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verifed Fixed in 67.3396.22

Sign in to add a comment